From patchwork Sat Oct 22 08:48:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 78765 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp1689269qge; Sat, 22 Oct 2016 01:49:33 -0700 (PDT) X-Received: by 10.98.23.144 with SMTP id 138mr9472258pfx.21.1477126173620; Sat, 22 Oct 2016 01:49:33 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m6si6051829pgd.269.2016.10.22.01.49.33; Sat, 22 Oct 2016 01:49:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936678AbcJVItZ (ORCPT + 27 others); Sat, 22 Oct 2016 04:49:25 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:36853 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932826AbcJVItW (ORCPT ); Sat, 22 Oct 2016 04:49:22 -0400 Received: by mail-pf0-f179.google.com with SMTP id e6so70118578pfk.3 for ; Sat, 22 Oct 2016 01:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=A9Rf5impfgnDkdbDDU/PbM2YusXZSKqW6mG00saNew8=; b=MqyzHAH2QQGu0VgSN1oVZHLE8lrU3Or7KsUQ7PrC5M3lR6S8q9WmNQh9IrNP5g/MsK GuyckqOuiPZRYwAQSwzlbrEZ1ISj9HcTAbnAXtnAdwpmVHy5kHwZhij/MzTgKJq1ypoN 5AKQPi0UFWZLZM2OM+2qrlBlRZ9u4GjrgleHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A9Rf5impfgnDkdbDDU/PbM2YusXZSKqW6mG00saNew8=; b=Yuq4MmcI4XxOOM0WX3m9839LSt3iFR/io6bxS8qf2dov1dzDSTSvO265GlquDxqzrn OAIL3u6ez1qKif9yr9NXWpO/u7A7liS65K7w+Ek9le6bmu9A5/awLo7or99OxBegN05J FEQdADmSqN6EBBiGjl7aSn0bbZq/dMSQWzqNYB6SHQ37XmNWD7ptMXFV6NpXIhyTJcZE PUrKsh2Gs848HWQAa2MXQbDziwzfk0eQU49TfyqV47QXjgWWIxsn1qsy3TPF9I7ycHlN 0//KKNaVIpvDSiyaC9ChkFzQzvsgkuF1l0QDbNc/xHfBwI2nDeCppuvFjlRkV/W0qlJI LQDQ== X-Gm-Message-State: ABUngveu/+aYbkqFYLhJAL7w5e98vthDeyZrL5qQCI+tsgtTKdlnkqRo/Uclejma9E4uqRHt X-Received: by 10.98.102.221 with SMTP id s90mr9392132pfj.146.1477126161876; Sat, 22 Oct 2016 01:49:21 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.92]) by smtp.gmail.com with ESMTPSA id bx5sm10529447pad.6.2016.10.22.01.49.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 22 Oct 2016 01:49:21 -0700 (PDT) From: Baoyou Xie To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, nicolai.haehnle@amd.com, Jammy.Zhou@amd.com, Qingqing.Wang@amd.com, daniel.vetter@ffwll.ch, tom.stdenis@amd.com, michel.daenzer@amd.com, gustavo.padovan@collabora.co.uk, eric.engestrom@imgtec.com, Emily.Deng@amd.com, David1.Zhou@amd.com, CARLOS.PALMINHA@synopsys.com, ville.syrjala@linux.intel.com, Flora.Cui@amd.com, vitaly.prosyak@amd.com, alexandre.f.demers@gmail.com, Jerry.Zhang@amd.com, Rex.Zhu@amd.com, funfunctor@folklore1984.net Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH 2/3] drm/amdgpu: mark symbols static where possible Date: Sat, 22 Oct 2016 16:48:26 +0800 Message-Id: <1477126107-2466-2-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477126107-2466-1-git-send-email-baoyou.xie@linaro.org> References: <1477126107-2466-1-git-send-email-baoyou.xie@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/amd/amdgpu/si.c:908:5: warning: no previous prototype for 'si_pciep_rreg' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/si.c:921:6: warning: no previous prototype for 'si_pciep_wreg' [-Wmissing-prototypes] In fact, both functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/amd/amdgpu/si.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index dc9511c..bacdff8 100644 --- a/drivers/gpu/drm/amd/amdgpu/si.c +++ b/drivers/gpu/drm/amd/amdgpu/si.c @@ -905,7 +905,7 @@ static void si_pcie_wreg(struct amdgpu_device *adev, u32 reg, u32 v) spin_unlock_irqrestore(&adev->pcie_idx_lock, flags); } -u32 si_pciep_rreg(struct amdgpu_device *adev, u32 reg) +static u32 si_pciep_rreg(struct amdgpu_device *adev, u32 reg) { unsigned long flags; u32 r; @@ -918,7 +918,7 @@ u32 si_pciep_rreg(struct amdgpu_device *adev, u32 reg) return r; } -void si_pciep_wreg(struct amdgpu_device *adev, u32 reg, u32 v) +static void si_pciep_wreg(struct amdgpu_device *adev, u32 reg, u32 v) { unsigned long flags;