From patchwork Sat Oct 22 09:03:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 78768 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp1693305qge; Sat, 22 Oct 2016 02:04:31 -0700 (PDT) X-Received: by 10.99.119.72 with SMTP id s69mr7925314pgc.11.1477127070966; Sat, 22 Oct 2016 02:04:30 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si5110671pad.79.2016.10.22.02.04.30; Sat, 22 Oct 2016 02:04:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936537AbcJVJE1 (ORCPT + 27 others); Sat, 22 Oct 2016 05:04:27 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34515 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936436AbcJVJEW (ORCPT ); Sat, 22 Oct 2016 05:04:22 -0400 Received: by mail-pf0-f170.google.com with SMTP id r16so70292016pfg.1 for ; Sat, 22 Oct 2016 02:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=1nnOEe3kzw35XNzKymO/hiBfbvQlsZyM3xva3PUcGHE=; b=keMWMIdrQeZWLStLwFZT3+9FhI8UMZQBJJd/BFr0vrMYZp0W5h2D9vcrue/Tju3RUK YoOZXfHy9C6Lb06uTE9NBQbBUAOqTSBhNAbHcdh6Qdm4dSHavUQ372by2vItjajlcwa8 yhQgHV0SXSDm4eOa6rCSzWYOo8m/hEEr261lc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1nnOEe3kzw35XNzKymO/hiBfbvQlsZyM3xva3PUcGHE=; b=abWfAuXC0fMvvm89aw0TlTXnJp748nYc3bBR6qvW21+1ZuS1h8QTTeiI+zetwWuGPJ wi0C+wZHLonxvGF48YU95fPhWdaOZxUq7prWMFmZaJlL3r8VVNo3bWY7jWmJNZRjUh9z fNA0nmVlSOhKJXhxYe0qPZE4ZCvFLXk3+L3IdtiF0Fc9ngbRSBQaRCoxyWFQJEVR/SZc 4d6UMK9Y7M3Qosh/SImU1eUQWtTKV6jAhp6aGtwLnO49nVjaczaqm3zl/Vfr2wsZAT0Z /IMaJGkw51vGvr9tJcWTKe0E9lND+Jw5y9ehUyqxulMWW5RFrESPidutXlVwSrbwnr9A Hbrg== X-Gm-Message-State: ABUngvfgUVAv0OyxaIv5uuiAIc49bJVSP9oAzKTtJlU+f7qd0Ocyli/BgSdszewxwkydTVAv X-Received: by 10.98.3.65 with SMTP id 62mr9423315pfd.98.1477127061910; Sat, 22 Oct 2016 02:04:21 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.92]) by smtp.gmail.com with ESMTPSA id 128sm10652542pfy.4.2016.10.22.02.04.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 22 Oct 2016 02:04:21 -0700 (PDT) From: Baoyou Xie To: rmk+kernel@armlinux.org.uk, airlied@linux.ie, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH] drm/armada: mark symbols static where possible Date: Sat, 22 Oct 2016 17:03:58 +0800 Message-Id: <1477127038-18867-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/armada/armada_gem.c:215:27: warning: no previous prototype for 'armada_gem_alloc_object' [-Wmissing-prototypes] drivers/gpu/drm/armada/armada_gem.c:423:1: warning: no previous prototype for 'armada_gem_prime_map_dma_buf' [-Wmissing-prototypes] In fact, both functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/armada/armada_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c index 8067918..63c3a14 100644 --- a/drivers/gpu/drm/armada/armada_gem.c +++ b/drivers/gpu/drm/armada/armada_gem.c @@ -212,7 +212,7 @@ armada_gem_alloc_private_object(struct drm_device *dev, size_t size) return obj; } -struct armada_gem_object *armada_gem_alloc_object(struct drm_device *dev, +static struct armada_gem_object *armada_gem_alloc_object(struct drm_device *dev, size_t size) { struct armada_gem_object *obj; @@ -419,7 +419,7 @@ int armada_gem_pwrite_ioctl(struct drm_device *dev, void *data, } /* Prime support */ -struct sg_table * +static struct sg_table * armada_gem_prime_map_dma_buf(struct dma_buf_attachment *attach, enum dma_data_direction dir) {