From patchwork Sat Oct 22 09:13:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 78770 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp1695907qge; Sat, 22 Oct 2016 02:13:26 -0700 (PDT) X-Received: by 10.99.109.196 with SMTP id i187mr8033690pgc.164.1477127606742; Sat, 22 Oct 2016 02:13:26 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fn1si5109384pad.302.2016.10.22.02.13.26; Sat, 22 Oct 2016 02:13:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936570AbcJVJNX (ORCPT + 27 others); Sat, 22 Oct 2016 05:13:23 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:34783 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936454AbcJVJNW (ORCPT ); Sat, 22 Oct 2016 05:13:22 -0400 Received: by mail-pf0-f171.google.com with SMTP id r16so70374892pfg.1 for ; Sat, 22 Oct 2016 02:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=fAIzhUz5UvP/y6asE6vQzjZ/qkSu+wNqF3JcNCHQRE4=; b=RBB+fSj+JMusJaaOxq6uWHLCBc7A7w0lr2om8PLgAKNJCXRDPlbi0MoXFc++3XkDeE liZ6wCqOuXA55bh/UHyUG7FsTAi9nHQRrz7NzsurPGb3149HtLfOji8R45A49uzR8/E5 n6lqoFQFVfP7GUIuLsMJiL7hnWnbtwweFf5OI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fAIzhUz5UvP/y6asE6vQzjZ/qkSu+wNqF3JcNCHQRE4=; b=SwGqutzCgcUvS2BA4eQRHcm/ImiXkKLwSJgRR4YW7skpxscu5OxePDlVWs+M3k3RnG TIavHYX1HWkxXahC8Cbt4DmlCy+IFYyp/CpK773Ck2Zxh/4iaf19fxswdC1wQ9RHeBz4 mGFVXUnRsqXxWc/X7SkEYStaEkPzuaSys4I8ogaEHFUkCIJMjuo1xqUNmLye4Wed886M mAVzqDLITaignFeu07kqbbakcUIEP9qk6hS7cUjjtAj6bLVOBkKtY57oseDvc6AulYVN kzeRiQi0g145ejS+eQ+3Pf82NIsgp6lffE2mIsdrZok6jBBk6TPe+qh8w+yvX9fCVv5w q/vg== X-Gm-Message-State: ABUngveTxvkqm9LmPubYfUxSZBGDjmSh2vIxZLWZ/2Ksf9MhZt1GF8q2vm1KuFFTquBnsbjK X-Received: by 10.99.99.195 with SMTP id x186mr7787235pgb.5.1477127601573; Sat, 22 Oct 2016 02:13:21 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.92]) by smtp.gmail.com with ESMTPSA id d142sm10711482pfd.33.2016.10.22.02.13.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 22 Oct 2016 02:13:20 -0700 (PDT) From: Baoyou Xie To: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH] drm/arm: mark symbols static where possible Date: Sat, 22 Oct 2016 17:13:01 +0800 Message-Id: <1477127581-1095-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/arm/malidp_planes.c:49:25: warning: no previous prototype for 'malidp_duplicate_plane_state' [-Wmissing-prototypes] drivers/gpu/drm/arm/malidp_planes.c:66:6: warning: no previous prototype for 'malidp_destroy_plane_state' [-Wmissing-prototypes] In fact, both functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/arm/malidp_planes.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index 82c193e..5339e87 100644 --- a/drivers/gpu/drm/arm/malidp_planes.c +++ b/drivers/gpu/drm/arm/malidp_planes.c @@ -46,7 +46,8 @@ static void malidp_de_plane_destroy(struct drm_plane *plane) devm_kfree(plane->dev->dev, mp); } -struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) +static struct +drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) { struct malidp_plane_state *state, *m_state; @@ -63,7 +64,7 @@ struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) return &state->base; } -void malidp_destroy_plane_state(struct drm_plane *plane, +static void malidp_destroy_plane_state(struct drm_plane *plane, struct drm_plane_state *state) { struct malidp_plane_state *m_state = to_malidp_plane_state(state);