From patchwork Sat Oct 22 09:17:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 78772 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp1697191qge; Sat, 22 Oct 2016 02:18:08 -0700 (PDT) X-Received: by 10.99.173.3 with SMTP id g3mr8012090pgf.12.1477127888798; Sat, 22 Oct 2016 02:18:08 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x19si6205106pgx.6.2016.10.22.02.18.08; Sat, 22 Oct 2016 02:18:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936602AbcJVJSF (ORCPT + 27 others); Sat, 22 Oct 2016 05:18:05 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36813 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936463AbcJVJSC (ORCPT ); Sat, 22 Oct 2016 05:18:02 -0400 Received: by mail-pf0-f170.google.com with SMTP id e6so70379532pfk.3 for ; Sat, 22 Oct 2016 02:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=HpL16eDN5XCTiqvZRKlclxTYlJl82IINNNGVY7blnXQ=; b=Fi6Gh9LHTH1gLl9SSVm1ccwEa/PRq572GL+/ZROP/T5Ddm8aoUVW2NeyoMPbQGWTpn RRTGyNk4SsQBBlIe3vWJ24OGjn5B8em2R2SdGhaSrmFRCXPFpYQyZ2697dVjhasip/ME KSUeVSgu1j5sFJDfJ9vYqdeh2r2q30s798p8o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HpL16eDN5XCTiqvZRKlclxTYlJl82IINNNGVY7blnXQ=; b=OGmz8nwN9OwDHnoNRuwYNy1rWjMOY6Vj7uVu7JqxkX8pLNCnNnFbYFvCuuj0DOtqaH 3iHvWwt5BBwfnRBW4Vif7LTeyvCjeMCNz4cAHqLaGnSC3gPRY/vEFnTdd2I/h1OrQGE2 m6Gu2JhhWAxZjpPEyWWXdLXIMJLn0jXBl1SEu5S6tFDz+Jwg9iGkalQbRSQh3/9dJotu vlcbv0tl9h9/XP1TguG/mCpgqp9bUhg67vOvKQFKcmsqPjugwL39/PauBPN0oCWjeK8o 7V+Q1VkSZLuNLysU6om+J29F5sp+U0pY8lLifoofzKwV8Ih1ub57SjA9Xq29SPrHKRje D4pQ== X-Gm-Message-State: ABUngvc+ZueaIyoIXZ6sk3E8oO+7YBanrqDXvIOh36wxd3TmX87gUmsX1U27gcr8GMqbNXTh X-Received: by 10.99.52.131 with SMTP id b125mr8018460pga.42.1477127882037; Sat, 22 Oct 2016 02:18:02 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.92]) by smtp.gmail.com with ESMTPSA id ak3sm10770537pad.19.2016.10.22.02.17.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 22 Oct 2016 02:18:01 -0700 (PDT) From: Baoyou Xie To: robdclark@gmail.com, airlied@linux.ie, architt@codeaurora.org, cstout@chromium.org Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH 2/2] drm/msm/adreno: move function declarations to header file Date: Sat, 22 Oct 2016 17:17:44 +0800 Message-Id: <1477127865-9381-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/msm/adreno/a3xx_gpu.c:535:17: warning: no previous prototype for 'a3xx_gpu_init' [-Wmissing-prototypes] drivers/gpu/drm/msm/adreno/a4xx_gpu.c:624:17: warning: no previous prototype for 'a4xx_gpu_init' [-Wmissing-prototypes] In fact, both functions are declared in drivers/gpu/drm/msm/adreno/adreno_device.c, but should be declared in a header file. So this patch moves both function declarations to drivers/gpu/drm/msm/adreno/adreno_gpu.h. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/msm/adreno/adreno_device.c | 3 --- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index 5127b75..7250ffc 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -25,9 +25,6 @@ bool hang_debug = false; MODULE_PARM_DESC(hang_debug, "Dump registers when hang is detected (can be slow!)"); module_param_named(hang_debug, hang_debug, bool, 0600); -struct msm_gpu *a3xx_gpu_init(struct drm_device *dev); -struct msm_gpu *a4xx_gpu_init(struct drm_device *dev); - static const struct adreno_info gpulist[] = { { .rev = ADRENO_REV(3, 0, 5, ANY_ID), diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h index a54f6e0..07d99bd 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -311,4 +311,7 @@ static inline void adreno_gpu_write(struct adreno_gpu *gpu, gpu_write(&gpu->base, reg - 1, data); } +struct msm_gpu *a3xx_gpu_init(struct drm_device *dev); +struct msm_gpu *a4xx_gpu_init(struct drm_device *dev); + #endif /* __ADRENO_GPU_H__ */