From patchwork Sat Oct 22 09:41:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 78785 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp1703464qge; Sat, 22 Oct 2016 02:44:28 -0700 (PDT) X-Received: by 10.98.77.1 with SMTP id a1mr9803656pfb.160.1477129468018; Sat, 22 Oct 2016 02:44:28 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z68si6291138pgz.5.2016.10.22.02.44.27; Sat, 22 Oct 2016 02:44:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964996AbcJVJoT (ORCPT + 27 others); Sat, 22 Oct 2016 05:44:19 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:36517 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936494AbcJVJoP (ORCPT ); Sat, 22 Oct 2016 05:44:15 -0400 Received: by mail-pf0-f177.google.com with SMTP id e6so70616054pfk.3 for ; Sat, 22 Oct 2016 02:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kzrFv9CZZiX/CAvw8Fy9St2XXaSlh0JYphwKkIFjjMQ=; b=kkZReP6AFVUqZfUNiyGPa+nnrr2QUQmouReuFKt5pKQEfPL+9QG3xoA7NBQizkhPa8 9dJQr3CnJMkFlal7/YPutnym50rEUC5XTSFyV31otgfOg3F0//2IXloHsmJkpxXCV0S/ HjL+qNX/v+KWTrFr7b1EghQV2jcBa4gACY9sE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kzrFv9CZZiX/CAvw8Fy9St2XXaSlh0JYphwKkIFjjMQ=; b=j6O+YsagFW8loHolLHPMG+CNx6F8o15XG4wUVk3hg7zg6COfufmdSv9kGk0/UjPa6L ZEZjciHl0dtgce32k9+Eo0Oe/peJAQ1pwTgp84G/CkASwENMgocHa8zSu52KWieGQohZ FA8jod1TBW7LCsZPL5qlJg8vFvKZjAqKnhBAyHZN3trHodjs2lcvWmSOH9guy6Vt+CrR T2mRXRiMCx0g3WhT+2KrWyfeCYtjF9iWJeQYOGsgdDfzCYPdr90ye088MC7HurQ3uDEa MdM7XxZcBGrqoaiCEfR5m3Hc3OEv3DRnLz1yK5su/wRhJDjyXrkvo+BpveW+B8pj8IQf Ejmg== X-Gm-Message-State: ABUngvcwpFSAfZyuYsG0waiU9isNJ5ZCFx0kJwxO5BOrQ2U8bkOB9h7Z67FQTzJPFm1s6XP3 X-Received: by 10.99.56.87 with SMTP id h23mr8041970pgn.82.1477129454947; Sat, 22 Oct 2016 02:44:14 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.92]) by smtp.gmail.com with ESMTPSA id g9sm10923953paw.40.2016.10.22.02.44.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 22 Oct 2016 02:44:14 -0700 (PDT) From: Baoyou Xie To: bskeggs@redhat.com, airlied@linux.ie, acourbot@nvidia.com, imirkin@alum.mit.edu, Julia.Lawall@lip6.fr, martin.peres@free.fr, rspliet@eclipso.eu, nouveau@karolherbst.de Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH 12/17] drm/nouveau/fifo: mark symbols static where possible Date: Sat, 22 Oct 2016 17:41:53 +0800 Message-Id: <1477129318-29677-12-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477129318-29677-1-git-send-email-baoyou.xie@linaro.org> References: <1477129318-29677-1-git-send-email-baoyou.xie@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c:133:1: warning: no previous prototype for 'g84_fifo_chan_engine_init' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c:174:1: warning: no previous prototype for 'g84_fifo_chan_object_ctor' [-Wmissing-prototypes] In fact, both functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c index aeb3387..15a992b 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c @@ -129,7 +129,7 @@ g84_fifo_chan_engine_fini(struct nvkm_fifo_chan *base, } -int +static int g84_fifo_chan_engine_init(struct nvkm_fifo_chan *base, struct nvkm_engine *engine) { @@ -170,7 +170,7 @@ g84_fifo_chan_engine_ctor(struct nvkm_fifo_chan *base, return nvkm_object_bind(object, NULL, 0, &chan->engn[engn]); } -int +static int g84_fifo_chan_object_ctor(struct nvkm_fifo_chan *base, struct nvkm_object *object) {