From patchwork Sat Oct 22 09:41:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 78790 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp1703687qge; Sat, 22 Oct 2016 02:45:28 -0700 (PDT) X-Received: by 10.99.168.78 with SMTP id i14mr8131533pgp.162.1477129528225; Sat, 22 Oct 2016 02:45:28 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q126si6275619pga.81.2016.10.22.02.45.26; Sat, 22 Oct 2016 02:45:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965047AbcJVJpR (ORCPT + 27 others); Sat, 22 Oct 2016 05:45:17 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:35728 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964870AbcJVJpB (ORCPT ); Sat, 22 Oct 2016 05:45:01 -0400 Received: by mail-pf0-f181.google.com with SMTP id s8so70650554pfj.2 for ; Sat, 22 Oct 2016 02:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2mzpgSA/bKsGArfa2I54w95Y42BeiTVZ0kpl6y6ZRME=; b=IkVMfWaluY1O+F74Qi3KMLsjtIeAxdHPvAdecacA0jX4EEgVSBo0KA6C83jg53FkN0 pBhvA6WYObSJBBhRWl4MfBdf3Twt9VmHwwcCp33WY2abaS0pO5taT7JxRwll2XBV4s1P 75kHwJJPEkzXB+SnjnmrxxPWFqtbv5WpODiTM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2mzpgSA/bKsGArfa2I54w95Y42BeiTVZ0kpl6y6ZRME=; b=OLMh+9Ob+wqmwwA80CoMthD+vxYqDxnvdzYW1BTtq3ObEsFonlpqJk0oN1NHmI7ORj nvcmSIY9+HXa8He8cL4TwzTT7h5C7Y1uuNkwr2VoVmEqqG0lAxPVF2CM5RM9IoPeRGQF FCQXnHq9voDkFJcZKSssT/GXlITPRnuLBPtgo8vcYUtpM0sMXBPzkesX3pG5LATg5ye7 XLhI+P2kDzfBhyneegomPZ4S2APg7dOw0Oi599899qloSsebO8r7SfEx+4lXar+yYqnk s9fQv2riu8P9tkMvaPlmLyLzGC79/48vAmPBWvEFw51lbBVem09Lt+Ry+oDghwgYBZ4S ecWg== X-Gm-Message-State: ABUngvewXV8IW0whm/vVi42RnXpRyt9tLjzhBOXXi+tSkGSfLjKl8l6ROyAvf5vWJBT6UdUI X-Received: by 10.98.7.148 with SMTP id 20mr9922200pfh.18.1477129500819; Sat, 22 Oct 2016 02:45:00 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.92]) by smtp.gmail.com with ESMTPSA id g9sm10923953paw.40.2016.10.22.02.44.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 22 Oct 2016 02:45:00 -0700 (PDT) From: Baoyou Xie To: bskeggs@redhat.com, airlied@linux.ie, acourbot@nvidia.com, imirkin@alum.mit.edu, Julia.Lawall@lip6.fr, martin.peres@free.fr, rspliet@eclipso.eu, nouveau@karolherbst.de Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH 17/17] drm/nouveau: mark symbols static where possible Date: Sat, 22 Oct 2016 17:41:58 +0800 Message-Id: <1477129318-29677-17-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477129318-29677-1-git-send-email-baoyou.xie@linaro.org> References: <1477129318-29677-1-git-send-email-baoyou.xie@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/nouveau/nouveau_display.c:96:1: warning: no previous prototype for 'nouveau_display_scanoutpos_head' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nv10_fence.c:70:1: warning: no previous prototype for 'nv10_fence_context_new' [-Wmissing-prototypes] In fact, both functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/nouveau/nouveau_display.c | 2 +- drivers/gpu/drm/nouveau/nv10_fence.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index afbf557..b60ee21 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c @@ -92,7 +92,7 @@ calc(int blanks, int blanke, int total, int line) return line; } -int +static int nouveau_display_scanoutpos_head(struct drm_crtc *crtc, int *vpos, int *hpos, ktime_t *stime, ktime_t *etime) { diff --git a/drivers/gpu/drm/nouveau/nv10_fence.c b/drivers/gpu/drm/nouveau/nv10_fence.c index 4e3de34..619f79d 100644 --- a/drivers/gpu/drm/nouveau/nv10_fence.c +++ b/drivers/gpu/drm/nouveau/nv10_fence.c @@ -66,7 +66,7 @@ nv10_fence_context_del(struct nouveau_channel *chan) nouveau_fence_context_free(&fctx->base); } -int +static int nv10_fence_context_new(struct nouveau_channel *chan) { struct nv10_fence_chan *fctx;