From patchwork Sat Oct 22 09:41:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 78775 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp1703092qge; Sat, 22 Oct 2016 02:42:42 -0700 (PDT) X-Received: by 10.98.4.6 with SMTP id 6mr9701184pfe.152.1477129362509; Sat, 22 Oct 2016 02:42:42 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y17si6248206pgh.187.2016.10.22.02.42.42; Sat, 22 Oct 2016 02:42:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964788AbcJVJmh (ORCPT + 27 others); Sat, 22 Oct 2016 05:42:37 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:33735 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936567AbcJVJmg (ORCPT ); Sat, 22 Oct 2016 05:42:36 -0400 Received: by mail-pf0-f177.google.com with SMTP id 128so70837259pfz.0 for ; Sat, 22 Oct 2016 02:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j0x9s/TMTLLmleoson/L9rAzlZx+zfWc/r5iECOsvo8=; b=eJrAKEsh2onD8vrhEVfitVAS7BdbV1JJNHaqOZIAiNjRksCmtMuJzR314uJU8zTUfy fM+c5j9X6vWAvUfyg1OXT9N4zFrQl8oJ8gaflKZ4ECc4mHDStlBdinXyaI0bNH2qSdXV hai18hAG72vQNkZzShoE4L+xDVJBjJ10Sdxqk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=j0x9s/TMTLLmleoson/L9rAzlZx+zfWc/r5iECOsvo8=; b=T8905p1TigIy+NBiNmHeqAZqWYNb2Awhb4h3Z6VLnIGhud4RjraWsMMGYKCy5XkDQ+ dXLUi5nKr/hb0x6tXuf3O5IyhKThCBnEORCt0GS4heWR/WcFPF17bd+KJ5F9hAm0PfpX Tg7MAtRIsHYwtzNYBB1TTVKNZUSe5ym+o/Jo+K5YAysEGDZrLNXD4FkuVvzl5JSLxin9 ag1RQRiidjngptgrP539OlVwdA2QjTQ5qrJq37GzE3PFXHJzGzle8dZkWix0yf4pcCdZ tNxcn/JT2x1IeQEWi1wpy1AH7hVgttYxa7Yp31GBn6LtxpBoprW1EOn2i0/2lldutown Mf8A== X-Gm-Message-State: ABUngvdXCmrVU9BbuWIxHKOHOdNc+ggP5DktWtrSmR3xX3xffpvOwH+BCVXZLRnJpJ7aPzOZ X-Received: by 10.99.139.196 with SMTP id j187mr3471616pge.115.1477129355534; Sat, 22 Oct 2016 02:42:35 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.92]) by smtp.gmail.com with ESMTPSA id g9sm10923953paw.40.2016.10.22.02.42.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 22 Oct 2016 02:42:35 -0700 (PDT) From: Baoyou Xie To: bskeggs@redhat.com, airlied@linux.ie, acourbot@nvidia.com, imirkin@alum.mit.edu, Julia.Lawall@lip6.fr, martin.peres@free.fr, rspliet@eclipso.eu, nouveau@karolherbst.de Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH 02/17] drm/nouveau/bios: mark symbols static where possible Date: Sat, 22 Oct 2016 17:41:43 +0800 Message-Id: <1477129318-29677-2-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477129318-29677-1-git-send-email-baoyou.xie@linaro.org> References: <1477129318-29677-1-git-send-email-baoyou.xie@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c:29:1: warning: no previous prototype for 'nvbios_fan_table' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c:56:1: warning: no previous prototype for 'nvbios_fan_entry' [-Wmissing-prototypes] In fact, both functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c index 80fed7e..e290581 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c @@ -25,7 +25,7 @@ #include #include -u16 +static u16 nvbios_fan_table(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len) { struct bit_entry bit_P; @@ -52,7 +52,7 @@ nvbios_fan_table(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len) return 0x0000; } -u16 +static u16 nvbios_fan_entry(struct nvkm_bios *bios, int idx, u8 *ver, u8 *hdr, u8 *cnt, u8 *len) {