From patchwork Tue Nov 8 13:16:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 81308 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp1541418qge; Tue, 8 Nov 2016 05:16:23 -0800 (PST) X-Received: by 10.98.31.14 with SMTP id f14mr23263853pff.27.1478610983430; Tue, 08 Nov 2016 05:16:23 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id vq2si12380184pab.236.2016.11.08.05.16.23; Tue, 08 Nov 2016 05:16:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534AbcKHNQN (ORCPT + 27 others); Tue, 8 Nov 2016 08:16:13 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:36452 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbcKHNQK (ORCPT ); Tue, 8 Nov 2016 08:16:10 -0500 Received: by mail-lf0-f43.google.com with SMTP id t196so139373767lff.3 for ; Tue, 08 Nov 2016 05:16:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=HbMsZAiuhP26VtdCAeEiW+zu2yJ1q7/8s0S1v1kxBk4=; b=KIMnP5L0RTmTojcALFbMM5P3kqe0WyKcXqxBuMz5CBOt3iqDD3jdRbLW7DpcTW3R8Q nw6nD7Is0Vao8cYhPzVF1+raVLEFNp8XdTMRJjDiOyMz0yyslZFGFp1stTclr6AlXeId PINuKb0FiBjtb5YdzwhAgLaKQ8Xa86UzcyCQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HbMsZAiuhP26VtdCAeEiW+zu2yJ1q7/8s0S1v1kxBk4=; b=AnC+edNrE1RlAE5v6joJywxnQLILWTQ3XKcO8Yj7miL4ZbRmJAFeCuu8xno/CBLb85 Um4A/zPU4z7SbnAuNWHbHtz+CuCZXmM0901Tum1yNLTq3/wk0Hp7R9AgaAQweUdfAX5g IrIc11tOFg2j4JWi2eYBnaPdEzi0GuJksGXnJg+aFDg6r82mpOLiFDnl1lUWEk69vo71 4W1yegEzUOCxMAEFzpb5rNo3noWkrEzU4WyhK4CxkC0ox8XhHVqqdmREDEiOhVXTZJcI QE0H9iApCWiVc6v5sgL/8JkqDkFCkiinrjhj2+dU3PKkVLMhqEmjIf/bGPcAvpZoeKJ7 HXqQ== X-Gm-Message-State: ABUngveIMztfM7JfDTcjTY6HedTCka5OKQDsVG2E8sdV0Y4xpz265HRunaCw1E7SKy865GRr X-Received: by 10.25.23.101 with SMTP id n98mr7213927lfi.147.1478610968909; Tue, 08 Nov 2016 05:16:08 -0800 (PST) Received: from localhost.localdomain (167-203-94-178.pool.ukrtel.net. [178.94.203.167]) by smtp.gmail.com with ESMTPSA id f42sm5058191lji.43.2016.11.08.05.16.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Nov 2016 05:16:08 -0800 (PST) From: Ivan Khoronzhuk To: mugunthanvnm@ti.com, grygorii.strashko@ti.com, netdev@vger.kernel.org Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Ivan Khoronzhuk Subject: [PATCH] net: ethernet: ti: davinci_cpdma: free memory while channel destroy Date: Tue, 8 Nov 2016 15:16:05 +0200 Message-Id: <1478610965-25288-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While create/destroy channel operation memory is not freed. It was supposed that memory is freed while driver remove. But a channel can be created and destroyed many times while changing number of channels with ethtool. Based on net-next/master Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/davinci_cpdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index 05afc05..07fc92d 100644 --- a/drivers/net/ethernet/ti/davinci_cpdma.c +++ b/drivers/net/ethernet/ti/davinci_cpdma.c @@ -586,7 +586,7 @@ int cpdma_chan_destroy(struct cpdma_chan *chan) cpdma_chan_stop(chan); ctlr->channels[chan->chan_num] = NULL; ctlr->chan_num--; - + devm_kfree(ctlr->dev, chan); cpdma_chan_split_pool(ctlr); spin_unlock_irqrestore(&ctlr->lock, flags);