diff mbox series

[v2,14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode

Message ID 1487325042-28227-15-git-send-email-kishon@ti.com
State New
Headers show
Series [v2,01/22] PCI: endpoint: Add EP core layer to enable EP controller and EP functions | expand

Commit Message

Kishon Vijay Abraham I Feb. 17, 2017, 9:50 a.m. UTC
Update device tree binding documentation of TI's dra7xx PCI
controller to include property for enabling legacy mode.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

---
 Documentation/devicetree/bindings/pci/ti-pci.txt |    4 ++++
 1 file changed, 4 insertions(+)

-- 
1.7.9.5

Comments

Rob Herring (Arm) Feb. 27, 2017, 4:40 p.m. UTC | #1
On Fri, Feb 17, 2017 at 03:20:34PM +0530, Kishon Vijay Abraham I wrote:
> Update device tree binding documentation of TI's dra7xx PCI

> controller to include property for enabling legacy mode.

> 

> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

> ---

>  Documentation/devicetree/bindings/pci/ti-pci.txt |    4 ++++

>  1 file changed, 4 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt

> index 190828a..72ebe2b 100644

> --- a/Documentation/devicetree/bindings/pci/ti-pci.txt

> +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt

> @@ -39,6 +39,10 @@ DEVICE MODE

>   - interrupts : one interrupt entries must be specified for main interrupt.

>   - num-ib-windows : number of inbound address translation windows

>   - num-ob-windows : number of outbound address translation windows

> + - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should

> +		       contain the register offset within syscon and the 2nd

> +		       argument should contain the bit field for setting the

> +		       legacy mode


Vendor prefix needed and what does "legacy mode" mean? Perhaps name this 
around what the mode is/does, not that it is legacy.

Rob
Kishon Vijay Abraham I Feb. 28, 2017, 3:28 a.m. UTC | #2
On Monday 27 February 2017 10:10 PM, Rob Herring wrote:
> On Fri, Feb 17, 2017 at 03:20:34PM +0530, Kishon Vijay Abraham I wrote:

>> Update device tree binding documentation of TI's dra7xx PCI

>> controller to include property for enabling legacy mode.

>>

>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

>> ---

>>  Documentation/devicetree/bindings/pci/ti-pci.txt |    4 ++++

>>  1 file changed, 4 insertions(+)

>>

>> diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt

>> index 190828a..72ebe2b 100644

>> --- a/Documentation/devicetree/bindings/pci/ti-pci.txt

>> +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt

>> @@ -39,6 +39,10 @@ DEVICE MODE

>>   - interrupts : one interrupt entries must be specified for main interrupt.

>>   - num-ib-windows : number of inbound address translation windows

>>   - num-ob-windows : number of outbound address translation windows

>> + - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should

>> +		       contain the register offset within syscon and the 2nd

>> +		       argument should contain the bit field for setting the

>> +		       legacy mode

> 

> Vendor prefix needed and what does "legacy mode" mean? Perhaps name this 

> around what the mode is/does, not that it is legacy.


All right, thanks!

-Kishon
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt
index 190828a..72ebe2b 100644
--- a/Documentation/devicetree/bindings/pci/ti-pci.txt
+++ b/Documentation/devicetree/bindings/pci/ti-pci.txt
@@ -39,6 +39,10 @@  DEVICE MODE
  - interrupts : one interrupt entries must be specified for main interrupt.
  - num-ib-windows : number of inbound address translation windows
  - num-ob-windows : number of outbound address translation windows
+ - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should
+		       contain the register offset within syscon and the 2nd
+		       argument should contain the bit field for setting the
+		       legacy mode
 
 Optional Property:
  - gpios : Should be added if a gpio line is required to drive PERST# line