From patchwork Mon Jun 19 18:31:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Willy Tarreau X-Patchwork-Id: 105913 Delivered-To: patch@linaro.org Received: by 10.140.91.2 with SMTP id y2csp1014734qgd; Mon, 19 Jun 2017 11:51:24 -0700 (PDT) X-Received: by 10.98.156.131 with SMTP id u3mr26819306pfk.16.1497898284781; Mon, 19 Jun 2017 11:51:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497898284; cv=none; d=google.com; s=arc-20160816; b=x3rgKU1w8lzg+y43TcfydfTZR4rZXQ+siBfoRreJ5sE1dAwJP3zTjrzUB18fIUxuhI QSgFqKHEFiOGujWwAkizWGL81IH34Wd9mskysbZucnbxOY+OcCLa1D+xMbDExx051kMv WSZ/nY9VrTpYgEAlS1rCscBZmy8yaAOYyb86mYGn7Kj97DkocZEcyDVWZNwJUJWAHBB9 kwE8FpuBACMbz+mnHTh3A9ywg3nyD07j3xKcRReS+fDS3lzblg/PiRDjYPY0bdJsmcaD eEmJJsqjwkiVng6fU8GL3y8escuDJTlCx5zJIkeJtZpNvAUbYQ9yK7Z633NR0iGObI4a gY8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=88l+asgh/t6q1fFngU9FVZH7zDpeNk0KKUGUDoLoIxQ=; b=U90pOxYnXMQKg4Nl+NQsiAQprnnoznthmpiPORQowVmgmilJ40LkoZWIwbr+1kwfoS qD1+cq3lDwvArCEom6/8OY/bGmOQ6S92hNU8EhyuycKfRLIM1uEkdj9TmxXxAVCJtbdq CcYqt1XeH3LwXnJM/aagxNpzrdcKJejj5AEFWn1H6v+m68QFa5oSzD79u1cLObc5m93A v0HUA6PNZa/E4jSIYuNXrAgQJZs0oyMY3r9q1hnvDckIdEKVK4Q7OYNE+FDK67uP8rN9 E4oTpG1ZzgFROuLj2ITFFBCuDvbNxUVbhIHHkBsNn9ruWaqUDxFSp4jmNn8NkkgNWamg 5qjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l185si8715397pgd.570.2017.06.19.11.51.24; Mon, 19 Jun 2017 11:51:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbdFSSuy (ORCPT + 25 others); Mon, 19 Jun 2017 14:50:54 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:52681 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753985AbdFSSiu (ORCPT ); Mon, 19 Jun 2017 14:38:50 -0400 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id v5JIXg7S015042; Mon, 19 Jun 2017 20:33:42 +0200 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux@roeck-us.net Cc: Arnd Bergmann , "David S . Miller" , Willy Tarreau Subject: [PATCH 3.10 176/268] cpmac: remove hopeless #warning Date: Mon, 19 Jun 2017 20:31:15 +0200 Message-Id: <1497897167-14556-177-git-send-email-w@1wt.eu> X-Mailer: git-send-email 2.8.0.rc2.1.gbe9624a In-Reply-To: <1497897167-14556-1-git-send-email-w@1wt.eu> References: <1497897167-14556-1-git-send-email-w@1wt.eu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann commit d43e6fb4ac4abfe4ef7c102833ed02330ad701e0 upstream. The #warning was present 10 years ago when the driver first got merged. As the platform is rather obsolete by now, it seems very unlikely that the warning will cause anyone to fix the code properly. kernelci.org reports the warning for every build in the meantime, so I think it's better to just turn it into a code comment to reduce noise. Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller Signed-off-by: Willy Tarreau --- drivers/net/ethernet/ti/cpmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.8.0.rc2.1.gbe9624a diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c index 6bcb2b8..922f7dd 100644 --- a/drivers/net/ethernet/ti/cpmac.c +++ b/drivers/net/ethernet/ti/cpmac.c @@ -1242,7 +1242,7 @@ int cpmac_init(void) goto fail_alloc; } -#warning FIXME: unhardcode gpio&reset bits + /* FIXME: unhardcode gpio&reset bits */ ar7_gpio_disable(26); ar7_gpio_disable(27); ar7_device_reset(AR7_RESET_BIT_CPMAC_LO);