From patchwork Tue Jul 4 17:34:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Bellasi X-Patchwork-Id: 107006 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp1251182qge; Tue, 4 Jul 2017 10:34:52 -0700 (PDT) X-Received: by 10.84.172.1 with SMTP id m1mr17407435plb.174.1499189692740; Tue, 04 Jul 2017 10:34:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499189692; cv=none; d=google.com; s=arc-20160816; b=rY1M4IpBFpe4p9m2IllxmvtsYDsxCDFlxysa3q9QDBNlVaQFnJjA/D23QK3wxF+Rby yhGaImCVEiMwgyEFXto1lzIr4youDoFdPN3oQSXLBRGTCjIijHBvP9R7h2w8JlpqIM+C JWiwlUeJw+lA3cRFZTlDxLyCRODz+sS1WO3yCYOuSnYCaAVqSszYM9DL3EW8brEcph5P yqKtORxsrmvsXvQUev+U35/bZG1WQBSsv8T7oiJTWg7ucFV7olk+pjqcQgxiYu7T4En9 tp82CSOQVxx2prgBBNAOqKRQVnIDHF7pAIm/v73RjroSOZbLBcOWNaGgC1N4Uexubkg2 9oCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=vSzBFHQFrPsGsWM4Zsdeb2+F2qN5pULJnXfO/x8dnXg=; b=G9Yac7DyTifDvQLjFcxyP6lw2IdUEK1unkvJFBnAmNBXaCmoYDAO24lx9mwkRTWd6E pmmh17JFvXEOW0SUs0zlnqN8Gc+U1bVMD9c3/Mkqf/KqSdZdmygWWpYjB8HNxcbsWg1w 57jO6v3kIxgz84OuBVqqzwxhzqMiS15FNLq8KgaTDjZWBYm7AxNMsLT8nS3X1DzJBaJF /QCEtDxcF7LrEaQo967TecY1arqntn15MQRQ+jUkeCc+JC8QYr8ji76urm7dXercGljo AOzg/y/7cBV5S0/jLOUJR/cUGtyuCnY4fxJ+gomkyH+Hz43I5XaiAFoQ3jHgyWa6MGZd 8bgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1si16073408plj.439.2017.07.04.10.34.52; Tue, 04 Jul 2017 10:34:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbdGDRel (ORCPT + 25 others); Tue, 4 Jul 2017 13:34:41 -0400 Received: from foss.arm.com ([217.140.101.70]:48108 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752256AbdGDRei (ORCPT ); Tue, 4 Jul 2017 13:34:38 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 923D31596; Tue, 4 Jul 2017 10:34:27 -0700 (PDT) Received: from e110439-lin.cambridge.arm.com (e110439-lin.cambridge.arm.com [10.1.210.68]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 72D333F41F; Tue, 4 Jul 2017 10:34:25 -0700 (PDT) From: Patrick Bellasi To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , "Rafael J . Wysocki" , Viresh Kumar , Vincent Guittot , Juri Lelli , Joel Fernandes , Andres Oportus , Todd Kjos , Morten Rasmussen , Dietmar Eggemann Subject: [PATCH v2 2/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter Date: Tue, 4 Jul 2017 18:34:07 +0100 Message-Id: <1499189651-18797-3-git-send-email-patrick.bellasi@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499189651-18797-1-git-send-email-patrick.bellasi@arm.com> References: <1499189651-18797-1-git-send-email-patrick.bellasi@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, sg_cpu's flags are set to the value defined by the last call of the cpufreq_update_util()/cpufreq_update_this_cpu(); for RT/DL classes this corresponds to the SCHED_CPUFREQ_{RT/DL} flags always being set. When multiple CPU shares the same frequency domain it might happen that a CPU which executed a RT task, right before entering IDLE, has one of the SCHED_CPUFREQ_RT_DL flags set, permanently, until it exits IDLE. Although such an idle CPU is _going to be_ ignored by the sugov_next_freq_shared(): 1. this kind of "useless RT requests" are ignored only if more then TICK_NSEC have elapsed since the last update 2. we can still potentially trigger an already too late switch to MAX, which starts also a new throttling interval 3. the internal state machine is not consistent with what the scheduler knows, i.e. the CPU is now actually idle Thus, in sugov_next_freq_shared(), where utilisation and flags are aggregated across all the CPUs of a frequency domain, it can turn out that all the CPUs of that domain can run unnecessary at the maximum OPP until another event happens in the idle CPU, which eventually clear the SCHED_CPUFREQ_{RT/DL} flag, or the IDLE CPUs gets ignored after TICK_NSEC since the CPU entering IDLE. Such a behaviour can harm the energy efficiency of systems where RT workloads are not so frequent and other CPUs in the same frequency domain are running small utilisation workloads, which is a quite common scenario in mobile embedded systems. This patch proposes a solution which is aligned with the current principle to update the flags each time a scheduling event happens. The scheduling of the idle_task on a CPU is considered one of such meaningful events. That's why when the idle_task is selected for execution we poke the schedutil policy to reset the flags for that CPU. No frequency transitions are activated at that point, which is fair in case the RT workload should come back in the future. However, this still allows other CPUs in the same frequency domain to scale down the frequency in case that should be possible. Signed-off-by: Patrick Bellasi Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Rafael J. Wysocki Cc: Viresh Kumar Cc: linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org --- Changes from v1: - added "unlikely()" around the statement (SteveR) --- include/linux/sched/cpufreq.h | 1 + kernel/sched/cpufreq_schedutil.c | 7 +++++++ kernel/sched/idle_task.c | 4 ++++ 3 files changed, 12 insertions(+) -- 2.7.4 diff --git a/include/linux/sched/cpufreq.h b/include/linux/sched/cpufreq.h index d2be2cc..36ac8d2 100644 --- a/include/linux/sched/cpufreq.h +++ b/include/linux/sched/cpufreq.h @@ -10,6 +10,7 @@ #define SCHED_CPUFREQ_RT (1U << 0) #define SCHED_CPUFREQ_DL (1U << 1) #define SCHED_CPUFREQ_IOWAIT (1U << 2) +#define SCHED_CPUFREQ_IDLE (1U << 3) #define SCHED_CPUFREQ_RT_DL (SCHED_CPUFREQ_RT | SCHED_CPUFREQ_DL) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index eaba6d6..004ae18 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -304,6 +304,12 @@ static void sugov_update_shared(struct update_util_data *hook, u64 time, sg_cpu->util = util; sg_cpu->max = max; + + /* CPU is entering IDLE, reset flags without triggering an update */ + if (unlikely(flags & SCHED_CPUFREQ_IDLE)) { + sg_cpu->flags = 0; + goto done; + } sg_cpu->flags = flags; sugov_set_iowait_boost(sg_cpu, time, flags); @@ -318,6 +324,7 @@ static void sugov_update_shared(struct update_util_data *hook, u64 time, sugov_update_commit(sg_policy, time, next_f); } +done: raw_spin_unlock(&sg_policy->update_lock); } diff --git a/kernel/sched/idle_task.c b/kernel/sched/idle_task.c index 0c00172..a844c91 100644 --- a/kernel/sched/idle_task.c +++ b/kernel/sched/idle_task.c @@ -29,6 +29,10 @@ pick_next_task_idle(struct rq *rq, struct task_struct *prev, struct rq_flags *rf put_prev_task(rq, prev); update_idle_core(rq); schedstat_inc(rq->sched_goidle); + + /* kick cpufreq (see the comment in kernel/sched/sched.h). */ + cpufreq_update_this_cpu(rq, SCHED_CPUFREQ_IDLE); + return rq->idle; }