From patchwork Sat Oct 28 16:50:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 117396 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp764239qgn; Sat, 28 Oct 2017 09:51:04 -0700 (PDT) X-Google-Smtp-Source: ABhQp+Qlm/ZEFLTeRUbm9Lrlmksdw8Nd0+uWuiLiBZyLzmuvaAbFsS0XlLs2cSPQAlFaPnLzC55t X-Received: by 10.101.75.201 with SMTP id p9mr3397304pgr.324.1509209464623; Sat, 28 Oct 2017 09:51:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509209464; cv=none; d=google.com; s=arc-20160816; b=olSraPdhVMtF0Z9XDxPEsPv5+khsKM1F5bZ6Lp/OSljgt7Ee4QIDkJ+1QA0B37ynxQ MRPr1+58AV1XKjjhN7djJNV1jNWMrkgZj/Hs0fvIAjlAIJxMnNQv1fmVGaekrhkpk+84 e95pz9ReNzwehQ/C4guGTm7kcwyUb5l2oVNUExrgAgNC4tsjabfBQOldU/5tcZoiS0hE nCW27Y5qgdCyLejeRQDLu09hfYlU8LO7Nfz/bfWOU2CS8X/HQSIrTSX3wMwm82wgPMPG Yt+IhGK0/zzxeDj+62LPGNDRhNchOuWksZnLbmmNkF4YmxrMMI46YKhktpHKS8y8FGBu aLCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=v5LJIRf+RZ9DaApNZ9lIY1o3ErLTG/XDXoa0/WaIMvU=; b=ML9R5zG3LYudhkl4C9Co1EbbSt5FAQyjJ9pdwQFj4dhaQl/poCWuAQQ4eR0mv9cIRa If4zT6otwyPul6ykk2UQZlTwFiOht9/tAic3ZjsHqXa9E7SC6h7z5BaMyPYZo3l19JqY oPsyn/HBZEStrBxNTs1AobR6K51GEpDrtbncHK3weYQ7mXQxd8PFCR5ImD3YWhWqyjXB 4yq8CAh66z1/1qqKDzssXyLBb9rv9goBw8JDrRFpLfmV7A9Ovw7QL0G8DoQXGF84XCze cew5J3KKAz52qioGsWhiKZ1EVXFDMvPuXmCVVjIO2MWmxfPHn0a7PtrPKRlcAHz8+T/Z +H8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=kUjO1wGI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 204si1410018pgc.742.2017.10.28.09.51.04; Sat, 28 Oct 2017 09:51:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=kUjO1wGI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751483AbdJ1QvC (ORCPT + 27 others); Sat, 28 Oct 2017 12:51:02 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:39210 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbdJ1QvB (ORCPT ); Sat, 28 Oct 2017 12:51:01 -0400 Received: from grover.sesame (FL1-122-131-185-176.osk.mesh.ad.jp [122.131.185.176]) (authenticated) by conuserg-12.nifty.com with ESMTP id v9SGoDXG021928; Sun, 29 Oct 2017 01:50:14 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com v9SGoDXG021928 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1509209414; bh=v5LJIRf+RZ9DaApNZ9lIY1o3ErLTG/XDXoa0/WaIMvU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kUjO1wGIHRl1oGK1t8GlWVFqZbRrBIOnEWcNlfHmU3FfRrzgPGNJKub6bQIKRkh5o KG2gSlGz8wW7kJ9PWku5HUczeuN6kKSXt8wQ/03diB+vG83f9crqQXfQymM5XpO1e0 H8q3F8svurY/4RAovurmP/5SKn/TLyL5PS4sbSzkYM+PefV2Gh4Sgd08oEz5ZwH7RV BqKbv9SQuFW8ezJ992ZYzm9FSfPvzN63bcZ1r5vD2eJot7O9x/InIo6RsXaAKHi3MA /uH1rGvlPxKnmoNt9YEsFObuqe07UkuTQ79NGcUNnjZovvaJiUV4ubhE2lc9wK6rYV fl7vlxrYitoGw== X-Nifty-SrcIP: [122.131.185.176] From: Masahiro Yamada To: Philipp Zabel Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] reset: remove remaining WARN_ON() in Date: Sun, 29 Oct 2017 01:50:07 +0900 Message-Id: <1509209409-2698-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1509209409-2698-1-git-send-email-yamada.masahiro@socionext.com> References: <1509209409-2698-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit bb475230b8e5 ("reset: make optional functions really optional") gave a new meaning to _get_optional variants. The differentiation by WARN_ON() is not needed any more. We already have inconsistency about this; (devm_)reset_control_get_exclusive() has WARN_ON() check, but of_reset_control_get_exclusive() does not. Signed-off-by: Masahiro Yamada --- include/linux/reset.h | 6 ------ 1 file changed, 6 deletions(-) -- 2.7.4 diff --git a/include/linux/reset.h b/include/linux/reset.h index c2fe7b6..9329664 100644 --- a/include/linux/reset.h +++ b/include/linux/reset.h @@ -124,9 +124,6 @@ static inline int device_reset_optional(struct device *dev) static inline struct reset_control * __must_check reset_control_get_exclusive(struct device *dev, const char *id) { -#ifndef CONFIG_RESET_CONTROLLER - WARN_ON(1); -#endif return __reset_control_get(dev, id, 0, false, false); } @@ -272,9 +269,6 @@ static inline struct reset_control * __must_check devm_reset_control_get_exclusive(struct device *dev, const char *id) { -#ifndef CONFIG_RESET_CONTROLLER - WARN_ON(1); -#endif return __devm_reset_control_get(dev, id, 0, false, false); }