From patchwork Thu Nov 9 15:41:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 118457 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp6747415qgn; Thu, 9 Nov 2017 07:43:28 -0800 (PST) X-Google-Smtp-Source: ABhQp+S/DPDtEwh9zOU1cdpvjuQolm1+Jv15LvLuuD5ICW9Y1dnvc2DWbnwQieM1R6p7NqINDhpZ X-Received: by 10.98.220.220 with SMTP id c89mr866320pfl.167.1510242208100; Thu, 09 Nov 2017 07:43:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510242208; cv=none; d=google.com; s=arc-20160816; b=gCE6cvq7m376EPPoUO2bhuL5wiaz6UV305cYtdutd1Qaf84wZXhuSSQIVoN405b8kM Hc8GBRMrF0hnTZ8XKAsFfbyH7XgIDLf3wH3DO26AIdpx+KBwudYvb/AQRVZEucJ+xgma 1RAbU8p5ea73NOtlLFUqc/9sogHbGd2f3v2jRhBHyYafL2emmVDcLKNt0iFDu++fMggj R1p6YoAKc8KnfgyQ+6LDzFzymy7XbkP0h+cw7lXHZ3skyC+L3uxeAP8YQrQov19bYbYm cZNSvrIHK6xvAm6uI2OtW2Sx4Xo2H3OVfj9/aQm+diufvU++x7v/zk5QMYzEgITQ7oFR lVWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=b1q8dwhyyqPlTOGywEzPG+Lsu7ungNwOpVxQYxgT/6M=; b=bhTPoj1B24+XSL2wrewE8r2gsgFJutVpZRPeleKS3QdDyD1lhwg3WfT1PDlx+HCGsx Ko7pP42mUstXt/NH3GYu1ze3gCSn7Z02NDTKlCoJXqyRVEi0wGj1GjslyRhiHaSYFuT5 cih8E4Z5601Nz2A7dvhJDLUTXbzIcvl4I4GJWCxgcA2E9zqJ0E0URudXxpIymr/Wuii+ T+9WDE/8v+tDnWJHpgsRnOT69LrBchKA85d5dAySBmoyToODzrBzFeqkrNePuK1eHvK2 9D68TC6HmwtRW6YGs4n4Je1SJMz858olaDFBduLUS4SM7aQmvWNPpuICieIUYBMBX1mU fdpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Up4kDia6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si6578313plz.759.2017.11.09.07.43.27; Thu, 09 Nov 2017 07:43:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Up4kDia6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752889AbdKIPn0 (ORCPT + 22 others); Thu, 9 Nov 2017 10:43:26 -0500 Received: from conuserg-11.nifty.com ([210.131.2.78]:23929 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdKIPm5 (ORCPT ); Thu, 9 Nov 2017 10:42:57 -0500 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-11.nifty.com with ESMTP id vA9FfQvC007776; Fri, 10 Nov 2017 00:41:28 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com vA9FfQvC007776 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1510242088; bh=b1q8dwhyyqPlTOGywEzPG+Lsu7ungNwOpVxQYxgT/6M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Up4kDia69FY43vDU+19fNymKfLwVAJes3QLPIzFrTD5O2NRpBw/gcAi/i6+mx6a4j 8AAZyJzWFaQw8L6zIcvPtpkpiBGWaZtPjBUi9OkVbP1QsQyHgENLB5sAEviZPv0hgo 2fqCtC8Vwttps9Rbw7Zw0Et2aJ912YpNeGf7ay6Kn/3Uq3AjfJSN0LgpoQl1atu3Qy D9PP5MeviNbI98oH1vevk/Abb1VoYqE4JjCMXPrJrV3YzyTrM/sUbb5eHtWc+N17Rv g1M+zYZr1jTwRt1rWfqKvpMT0ljuMYNVnpsUTCJVNUvrTxNzMc2JvthWuMJWegHj/b 9EIMfEYl2SkBQ== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Michal Marek , Sam Ravnborg , Douglas Anderson , Masahiro Yamada , Michal Marek Subject: [PATCH 2/4] kbuild: remove redundant $(wildcard ...) for cmd_files calculation Date: Fri, 10 Nov 2017 00:41:15 +0900 Message-Id: <1510242077-8122-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510242077-8122-1-git-send-email-yamada.masahiro@socionext.com> References: <1510242077-8122-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I do not why $(wildcard ...) needs to be called twice for computing cmd_files. Remove the first one. Signed-off-by: Masahiro Yamada --- Makefile | 3 +-- scripts/Makefile.build | 3 +-- scripts/Makefile.headersinst | 3 +-- scripts/Makefile.modpost | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) -- 2.7.4 diff --git a/Makefile b/Makefile index a7476e6..58dd245 100644 --- a/Makefile +++ b/Makefile @@ -1693,8 +1693,7 @@ cmd_crmodverdir = $(Q)mkdir -p $(MODVERDIR) \ # read all saved command lines -targets := $(wildcard $(sort $(targets))) -cmd_files := $(wildcard .*.cmd $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd)) +cmd_files := $(wildcard .*.cmd $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd)) ifneq ($(cmd_files),) $(cmd_files): ; # Do not try to update included dependency files diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 061d0c3..62d5314 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -583,8 +583,7 @@ FORCE: # optimization, we don't need to read them if the target does not # exist, we will rebuild anyway in that case. -targets := $(wildcard $(sort $(targets))) -cmd_files := $(wildcard $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd)) +cmd_files := $(wildcard $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd)) ifneq ($(cmd_files),) include $(cmd_files) diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst index 5692d7a..2aa9181 100644 --- a/scripts/Makefile.headersinst +++ b/scripts/Makefile.headersinst @@ -114,9 +114,8 @@ $(check-file): scripts/headers_check.pl $(output-files) FORCE endif -targets := $(wildcard $(sort $(targets))) cmd_files := $(wildcard \ - $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd)) + $(foreach f,$(sort $$(targets)),$(dir $(f)).$(notdir $(f)).cmd)) ifneq ($(cmd_files),) include $(cmd_files) diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost index 16923ba..cf125c1 100644 --- a/scripts/Makefile.modpost +++ b/scripts/Makefile.modpost @@ -143,8 +143,7 @@ FORCE: # optimization, we don't need to read them if the target does not # exist, we will rebuild anyway in that case. -targets := $(wildcard $(sort $(targets))) -cmd_files := $(wildcard $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd)) +cmd_files := $(wildcard $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd)) ifneq ($(cmd_files),) include $(cmd_files)