From patchwork Mon Nov 13 10:29:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 118724 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp1626070qgn; Mon, 13 Nov 2017 02:32:22 -0800 (PST) X-Google-Smtp-Source: AGs4zMYo5gZLUNJ7ZlykFiqS8BhwVfwk1uff1HExZ/LufGyK7G2YPK1gpOsB6V1iO/n1V8rKNAx1 X-Received: by 10.84.138.131 with SMTP id 3mr8407580plp.238.1510569142022; Mon, 13 Nov 2017 02:32:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510569142; cv=none; d=google.com; s=arc-20160816; b=BxrZoPWn81Xf5gLe/Qnda2d6+BRBT+F6SDz4LDvksXFfLr3ZMB3MLwXHNQt8R68oHT 11B9BRwIM40oZnZRxz9NEsPSGenHxGmnGO/zqSbRMxXh6iI4GXMbtKw/cPnRbv1Tq1FY L9QEB0VUT9w8bi/lqUXgtlI3Yoj+A35RHzBtD8acNPiXQnVYNzsZ7+la36wBnRpvTvR4 +R84SLOyoZLevonUvNWWFMBRoaPGMaq+Zkq84SE+1ZZp1rpcrU5ibYuibfET1Ejdw7HT 4pt1ayXg6jFrjTDs0+R/qik0TXcfB+hg7z/2o19pwYjBd0teE87QN3gsLiVLHZXztAHd mKug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=lIsx0+MDS+hIQ3mjpLrdgftu/jmK0OMZHEsWKEyuAVI=; b=Awj6YQ2tCIzXMatl+G7JeC8j7p7Icm7xW9iIsxLmJBHM9gstFMCI91qzMdlXnwQEZx OsFT4yM89GGHLEa3SDxv5XAoLVUNvtZc0p/bv6I7yVx0qfA1yUEejUohHl3vNS3OREfB JJBoZQb5thOFhvRdVt2aDCQIsmB0eQBSrOJnXHiN5avvlpAVuXstTKH2e6yCp2n9+WU8 mbZO418MzpFy1TLov11RL7xVIDk/2mfKtppI5yF7wA3rJ9JCOqJQVVk0gQk5ISy+zlEI Au44t/qFWNIchjOKqJNlewyQYZbMMT6AxrrIFyy6NqIjT41qEot0Gg/k021PgI0mW1fS I3Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Uqj77aNP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d18si2322432pls.617.2017.11.13.02.32.21; Mon, 13 Nov 2017 02:32:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Uqj77aNP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbdKMKbl (ORCPT + 27 others); Mon, 13 Nov 2017 05:31:41 -0500 Received: from conuserg-07.nifty.com ([210.131.2.74]:40662 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752334AbdKMKbg (ORCPT ); Mon, 13 Nov 2017 05:31:36 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id vADATvx3031253; Mon, 13 Nov 2017 19:29:59 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com vADATvx3031253 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1510569000; bh=lIsx0+MDS+hIQ3mjpLrdgftu/jmK0OMZHEsWKEyuAVI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uqj77aNP+M8A3vjXZHFVpoaLzcQc7WCciYg0FAdHNcB10oP5ALZRKd81f8LzaT+Mt 51baKX50T4x22fBEBejsD98baJi0CDESi95BpiIDEklp2CROl138E5GaXj6sjjhzBU XP68Ok3omF0I2NNQO8wvRSMtYDPqW16YeHNoEVZ4SWQEbPCHnHE2xFqISsWmpXKZlA I8QM+WZosxn5unOiA4o2KIv9dfbMIiiFD9MulxRrdr6/hyUloWIlZUXIpUHheKlQJX +3mOrdZWD1v/4u3QwfOG5opoXyLi+FFdf3VD04fUezhF1V1lLNMI9UIyBMRU0jW88N 168chu9WsvUKQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Douglas Anderson , Sam Ravnborg , Michal Marek , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/6] kbuild: remove redundant $(wildcard ...) for cmd_files calculation Date: Mon, 13 Nov 2017 19:29:35 +0900 Message-Id: <1510568979-24440-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510568979-24440-1-git-send-email-yamada.masahiro@socionext.com> References: <1510568979-24440-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I do not see any reason why $(wildcard ...) needs to be called twice for computing cmd_files. Remove the first one. Signed-off-by: Masahiro Yamada --- Changes in v2: - Fix "$$" in scripts/Makefile.headersinst per Douglas Makefile | 3 +-- scripts/Makefile.build | 3 +-- scripts/Makefile.headersinst | 3 +-- scripts/Makefile.modpost | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) -- 2.7.4 diff --git a/Makefile b/Makefile index a7476e6..58dd245 100644 --- a/Makefile +++ b/Makefile @@ -1693,8 +1693,7 @@ cmd_crmodverdir = $(Q)mkdir -p $(MODVERDIR) \ # read all saved command lines -targets := $(wildcard $(sort $(targets))) -cmd_files := $(wildcard .*.cmd $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd)) +cmd_files := $(wildcard .*.cmd $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd)) ifneq ($(cmd_files),) $(cmd_files): ; # Do not try to update included dependency files diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 061d0c3..62d5314 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -583,8 +583,7 @@ FORCE: # optimization, we don't need to read them if the target does not # exist, we will rebuild anyway in that case. -targets := $(wildcard $(sort $(targets))) -cmd_files := $(wildcard $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd)) +cmd_files := $(wildcard $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd)) ifneq ($(cmd_files),) include $(cmd_files) diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst index 5692d7a..c6fb2b7 100644 --- a/scripts/Makefile.headersinst +++ b/scripts/Makefile.headersinst @@ -114,9 +114,8 @@ $(check-file): scripts/headers_check.pl $(output-files) FORCE endif -targets := $(wildcard $(sort $(targets))) cmd_files := $(wildcard \ - $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd)) + $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd)) ifneq ($(cmd_files),) include $(cmd_files) diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost index 16923ba..cf125c1 100644 --- a/scripts/Makefile.modpost +++ b/scripts/Makefile.modpost @@ -143,8 +143,7 @@ FORCE: # optimization, we don't need to read them if the target does not # exist, we will rebuild anyway in that case. -targets := $(wildcard $(sort $(targets))) -cmd_files := $(wildcard $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd)) +cmd_files := $(wildcard $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd)) ifneq ($(cmd_files),) include $(cmd_files)