diff mbox series

[4/6] kconfig: remove unneeded input_mode test in conf()

Message ID 1515567374-12722-4-git-send-email-yamada.masahiro@socionext.com
State Superseded
Headers show
Series [1/6] kconfig: do not call check_conf() for olddefconfig | expand

Commit Message

Masahiro Yamada Jan. 10, 2018, 6:56 a.m. UTC 
conf() is never called for listnewconfig / olddefconfig.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 scripts/kconfig/conf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
2.7.4

Comments

Ulf Magnusson Jan. 12, 2018, 2:38 p.m. UTC | #1 
On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> conf() is never called for listnewconfig / olddefconfig.

>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> ---

>

>  scripts/kconfig/conf.c | 4 +---

>  1 file changed, 1 insertion(+), 3 deletions(-)

>

> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c

> index 8364811..693cd5f 100644

> --- a/scripts/kconfig/conf.c

> +++ b/scripts/kconfig/conf.c

> @@ -368,9 +368,7 @@ static void conf(struct menu *menu)

>

>                 switch (prop->type) {

>                 case P_MENU:

> -                       if ((input_mode == silentoldconfig ||

> -                            input_mode == listnewconfig ||

> -                            input_mode == olddefconfig) &&

> +                       if (input_mode == silentoldconfig &&

>                             rootEntry != menu) {

>                                 check_conf(menu);

>                                 return;

> --

> 2.7.4

>


LGTM

Acked-by: Ulf Magnusson <ulfalizer@gmail.com>


Cheers,
Ulf
diff mbox series

Patch

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 8364811..693cd5f 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -368,9 +368,7 @@  static void conf(struct menu *menu)
 
 		switch (prop->type) {
 		case P_MENU:
-			if ((input_mode == silentoldconfig ||
-			     input_mode == listnewconfig ||
-			     input_mode == olddefconfig) &&
+			if (input_mode == silentoldconfig &&
 			    rootEntry != menu) {
 				check_conf(menu);
 				return;