From patchwork Tue Feb 6 00:34:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 126937 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp2442048ljc; Mon, 5 Feb 2018 16:40:12 -0800 (PST) X-Google-Smtp-Source: AH8x225zSjN5E0u9o17LjZhd7OC5b3HHlnaHREuBagwy1PCFE4lWZs1FELxPj7vDoLcQUIv18RaM X-Received: by 2002:a17:902:15a8:: with SMTP id m37-v6mr612249pla.186.1517877612306; Mon, 05 Feb 2018 16:40:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517877612; cv=none; d=google.com; s=arc-20160816; b=KxMjtNsXEoZXSclX85CRn16/hmPy80P1ZMbvTiuT2Ed0pm9BZwGulKjD6wokleGjzs nNJWj2n1brm3gfvWglc9qSAy5O2O18XfgZzhaIqGd+s/9yL6Q3qdbSsYihkHtGDs1uUD S2mgcSj16C+XXBPNSSzNz0KcNjLPdZWDi9464UPC+vrApT5P/gCF35GZJp1CQRgDiuA5 7Wb5Ot1GAq+VnFobzbAjkPJfgm37WLk8Mk0WPdu+p53u5xVIgRb10pntK9qR5fPbpNm/ qysevIPb/1AKnih7Q3x5L90dDwcW1/gsfSd9JcI08kc8oYkXW8uwD300WrL7X4IhMHbI UxOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=T9u7K+hmWKfvjcjjYHb1paogJ/PbBcbc8jyZmrvK6GA=; b=x16jV2/jSnOOLzdzWeJCULHTDTQdlPoMaxougHpDFnNi3H/RH4LdOkHKhtbfYoDvbY VTPo0T4/E6u5vBKl68jGU2leOZde6WIaMlrloJk2LpLKX5LZx+OK5SfcSX4yLuqmG4ff vMqzfpP82QQgnfhibRrjeotlURCg/z4ByjZZ5e2uFLKVxSWEQ5/wUyIllMSGtOwajxPD NLeDy6BMgN2HNKwf9TmhSvKZrcU6D8AyyCV+wGRZ1N3lY6CCudU0MS4Ew3muUeRzkgTn OXse630MeCsMq+uVs8PDEM1hhRR4NAInG6/DW1g1STNDH+jjiFxXV0+R5aprcmKL8Fe7 lMxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=rjWn4lBQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x63si709625pfk.335.2018.02.05.16.40.11; Mon, 05 Feb 2018 16:40:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=rjWn4lBQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbeBFAkJ (ORCPT + 21 others); Mon, 5 Feb 2018 19:40:09 -0500 Received: from conuserg-07.nifty.com ([210.131.2.74]:39929 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752327AbeBFAiA (ORCPT ); Mon, 5 Feb 2018 19:38:00 -0500 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-07.nifty.com with ESMTP id w160ZHAg011351; Tue, 6 Feb 2018 09:35:18 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com w160ZHAg011351 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1517877319; bh=T9u7K+hmWKfvjcjjYHb1paogJ/PbBcbc8jyZmrvK6GA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rjWn4lBQynyejp41BRZzCosw5lK6nw+ggwckAvLnUBPIdrrnGj6NI/0Ml0yxTDLpX k34Hnhx65dB2Rnq8Sr4hHizuwhGaui2DmlNx5atuo5KDrDMDcGw+HXSN0IJYKGtZn8 EDCPEWzl85IKbgnOdoRPX/k9EJIXHmnizGuMub4OGQDJk9ceoUG1L5NubcHsMb694U hZclVceRrAg3dLAsqy+vVP6Y89GoIj7AC9hRAtyv9gjVBbUth5eymlZ9Kdpv2V8O8u r8b1f5zQMiRZXBECjazynvuRWrEMjkIbHMaub6VwZ1sCLrhk1JBv3SWz3R9j1NJgwE 0T6WqLMLNuxvw== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Greg Kroah-Hartman , Andrew Morton , Nicolas Pitre , "Luis R . Rodriguez" , Randy Dunlap , Ulf Magnusson , Sam Ravnborg , Michal Marek , Linus Torvalds , Masahiro Yamada , linux-kernel@vger.kernel.org, Marc Herbert Subject: [PATCH 01/14] kconfig: send error messages to stderr Date: Tue, 6 Feb 2018 09:34:41 +0900 Message-Id: <1517877294-4826-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517877294-4826-1-git-send-email-yamada.masahiro@socionext.com> References: <1517877294-4826-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These messages should be directed to stderr. Signed-off-by: Masahiro Yamada --- scripts/kconfig/conf.c | 18 +++++++++++------- scripts/kconfig/zconf.l | 27 +++++++++++++++------------ 2 files changed, 26 insertions(+), 19 deletions(-) -- 2.7.4 Reviewed-by: Ulf Magnusson diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index 307bc3f..90a76aa2 100644 --- a/scripts/kconfig/conf.c +++ b/scripts/kconfig/conf.c @@ -75,9 +75,11 @@ static void strip(char *str) static void check_stdin(void) { if (!valid_stdin) { - printf(_("aborted!\n\n")); - printf(_("Console input/output is redirected. ")); - printf(_("Run 'make oldconfig' to update configuration.\n\n")); + fprintf(stderr, + _("Aborted!\n" + "Console input/output is redirected.\n" + "Run 'make oldconfig' to update configuration.\n\n") + ); exit(1); } } @@ -565,7 +567,7 @@ int main(int ac, char **av) } } if (ac == optind) { - printf(_("%s: Kconfig file missing\n"), av[0]); + fprintf(stderr, _("%s: Kconfig file missing\n"), av[0]); conf_usage(progname); exit(1); } @@ -590,9 +592,11 @@ int main(int ac, char **av) if (!defconfig_file) defconfig_file = conf_get_default_confname(); if (conf_read(defconfig_file)) { - printf(_("***\n" - "*** Can't find default configuration \"%s\"!\n" - "***\n"), defconfig_file); + fprintf(stderr, + _("***\n" + "*** Can't find default configuration \"%s\"!\n" + "***\n"), + defconfig_file); exit(1); } break; diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l index 07e074d..0ba4900 100644 --- a/scripts/kconfig/zconf.l +++ b/scripts/kconfig/zconf.l @@ -184,7 +184,9 @@ n [A-Za-z0-9_-] append_string(yytext, 1); } \n { - printf("%s:%d:warning: multi-line strings not supported\n", zconf_curname(), zconf_lineno()); + fprintf(stderr, + "%s:%d:warning: multi-line strings not supported\n", + zconf_curname(), zconf_lineno()); current_file->lineno++; BEGIN(INITIAL); return T_EOL; @@ -294,7 +296,7 @@ void zconf_initscan(const char *name) { yyin = zconf_fopen(name); if (!yyin) { - printf("can't find file %s\n", name); + fprintf(stderr, "can't find file %s\n", name); exit(1); } @@ -315,8 +317,8 @@ void zconf_nextfile(const char *name) current_buf->state = YY_CURRENT_BUFFER; yyin = zconf_fopen(file->name); if (!yyin) { - printf("%s:%d: can't open file \"%s\"\n", - zconf_curname(), zconf_lineno(), file->name); + fprintf(stderr, "%s:%d: can't open file \"%s\"\n", + zconf_curname(), zconf_lineno(), file->name); exit(1); } yy_switch_to_buffer(yy_create_buffer(yyin, YY_BUF_SIZE)); @@ -325,20 +327,21 @@ void zconf_nextfile(const char *name) for (iter = current_file->parent; iter; iter = iter->parent ) { if (!strcmp(current_file->name,iter->name) ) { - printf("%s:%d: recursive inclusion detected. " - "Inclusion path:\n current file : '%s'\n", - zconf_curname(), zconf_lineno(), - zconf_curname()); + fprintf(stderr, + "%s:%d: recursive inclusion detected. " + "Inclusion path:\n current file : '%s'\n", + zconf_curname(), zconf_lineno(), + zconf_curname()); iter = current_file->parent; while (iter && \ strcmp(iter->name,current_file->name)) { - printf(" included from: '%s:%d'\n", - iter->name, iter->lineno-1); + fprintf(stderr, " included from: '%s:%d'\n", + iter->name, iter->lineno-1); iter = iter->parent; } if (iter) - printf(" included from: '%s:%d'\n", - iter->name, iter->lineno+1); + fprintf(stderr, " included from: '%s:%d'\n", + iter->name, iter->lineno+1); exit(1); } }