From patchwork Wed Mar 7 12:25:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 130868 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp5119484lja; Wed, 7 Mar 2018 04:26:07 -0800 (PST) X-Google-Smtp-Source: AG47ELtdSgq7VRJwy5jPZdSEZpKBqulHQizoRHUUwHcq2ibEr90JFeOZTH7b6q19jXWX9hgnAwTI X-Received: by 2002:a17:902:6ac2:: with SMTP id i2-v6mr19870851plt.368.1520425567209; Wed, 07 Mar 2018 04:26:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520425567; cv=none; d=google.com; s=arc-20160816; b=BKeih2FKHQG5pAYtI4paema2Kwsdni7LVAiuEQIpCz1UL6zgE9Au2p7k/65kSXxbYw NbiNZxCwOGBTxrO5shOA928bZK8AQ8mZN0BGCmVGxHTLYVb/m8xTVcmvgxU9m85nUVZ7 G5NIUQOTUT/CMPL08ScY9w4LE6ZxzE/YGXHROOS1/XyN54reHfyyjjf2lQarjWwI3NRN uZ/DTU/yPh8oBmwX+de7tjQN6YdJZHEwtS8wZltCf3hsKfqVskBpb2yJtM/rxnU66KZa hUu+Wd1AuYFiLz/0UCaiIAIFJ4eYqwsUuW9DhWNhNXH1nbrSMIS/8P8HKweh/w3RkyQi JPfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=0mADjAhD8vNirl2KxJinAGhfM0hmPNYd14t60Q+9Kpk=; b=VQZr6/LphtkRGAHGF/RJ5Cy1d9SdyJ1TB/KltOCVgBFUkKEKGsTxEEBrpRqUR+FJC0 SXpuUlrBoeIJLfeDDFJlpmLiXEJdQ/EWHXJK/bCH5OKC6DE2YcfofMRpi9l1t7+JQXJ4 hWLwi9EGiWxzKia3Vv5F7H01iASMw80buXMkpKxCFR2mfDHCLLWjSEMgU+Jp3Wnpxcy5 S2oc+0JYZOXl1t0x6ShkBk3q3T7sYjYoOkk7gPr7a9Uh5UmK9gtRtaJgZY8UvkceD0dz 44IvK17d4gZs5JaEtL9gYARQWPBt71lwQ+nS2+yE0Ev5lqummy83HNs35vi0P04Dl5QW RvJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y67si11302164pgb.728.2018.03.07.04.26.06; Wed, 07 Mar 2018 04:26:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754353AbeCGM0D (ORCPT + 28 others); Wed, 7 Mar 2018 07:26:03 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:6167 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753807AbeCGMZ5 (ORCPT ); Wed, 7 Mar 2018 07:25:57 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id BAC0525629C4E; Wed, 7 Mar 2018 20:25:42 +0800 (CST) Received: from localhost.localdomain (10.67.212.75) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.361.1; Wed, 7 Mar 2018 20:25:36 +0800 From: John Garry To: , , , , CC: , , , , Xiaofei Tan , John Garry Subject: [PATCH v4 07/10] scsi: hisi_sas: fix return value of hisi_sas_task_prep() Date: Wed, 7 Mar 2018 20:25:11 +0800 Message-ID: <1520425514-205565-8-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1520425514-205565-1-git-send-email-john.garry@huawei.com> References: <1520425514-205565-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiaofei Tan It is an implicit regulation that error code that function returned should be negative. But hisi_sas_task_prep() doesn't follow this. This may cause problems in the upper layer code. For example, in sas_expander.c of libsas, smp_execute_task_sg() may return the number of bytes of underrun. It will be conflicted with the scenaio lldd_execute_task() return an positive error code. This patch change the return value from SAS_PHY_DOWN to -ECOMM in hisi_sas_task_prep(). Signed-off-by: Xiaofei Tan Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.9.1 diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 88ad8d4..dff9723 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -316,7 +316,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_sas_dq */ if (device->dev_type != SAS_SATA_DEV) task->task_done(task); - return SAS_PHY_DOWN; + return -ECOMM; } if (DEV_IS_GONE(sas_dev)) { @@ -327,7 +327,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_sas_dq dev_info(dev, "task prep: device %016llx not ready\n", SAS_ADDR(device->sas_addr)); - return SAS_PHY_DOWN; + return -ECOMM; } port = to_hisi_sas_port(sas_port); @@ -337,7 +337,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_sas_dq "SATA/STP" : "SAS", device->port->id); - return SAS_PHY_DOWN; + return -ECOMM; } if (!sas_protocol_ata(task->task_proto)) {