From patchwork Sat Jun 23 13:56:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 139754 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp2032452lji; Sat, 23 Jun 2018 06:58:23 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIMmAI0ojgaZf4yoM9HA1+d1xjPrPagBhR5vK6FJzxFgKGyBAADoMzoy84Z7xe/JdZi551Q X-Received: by 2002:a62:da59:: with SMTP id w25-v6mr5966461pfl.161.1529762302882; Sat, 23 Jun 2018 06:58:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529762302; cv=none; d=google.com; s=arc-20160816; b=ucJOFK5l1q3O18KzNHvU6Pzkm6bY8qIYwhrSeod8jtjhNEs1GLbjDPp7FwwG4q9d0I v7xmDKAyJ8KzMTPSu2JbLXz9HqTeXGTpinJVWcTHk1CVdo4pOBNINyhbtQ4LEMy2WLY/ 3mob2k+9/fVaBYVlE6R8qG9SnsLkrqc86vngZ/6nPXwktk3ay92zwcACnozF38T2RzRe DEzTXsKitErUjrURc1ZIYovAwCb6QwhxvNn0tpmG0D5pN0BstiNyuEcuaZaAGNrynCLj kNUNRY/8j7LN/CM1Ggixib+tiO4FSGeJzvkjT/UWA8i7E+MwFC6INSOMIhy4u5TmVLgV PtTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:arc-authentication-results; bh=v6NARSvF1UqBTvB6pr8gmxA1bLYv2eXXGO7gcMxQNZ0=; b=oJ1DF/3OwyBRzggLEeQney8JI3MpIjQ4asdMvF5ncFGmK78hKYwkII9XoGfmB49tkH B+biSanOEUUs+G5+HC83DuDz5tYoN61Ygn2d5UzWkJh5Seq3nwUaHGDmB5b2eqRJTb4W C9clWVIk0AYXv8IzAyVyXAYITwCpTIjuJ+UKcqtAUtK/e0Ob+HQYDSObknDovTRkjxiM LtzySPr3OzZ58NJIQRHMYgD5MzRRNFERWBwQlcePML+KsiIm5+OwGxxYha4Oxb/Pa2uV MIqPMO/71GeFqAUhWxJB6pNFnmsv3Az+LAM99sHRhD+mcJ3oAWEAIOUcje5BUgbukBOJ D9KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="1Iaqp/EV"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v18-v6si9663452plo.285.2018.06.23.06.58.22; Sat, 23 Jun 2018 06:58:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="1Iaqp/EV"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbeFWN6S (ORCPT + 31 others); Sat, 23 Jun 2018 09:58:18 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:44605 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbeFWN6N (ORCPT ); Sat, 23 Jun 2018 09:58:13 -0400 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-08.nifty.com with ESMTP id w5NDvYBU015690; Sat, 23 Jun 2018 22:57:35 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com w5NDvYBU015690 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1529762255; bh=v6NARSvF1UqBTvB6pr8gmxA1bLYv2eXXGO7gcMxQNZ0=; h=From:To:Cc:Subject:Date:From; b=1Iaqp/EVhNjHBgpUr4UWufcGiyqjvj7AuPsqZOYTZVQmx41NulFOS/LwfKjEaHgun wV2rNuDFF7Pa86FFiNwtL34vDqEVrdwj1wOLyG9B+Q/mgI/Mg86hibtvQlgzQd6BVp 8BB9erTO71djodbIx3IlcIzSAZX03MnexbcMzpGn1UigpTaJ9oPPRU28mGRj7Kv/36 DAJRSMMV0vKdu2uHnGH8qrw9R71aAaAOxPUKuKNuZEA4OD3bh8nUX/igFHiMibDM5D cTnGzRpMVlvrs3xGT534uES8xIqlyhhV+ndeItVgTiUuPmCDLWMyGIQDustn1HX6+j SfNh+Wvo6tPlA== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Sam Ravnborg , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] kbuild: use 'include' directive to load auto.conf from top Makefile Date: Sat, 23 Jun 2018 22:56:07 +0900 Message-Id: <1529762169-13488-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When you build targets that require the kernel configuration, dot-config is set to 1, then the top-level Makefile includes auto.conf. However, Make considers its inclusion is optional because the '-include' directive is used. If a necessary configuration file is missing for the external module building, the following error message is displayed: ERROR: Kernel configuration is invalid. include/generated/autoconf.h or include/config/auto.conf are missing. Run 'make oldconfig && make prepare' on kernel src to fix it. However, Make still continues building; /bin/false let the creation of 'include/config/auto.config' fail, but Make can ignore the error since it is included by the '-include' directive. Use the 'include' directive instead. This allows the /bin/false to correctly terminate the whole build process. Signed-off-by: Masahiro Yamada --- Changes in v2: - New patch Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/Makefile b/Makefile index ca2af1a..413c2ed 100644 --- a/Makefile +++ b/Makefile @@ -589,7 +589,7 @@ virt-y := virt/ endif # KBUILD_EXTMOD ifeq ($(dot-config),1) --include include/config/auto.conf +include include/config/auto.conf endif # The all: target is the default when no target is given on the