From patchwork Tue Oct 2 11:06:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 147963 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp5007104lji; Tue, 2 Oct 2018 04:05:42 -0700 (PDT) X-Google-Smtp-Source: ACcGV62VQdNzFEVxA6pkfNEYE54QYzEZpbWdFZz5a56p8D9v8cU7IcruGZph4ANLL+o9MA98+5g2 X-Received: by 2002:a63:e749:: with SMTP id j9-v6mr8247656pgk.246.1538478342734; Tue, 02 Oct 2018 04:05:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538478342; cv=none; d=google.com; s=arc-20160816; b=eAnM3ajoR5OB7xQ35AMyKIDxsA0WZDAGoaFwDz5Amd6zBRo1YXN1KBQgsjDk/Q522E 7obFPvzIxwV7c05ZkVr4KGhsa/cr13fXJ2DTm+gI3+4EZitqkCjx+T0olww8GktYvt1b SMZySPRCsWOs8Uh/Xx0IrhNCmzjZP684lBzANRAe5hZYrl1sy7b4Fsja+E9R3RcDS1Pa ssYqMUrQNT845Y4GHoqJhvzDM/vjXtZpiVxU6A11yDyobKjw+8PsDGQ28+WbTmg2FEBX 47Ui/P6aNwvyQkWURK3zOHtU0HrCe/RGgRsDBD73yaZ4hcRS/02PrhtbvXxrDKGyJ4I2 QfkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=5Z6J2RQTqMWhpJ0pzFttI0SwIzpZ6lRPEY1BeHTRt8o=; b=Wgea0N0LLGhIlBNI0OWMNasTGki6SFVsta19E0Lzn83M2UQme+UcJiEqYMjSm672c/ BKkKXbEdem0vAsrYxdlA/Z20RS7Llm9zrXY0WchzGK4J2MFKU3mxEnLjmZ4SXycfekER y3fNZbq+KBBKWem+wz4FE3FzEIw1sGpZJpLTFsmjUR0IJzajTiBoXbLlo9c2MT7cHSaA poGyvNNyQRAHh8h/GoDroWngzZXD9sF9YfGLmdeNASy9pzXysB8rKgw0Jf7WuHSVOLda lR7njcSqX1R2OmqWb9O2+xsQSYP59UpgTDY/a8w0IBOZ8aSsT8qQLVfLrhdrgI4+57HM tJ+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m125-v6si15192738pgm.541.2018.10.02.04.05.42; Tue, 02 Oct 2018 04:05:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727661AbeJBRsY (ORCPT + 32 others); Tue, 2 Oct 2018 13:48:24 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:34686 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727546AbeJBRsY (ORCPT ); Tue, 2 Oct 2018 13:48:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9ABFF15BF; Tue, 2 Oct 2018 04:05:40 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6BBD53F7F4; Tue, 2 Oct 2018 04:05:40 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 5D9771AE3E55; Tue, 2 Oct 2018 12:06:04 +0100 (BST) From: Will Deacon To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: cpandya@codeaurora.org, toshi.kani@hpe.com, tglx@linutronix.de, mhocko@suse.com, akpm@linux-foundation.org, sean.j.christopherson@intel.com, Will Deacon Subject: [PATCH v2 2/5] arm64: mmu: Drop pXd_present() checks from pXd_free_pYd_table() Date: Tue, 2 Oct 2018 12:06:00 +0100 Message-Id: <1538478363-16255-3-git-send-email-will.deacon@arm.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1538478363-16255-1-git-send-email-will.deacon@arm.com> References: <1538478363-16255-1-git-send-email-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that the core code checks this for us, we don't need to do it in the backend. Cc: Chintan Pandya Cc: Toshi Kani Cc: Thomas Gleixner Cc: Michal Hocko Cc: Andrew Morton Signed-off-by: Will Deacon --- arch/arm64/mm/mmu.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.1.4 diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 8080c9f489c3..0dcb3354d6dd 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -985,10 +985,8 @@ int pmd_free_pte_page(pmd_t *pmdp, unsigned long addr) pmd = READ_ONCE(*pmdp); - if (!pmd_present(pmd)) - return 1; if (!pmd_table(pmd)) { - VM_WARN_ON(!pmd_table(pmd)); + VM_WARN_ON(1); return 1; } @@ -1008,10 +1006,8 @@ int pud_free_pmd_page(pud_t *pudp, unsigned long addr) pud = READ_ONCE(*pudp); - if (!pud_present(pud)) - return 1; if (!pud_table(pud)) { - VM_WARN_ON(!pud_table(pud)); + VM_WARN_ON(1); return 1; }