From patchwork Wed Oct 17 09:18:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 149051 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp408504lji; Wed, 17 Oct 2018 02:18:58 -0700 (PDT) X-Google-Smtp-Source: ACcGV60oJqwNUq5ofbiNYlF/OjDBhqiLfiWT6HwARFSDO/Jpogfx7DmlDvSafIkMle8O/1zmP8+1 X-Received: by 2002:a62:c42:: with SMTP id u63-v6mr25932231pfi.43.1539767938362; Wed, 17 Oct 2018 02:18:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539767938; cv=none; d=google.com; s=arc-20160816; b=rIKXr82lTDujup7w8KfkZEZYAwGyvyo59Q8EZsJw3MVRayNPXyWzbaC6Nbl/fPL2yA jiKbsJVzHP8eOGHSRZAv4wruZHZCWMbPooO7zha19eIXhmqpoW0RIbYYGgglWHEp+aPf kfWNnjsbDdDHXjsWuj7w7JtSqdx2V5nP+D5rJXK8A///xC7XmV31HU99FhC+CVwO/9z5 IgG2+5Ese1muqgB06bVGT0WtU3Ym00xwWBaYaIpwEpLRU9akS0r106I1WTHwhO08/zHk ZJpKIRLNTedPn3vUSVafdcyQQboV1YIaKLp3IFgJY0SCSXaBsTf0VyaHPyD8zJFY0kEL LM/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=gtO5omnR5DvfsMQEV+qrCgDc9JtgzpU/WP6fSSftpWs=; b=cAMsdqw+GbtnoES1wVW9fiOgbNPVnrNG4Ysd07wO871kgtsXL3pla0MshnqKbhpU3X Z5bJ31PP+xglhCIfEDcQWdouyWhtnBKQnjbnAeZl0WOGFPQdD2/jrpJRVkpjXyI62KeZ b2Ss+xR8UyfG6u+IqaXn6n3UeGF817w6rn4g6NbaYhb8z5M5TVeDhfrZLv2T+X2XAlRI nLqzdaVyzgmmYBfJdEWrfqTshAmLeSVyUcEe/R7Cv/sxVErpFZMDCMrLrdim7NmRPAwA Gk3tkDQA2BpgwVGJggBTGfsv5lP7rMnhKTb02Ual1e9h61WitX14ZFjK9i1eOi2/yvk1 EX8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fx3pQzb7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c13-v6si16731572pgi.518.2018.10.17.02.18.58; Wed, 17 Oct 2018 02:18:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fx3pQzb7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727250AbeJQRNn (ORCPT + 32 others); Wed, 17 Oct 2018 13:13:43 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:34578 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbeJQRNn (ORCPT ); Wed, 17 Oct 2018 13:13:43 -0400 Received: by mail-wm1-f68.google.com with SMTP id z25-v6so1019477wmf.1 for ; Wed, 17 Oct 2018 02:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=gtO5omnR5DvfsMQEV+qrCgDc9JtgzpU/WP6fSSftpWs=; b=fx3pQzb7C/Y3ml/4o3vKT2ohmdcsHQTEsOzZkA3pKIiJdSaLHWe135bt45leh8Dll1 rwM4JNDQpKwKABPGwWu0IcAE9E8k7/4V5pD0AnoohfZnbjnLvJoNwmLx62HXqezDIK8C U5ZlmPlPc8cj3e7LR9P2nA8mNwyiORXdIx8oo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gtO5omnR5DvfsMQEV+qrCgDc9JtgzpU/WP6fSSftpWs=; b=No4Bjs3YVL2LVjdXjmewIW/sqSW5sqfZTmciwQQ3aa//wSoZr8TjEvcftSLcNmXNgH cSl/mmwE4DVaMxmA73aGsNBvmQLCrrjHFwRMqqo2Z0xqubm8gHZKrNPnxuKDiIGV+PzC O8kJlBHBzlQOf4+MsyemNvZXrqZc851iUgLeADp+1FrhFaDRHLQaBBMMtMXbNDa6/8tL w/0Ig/cudFlAW2GrSpzUfgQRh5U4dS97nZFzr19f6Wq5jGdxxlzEFiEdB3JDjwXR0fW7 sa54biSt9yfd+iYxE0O+jLriZ4HJ+rJc1ePxspAnwSjFIWXNPF+HgYPEjUerIorFW4xa yXPg== X-Gm-Message-State: ABuFfogTv8rmgF9/Z+OvrKw/C3uVG/t7ERYSfk5XIR7WbeAD1ABmjMia rkWf7BacSMrEN2lusz0xtieqoA== X-Received: by 2002:a1c:34d2:: with SMTP id b201-v6mr1903808wma.115.1539767934167; Wed, 17 Oct 2018 02:18:54 -0700 (PDT) Received: from localhost.localdomain (212.156.88.92.rev.sfr.net. [92.88.156.212]) by smtp.gmail.com with ESMTPSA id 18-v6sm1094723wmw.26.2018.10.17.02.18.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 17 Oct 2018 02:18:53 -0700 (PDT) From: Daniel Lezcano To: heiko@sntech.de Cc: linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Rob Herring , Mark Rutland , Vicente Bergas , Ezequiel Garcia , Shawn Lin , Enric Balletbo i Serra , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) Subject: [PATCH V2] DT: rockchip: Fix stability issues with the 'performance' governor on rock960 Date: Wed, 17 Oct 2018 11:18:30 +0200 Message-Id: <1539767918-26587-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the performance governor is set as default, the rock960 hangs around one minute after booting, whatever the activity is (idle, key pressed, loaded, ...). Based on the commit log found at https://patchwork.kernel.org/patch/10092377/ "vdd_log has no consumer and therefore will not be set to a specific voltage. Still the PWM output pin gets configured and thence the vdd_log output voltage will changed from it's default. Depending on the idle state of the PWM this will slightly over or undervoltage the logic supply of the RK3399 and cause instability with GbE (undervoltage) and PCIe (overvoltage). Since the default value set by a voltage divider is the correct supply voltage and we don't need to change it during runtime we remove the rail from the devicetree completely so the PWM pin will not be configured." After removing the vdd-log from the rock960's specific DT, the board does no longer hang and shows a stable behavior. Apply the same change for the rock960 by removing the vdd-log from the DT. Fixes: 874846f1fccd ("arm64: dts: rockchip: add 96boards RK3399 Ficus board") Tested-by: Manivannan Sadhasivam Signed-off-by: Daniel Lezcano --- Changelog - V2 * Added Tested and Fixes tags --- arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 12 ------------ 1 file changed, 12 deletions(-) -- 2.7.4 diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi index 6c8c4ab..56abbb0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi @@ -57,18 +57,6 @@ regulator-always-on; vin-supply = <&vcc_sys>; }; - - vdd_log: vdd-log { - compatible = "pwm-regulator"; - pwms = <&pwm2 0 25000 0>; - regulator-name = "vdd_log"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <1400000>; - regulator-always-on; - regulator-boot-on; - vin-supply = <&vcc_sys>; - }; - }; &cpu_l0 {