From patchwork Thu Dec 6 18:21:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 153053 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp10859787ljp; Thu, 6 Dec 2018 10:21:18 -0800 (PST) X-Google-Smtp-Source: AFSGD/VJ+ANYA1O9AoaMOWlqkmv39NPjQcZnczhk7UD4zBa5LAaC4GWpwQLJaQFNw708/kA8uGVH X-Received: by 2002:a63:3703:: with SMTP id e3mr24512473pga.348.1544120478326; Thu, 06 Dec 2018 10:21:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544120478; cv=none; d=google.com; s=arc-20160816; b=FyuL06Jnph1s1fI2yHTR8OyjiwrJgQg5VuX9QUzC1wKpPd5hGZ7P8Ve++MkHHBmCmW D6KVkiDW2pTjT49di8W4kfNOAKbB/iAvD/Jn49/Slq/JaERhr5dFiXctJ1cnsgUt3wcq OVi3lUnHH0QmOlnQjsJsu0hxmLJtZPugYKNHlBAs5e3roEtm3HU48iPtNo1dPnBeOAyW 1zxpezuYiDxKcRVZSW8xheeD//i2CHOxWwJeUy6qUaC0Vm09CcpOxIbQZ0C5SaR31tYT lmng2if+DZa/F8rAoRDKACQQlRQ/TUzApyyTOQnM3GtUsfCywKbOt5Bz7/zA4VdJSzo2 VVWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=/V6Ii5Ay/gyCu4FDeRHUvTmr/uoACgypNN/miYDcTTU=; b=yNVNciNZ08haqLeEQ6HSbZdBuNEzmHmCm3dHf14nlcNusx5QNzfWDL0O0U3fFVQoZe SNu7v7noLsiC8zZJWeMcG0I4U5PItAocJ7BS8mFyyLl33HrmzVHZJ0P6T7tqpjK8/1WT jCbsp3kcVSMnJ6yrtnMEv7sENioZSPQtYXmBWCSeVjElIs6FjDX4D8kD3VPvIosos2cO ZL9scxtphwV2K9ggKrGIxTqwC4imOjqA0vufFz9yStxeRsePFEktKGOCzos6dj4Jj2NM ZJBok7nE5i5k+jC1w9/SuoMomgsQX5bhwbQZxSI0wUK4v71z281jqkk5chOzZH7m5Mm8 ie8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n8si799809plk.9.2018.12.06.10.21.18; Thu, 06 Dec 2018 10:21:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726101AbeLFSVQ (ORCPT + 31 others); Thu, 6 Dec 2018 13:21:16 -0500 Received: from foss.arm.com ([217.140.101.70]:57838 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbeLFSVQ (ORCPT ); Thu, 6 Dec 2018 13:21:16 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9FFF81596; Thu, 6 Dec 2018 10:21:15 -0800 (PST) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7098C3F908; Thu, 6 Dec 2018 10:21:15 -0800 (PST) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 841DA1AE0BE1; Thu, 6 Dec 2018 18:21:36 +0000 (GMT) From: Will Deacon To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cpandya@codeaurora.org, toshi.kani@hpe.com, tglx@linutronix.de, mhocko@suse.com, sean.j.christopherson@intel.com, Will Deacon Subject: [RESEND PATCH v4 2/5] arm64: mmu: Drop pXd_present() checks from pXd_free_pYd_table() Date: Thu, 6 Dec 2018 18:21:32 +0000 Message-Id: <1544120495-17438-3-git-send-email-will.deacon@arm.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1544120495-17438-1-git-send-email-will.deacon@arm.com> References: <1544120495-17438-1-git-send-email-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The core code already has a check for pXd_none(), so remove it from the architecture implementation. Cc: Chintan Pandya Cc: Toshi Kani Cc: Thomas Gleixner Cc: Michal Hocko Cc: Andrew Morton Signed-off-by: Will Deacon --- arch/arm64/mm/mmu.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.1.4 diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index d1d6601b385d..786cfa6355be 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -989,10 +989,8 @@ int pmd_free_pte_page(pmd_t *pmdp, unsigned long addr) pmd = READ_ONCE(*pmdp); - if (!pmd_present(pmd)) - return 1; if (!pmd_table(pmd)) { - VM_WARN_ON(!pmd_table(pmd)); + VM_WARN_ON(1); return 1; } @@ -1012,10 +1010,8 @@ int pud_free_pmd_page(pud_t *pudp, unsigned long addr) pud = READ_ONCE(*pudp); - if (!pud_present(pud)) - return 1; if (!pud_table(pud)) { - VM_WARN_ON(!pud_table(pud)); + VM_WARN_ON(1); return 1; }