From patchwork Thu Dec 20 07:55:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 154323 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp5858612ljp; Wed, 19 Dec 2018 23:56:12 -0800 (PST) X-Google-Smtp-Source: AFSGD/Ver7Z6i5gnXPDSDjoMucrGumqfeaQGTc+kFHE+/ngtCH0NW8W8eEAxT/jr1R5qOrsIFUgs X-Received: by 2002:a63:2bc4:: with SMTP id r187mr21890161pgr.306.1545292572836; Wed, 19 Dec 2018 23:56:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545292572; cv=none; d=google.com; s=arc-20160816; b=okjmX9B5GqaU6kF2rTpmdKM9EgZgN3+1EZ1tfeVaSqTUGQApjhxDFcnAtRBHxd5h+z 3bMfrMxoQESXpdbAX0IOwYQZORZUM1UvhoGEv2pldJzXJQSHWUIPrhXWaH20wf2X/8m0 ovQNqI7yi/E8HETWVaEJdBHqwslJU7XLF04Z/Q1UxzJDR2mpyN3us6QEiKdK/G/QYfTf SzworsoEGE+akNpjW99aynoM9StnLxXLXrdGA87TKgIo1PGhKYLs9ZHrgKhQw9ysQGle nEPG+ZcmUQpiyfW1F2jEjAxwsoxJ+WvvGanJmAO7okQkIKFzU7L2QJspUxX/wZHaN8DQ XA4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=SlBtkRSyk5NHoysVqYAQ3q4Z+DHM3H/qzoVSFkfbj34=; b=s2uNZDz97muG7ME2yQim2gJSvDabj3LvViTyIBlrSLcHquvd9ChZTAWdS8JjWJjAMN hS6X6V2z/z3C33UiYmPPOweHNcsg7bQV5iwSPUsI+WBD9BO0/qIrl7SJiOm46JVxcqQI znJlPpR/2G53HrG4czKIoH+rNULhWvUkYkIoX2dpMdWUbCaqNpgHBnMgyuHfusNsxLmR S6qpIgWOBlMWqRYgERoz/Irhwh1QjEdhEYobters/FrPRXuRXi0u+GSqix0qCWhmBgrc qmj4tU7+M5zhyNwWWHe6QmM6RVylqjrBmFlFH4tBHbZe4h0yXDFe7LIjEu2wdXxitVxD QGDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Y/N7UaR0"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f23si1076903pgv.431.2018.12.19.23.56.12; Wed, 19 Dec 2018 23:56:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Y/N7UaR0"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730757AbeLTHz6 (ORCPT + 31 others); Thu, 20 Dec 2018 02:55:58 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54646 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727232AbeLTHzz (ORCPT ); Thu, 20 Dec 2018 02:55:55 -0500 Received: by mail-wm1-f66.google.com with SMTP id a62so924272wmh.4 for ; Wed, 19 Dec 2018 23:55:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SlBtkRSyk5NHoysVqYAQ3q4Z+DHM3H/qzoVSFkfbj34=; b=Y/N7UaR01MZ9zjpYKlA8dpIHsDzdewGmTT3wypxGl4ygv2VkfO1P4nR2S8uOeueKSZ zZUniYt9zSX+rfSOi/TbO4RJS44jzYP0ZPQ8cQkYDcUlz9YJTmYy6PjiwLYqbOgVqXMG mmVlZxOKPoealoTCkYLFb9cuLZlLuikDdu05k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SlBtkRSyk5NHoysVqYAQ3q4Z+DHM3H/qzoVSFkfbj34=; b=KA0tiTSsFXcWnBAM4/Ee0iSwSYdq3TaFHEweWfyae0GPVG4QRyJLpN0FQaQtLdcmGi O02OTW01NiLeHOne35jhnqatEJdaVuRQ3rQAaN1rt/xeS5iDdaSq0P4pn0IKbsrCpm57 2JrU/ZMivm+c9R15/4eXXvlbTzseUv1NZZaDjsIuAGZA2Bbn+tLPWbS+e4FCszyh7mNY /18XroZd3TpjrarcNJ1vR8VlNErQparKtZi0OOMxPPZ1MTXNHMhgvH7ObdSdds1IejW3 HDhFctyL7r6+ff9aHPfXImoCVb/oBuMKq1JXCwEH8c5mT20GWfbmbZnElbNUSnpE1Mee L/RA== X-Gm-Message-State: AA+aEWZf0mv+kv/kWp46yKM2QupNstvmwtp97hvDfjGEHPXrNKB7JLwV tB0QYMvQKIy2Yjlidr62TMgGcQ== X-Received: by 2002:a1c:9d57:: with SMTP id g84mr9612559wme.16.1545292553240; Wed, 19 Dec 2018 23:55:53 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:f:6020:f9b3:37c1:b11a:64ce]) by smtp.gmail.com with ESMTPSA id c10sm8773299wrw.49.2018.12.19.23.55.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Dec 2018 23:55:52 -0800 (PST) From: Vincent Guittot To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org Cc: valentin.schneider@arm.com, Morten.Rasmussen@arm.com, Vincent Guittot Subject: [PATCH 2/3] sched/fair: trigger asym_packing during idle load balance Date: Thu, 20 Dec 2018 08:55:46 +0100 Message-Id: <1545292547-18770-3-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1545292547-18770-1-git-send-email-vincent.guittot@linaro.org> References: <1545292547-18770-1-git-send-email-vincent.guittot@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org newly idle load balance is not always triggered when a cpu becomes idle. This prevent the scheduler to get a chance to migrate task for asym packing. Enable active migration because of asym packing during idle load balance too. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 Reviewed-by: Valentin Schneider diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 9b31247..487c73e 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8853,7 +8853,7 @@ static int need_active_balance(struct lb_env *env) { struct sched_domain *sd = env->sd; - if (env->idle == CPU_NEWLY_IDLE) { + if (env->idle != CPU_NOT_IDLE) { /* * ASYM_PACKING needs to force migrate tasks from busy but