From patchwork Fri Jan 18 03:58:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 155885 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2786197jaa; Thu, 17 Jan 2019 19:59:07 -0800 (PST) X-Google-Smtp-Source: ALg8bN6ByAG31jl5eSHHtVL0sIzLR6XTZxNnmJ7f6oeHAsZ8kTpVAgak8eT3F5TXwt4IS441SC8L X-Received: by 2002:a63:9256:: with SMTP id s22mr15606010pgn.224.1547783947850; Thu, 17 Jan 2019 19:59:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547783947; cv=none; d=google.com; s=arc-20160816; b=S4H9Oh5odLE1zWn/leh338FkjVuS/e6bNkEvp91JUe6p6OMUXwlFSXVTCgXSrB0Nsf bqySdlM+8av5hbX2zSDfZnE13TSQbbtuB4grHx9xt4Ji/Sb9Hyq/w6MbGO/wAW02AGsP 0T2UmNLbi8Yol/DcGuB4H5OrMgeOCqCGuXLNqvkcvgAhSkaYoO6jf03pz2+WIIZDAKlS /O08I4CYh3Xt5HXwY+d0bX4+RmpYqeRAZ8N1dIh3+uQDuzkO8mYJXNgQ/UvNob69n54J cmiYWqyGLo5ROU8ruqauraKmNbHN2/4qQF5sftlheMGdCmhHAdTkLNoeeYgE1j7P1Jkp 0nmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=b/h/b3rLiG2RhSWm7dfEk59KmGj9X68TwOhNEEGYgpc=; b=sntUTiemb0bSfxlaBpeSAT446b4tOysYCa2OSU1mkX9/A9j3Ae4LxZ+iaQxPAGhcI6 03s9F/0KT2cbw+7a8qT4d4JqXcR7+UvPTK4FHFhC63gXXyQOAhs/mmLfKWKV1xIYM4Ph 2kKQHey0VJobX7GrXV0qxQm2i2UomY6BvB/OCKwlLljAcw/tVFfEX1kp2U37LYvSfGEY 4jOTcTacClv3a1g+oIEHy0Kp03GfjOa2Bvb7d6u+18YsTUrho9LDA4tcnrJ8je3DfygR wrjadyDmCVIoXoMpSM+sy6ZaUnW+hYxpaKL2imBgtnKPgHBEo8bO3BNxqw4Uy5qy8bzs VAsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=liVdwCsX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5si3353947plt.273.2019.01.17.19.59.07; Thu, 17 Jan 2019 19:59:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=liVdwCsX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727022AbfARD7G (ORCPT + 12 others); Thu, 17 Jan 2019 22:59:06 -0500 Received: from conuserg-11.nifty.com ([210.131.2.78]:24941 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726913AbfARD7D (ORCPT ); Thu, 17 Jan 2019 22:59:03 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-11.nifty.com with ESMTP id x0I3wVKF005804; Fri, 18 Jan 2019 12:58:43 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com x0I3wVKF005804 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1547783924; bh=b/h/b3rLiG2RhSWm7dfEk59KmGj9X68TwOhNEEGYgpc=; h=From:To:Cc:Subject:Date:From; b=liVdwCsXPsK5rH4uC1uOJxEJnTEiIMCgfmIEO3HM1J+R7mIPqXL0ilDOGXzGAUYLN ENSFH+9BcqNq4H6yzFlJSEGU+qyAWVj1UkQ0d3NGx8Kag2dSDuvmrq3QdVFO25dcX6 6dCyfpb5wtzeYVxgvDfbY/1tIltR2Pel3ABkEIZmKkt/h6q68SW/reuHKtMkSxSXPI HUwgm5EkR0SmknOaStQnDTxblyPpnrfCnGWBoL2P4dNw+obaEQiRyb+31XhR35rkUU 114j/C7+H9CiAxADyDwL3G9EpwyoJEPQIgdccBQ+dqjUJxww8z9qBprUkMWavquw3E H8yfrDN+fWmhw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH] kbuild: remove meaningless prepare2 target Date: Fri, 18 Jan 2019 12:58:30 +0900 Message-Id: <1547783910-31653-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no build order among the following: prepare3 outputmakefile asm-generic $(version_h) $(autoksyms_h) include/generated/utsrelease.h It is meaningless to insert the prepare2 target between the first three and the last three. The comment says, "prepare2 creates a makefile if using a separate output directory." Let me explain it more precisely. The prepare targets cannot be executed without the .config file. Because the configuration targets depend on the outputmakefile target, the generated makefile is already there before the parepare2 is run. Signed-off-by: Masahiro Yamada --- Makefile | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) -- 2.7.4 diff --git a/Makefile b/Makefile index 9851a44..cddcdb8 100644 --- a/Makefile +++ b/Makefile @@ -1062,7 +1062,7 @@ scripts: scripts_basic scripts_dtc # archprepare is used in arch Makefiles and when processed asm symlink, # version.h and scripts_basic is processed / created. -PHONY += prepare archprepare prepare1 prepare2 prepare3 +PHONY += prepare archprepare prepare1 prepare3 # prepare3 is used to check if we are building in a separate output directory, # and if so do: @@ -1077,12 +1077,8 @@ ifneq ($(KBUILD_SRC),) fi; endif -# prepare2 creates a makefile if using a separate output directory. -# From this point forward, .config has been reprocessed, so any rules -# that need to depend on updated CONFIG_* values can be checked here. -prepare2: prepare3 outputmakefile asm-generic - -prepare1: prepare2 $(version_h) $(autoksyms_h) include/generated/utsrelease.h +prepare1: prepare3 outputmakefile asm-generic $(version_h) $(autoksyms_h) \ + include/generated/utsrelease.h $(cmd_crmodverdir) archprepare: archheaders archscripts prepare1 scripts