From patchwork Thu Apr 11 12:46:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 162060 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp7377487jan; Thu, 11 Apr 2019 05:47:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLD5TBdlPHNDVJ4zPF1fsn6/OZn5oSiMCM0SJXkOqC6YERJQiBaEjqw3rFvmx1ME6f0HkD X-Received: by 2002:a17:902:6b8b:: with SMTP id p11mr26294970plk.225.1554986855886; Thu, 11 Apr 2019 05:47:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554986855; cv=none; d=google.com; s=arc-20160816; b=IqmzCTQJkkfk1Ck95ytFsUwRYhTbUAeXKHz2Ey0liZGaVXz6VuxHaIl+xs1U7KmOgN ua52VezmUnFjOyII62TSaoOvc1SJCNVT9RY4Xcj2Mw1QB47ARfpK76lvJRARI2YPkUlp 89m6GpNHAAGcA4xr/98gxqwJb0KWYQFXH54503s8z5sSHcXtcRkynaP2MAC+UqjXV0+j JS7LgtKaSJyJ07f8/+safrmO6SNEdrDO3U9PRc/11C2YK56D7OdfFUgy/MUW7I7ggan4 52r/kCgq9kEIkNB3lIUqCkIolgN/a5DvEYtRiyP3F6s42KtGLx2WAU91G33XJLKvV/Gb qthA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=lqpODlkG2dhidMTC5JGdMOoK40J3RliOfmJ4JHj5Ekw=; b=J/oqlRoCYuYprURU+GWXGmO6xSiEzOLrKpuIaS7xTxcCDRdtnFJKnnC5PhPTJzixFf AxvVKXsx9Z6UDadWbfVHAVIJzGfYY3QtNE3/Va8jt7wgwOySelTXsuimXHgsbota8uTP 038DakbPtWqVQ0HLI/A5WsQjZSxfsEJJ94On9O7YrlnxOsZijapP4dQ7vjSEBumQFuET MTsbVx/VIcTt0v7DvgyTuD75yjTuC2/OithPssC1RHAJ6VND3Apc2ExX2qE3fgm4kYUl zvLMSj7y9JvILH1k/kuZ+X2u/BE60UWGAKlX5+mShThC1EfznWocKtBhAp/NCAyZBMbm Nnvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z64si35071179pgd.106.2019.04.11.05.47.35; Thu, 11 Apr 2019 05:47:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726886AbfDKMre (ORCPT + 31 others); Thu, 11 Apr 2019 08:47:34 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:41556 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726827AbfDKMrc (ORCPT ); Thu, 11 Apr 2019 08:47:32 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id AF97162032A070E7F36E; Thu, 11 Apr 2019 20:47:29 +0800 (CST) Received: from localhost.localdomain (10.67.212.75) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.408.0; Thu, 11 Apr 2019 20:47:19 +0800 From: John Garry To: , CC: , , , Xiang Chen , "John Garry" Subject: [PATCH 4/9] scsi: hisi_sas: Adjust the printk format of functions hisi_sas_init_device() Date: Thu, 11 Apr 2019 20:46:39 +0800 Message-ID: <1554986804-233706-5-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1554986804-233706-1-git-send-email-john.garry@huawei.com> References: <1554986804-233706-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiang Chen In function hisi_sas_init_device(), the log is as follows when error for hardreset: hisi_sas_v3_hw 0000:74:02.0: SATA disk hardreset fail: 0xffffffed Actually if hardreset failed, its return value is negative, so change the print format from %x to %d. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index d4da537f9a45..ede812759991 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -769,8 +769,7 @@ static int hisi_sas_init_device(struct domain_device *device) } sas_put_local_phy(local_phy); if (rc) { - dev_warn(dev, "SATA disk hardreset fail: 0x%x\n", - rc); + dev_warn(dev, "SATA disk hardreset fail: %d\n", rc); return rc; }