From patchwork Mon Apr 15 16:03:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suzuki K Poulose X-Patchwork-Id: 162203 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3104825jan; Mon, 15 Apr 2019 09:05:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3S5e+LgFWJ4kzmE1oSxjmzXkM4SQUQCT1j779LJH50rdy582TMvKjxdylvwwnIL9jrO67 X-Received: by 2002:a63:2045:: with SMTP id r5mr56315592pgm.394.1555344352148; Mon, 15 Apr 2019 09:05:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555344352; cv=none; d=google.com; s=arc-20160816; b=nA4PTimf1cks+/Zz3WixYhG0tJkuoavW+lS0z7dwbG71rsElA6PeauIkBq0Id4bbPp 85wLNOENpxAhW5eUb4MqLi02URKEDZSEm1nEe/4JeBH+0scfTY7wLpYRPld3D0zmtmcu 7JvviPGWUSDzn4AXC1ZJSkOI9EL3W/uK1Hyqi4v+4lxzEc2wSLmDK77/F1VTI5Ewpl8S GyiuL5Rh6630h67zHp0fxABCrjcPdhJRAO6x7noex83P87IFtHOwlfbHeMGw0J1C6Scd nttll4k0tAMCHJLXPKFq77rTGtaTyRu/hKd25pWqqV6nv6PEf8hoY7ROKbkTJaeL1I5m egOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=1uzAFYMmNX81I1knb0dzNVimTxcNrVPqlVBF4yo+Oh8=; b=nro4ikYJCMrk9FqEvhSLsie7bQVLycnFHttajOef2FvhWqxmhYHE2iD4C+R9I4zpBo 7JSPyDbsTQyMMMZ9tephXjVa8brtjjHDYkUzRAPZ6D7Hpl6MpGI7I/4oI1cVShoBfXsR 8KOT8uNZcor1rDwd/p5CGANAx/G6miMN1ZTR7n/gAwexMhrBYz1dwbCGogtWOxHOAixK 4HM5c/jZtCprR9HU2xeOv/xDheHt6nr9CYNVW/4WXSN18cjspfEuUOerWexYLUiBYApf vku3DopPD3It9nkQUA7e0+My5+baXoZXs6DSPXFugCdiAZpo+VGFk76L4T3q4X4ah0wx FLqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 73si16547264plb.158.2019.04.15.09.05.51; Mon, 15 Apr 2019 09:05:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727386AbfDOQFt (ORCPT + 30 others); Mon, 15 Apr 2019 12:05:49 -0400 Received: from foss.arm.com ([217.140.101.70]:37644 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727143AbfDOQFq (ORCPT ); Mon, 15 Apr 2019 12:05:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 611911684; Mon, 15 Apr 2019 09:05:46 -0700 (PDT) Received: from en101.cambridge.arm.com (en101.cambridge.arm.com [10.1.196.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D22863F68F; Mon, 15 Apr 2019 09:05:44 -0700 (PDT) From: Suzuki K Poulose To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, coresight@lists.linaro.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, rjw@rjwysocki.net, robert.walker@arm.com, Suzuki K Poulose Subject: [PATCH v2 01/36] coresight: Fix freeing up the coresight connections Date: Mon, 15 Apr 2019 17:03:44 +0100 Message-Id: <1555344260-12375-2-git-send-email-suzuki.poulose@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With commit c2c729415b2d2132 ("coresight: platform: Cleanup coresight connection handling"), we switched to re-using coresight_connections for the coresight_device. However, that introduced a mismatch in the alloc/free of the connections. The allocation is made using devm_*, while we use kfree() to release the memory when a device is released (even though we don't support this at the moment). Fix this by leaving it to the automatic freeing of the memory. Fixes: c2c729415b2d2132 ("coresight: platform: Cleanup coresight connection handling") Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight.c | 1 - 1 file changed, 1 deletion(-) -- 2.7.4 diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c index 29cef89..55204dd 100644 --- a/drivers/hwtracing/coresight/coresight.c +++ b/drivers/hwtracing/coresight/coresight.c @@ -973,7 +973,6 @@ static void coresight_device_release(struct device *dev) { struct coresight_device *csdev = to_coresight_device(dev); - kfree(csdev->conns); kfree(csdev->refcnt); kfree(csdev); }