From patchwork Mon May 2 16:15:46 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 1341 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:51:04 -0000 Delivered-To: patches@linaro.org Received: by 10.224.2.73 with SMTP id 9cs270072qai; Mon, 2 May 2011 14:36:56 -0700 (PDT) Received: by 10.236.116.166 with SMTP id g26mr2976602yhh.113.1304372216126; Mon, 02 May 2011 14:36:56 -0700 (PDT) Received: from e7.ny.us.ibm.com (e7.ny.us.ibm.com [32.97.182.137]) by mx.google.com with ESMTPS id p18si10540813ybk.106.2011.05.02.14.36.55 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 02 May 2011 14:36:56 -0700 (PDT) Received-SPF: pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.182.137 as permitted sender) client-ip=32.97.182.137; Authentication-Results: mx.google.com; spf=pass (google.com: domain of paulmck@linux.vnet.ibm.com designates 32.97.182.137 as permitted sender) smtp.mail=paulmck@linux.vnet.ibm.com Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e7.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p42LEHmN011264; Mon, 2 May 2011 17:14:17 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p42Latsr107136; Mon, 2 May 2011 17:36:55 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p42LaooG001533; Mon, 2 May 2011 17:36:55 -0400 Received: from paulmck-ThinkPad-W500 (sig-9-65-212-103.mts.ibm.com [9.65.212.103]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p42LakoI001343; Mon, 2 May 2011 17:36:48 -0400 Received: by paulmck-ThinkPad-W500 (Postfix, from userid 1000) id ED70713F7FD; Mon, 2 May 2011 09:15:46 -0700 (PDT) Date: Mon, 2 May 2011 09:15:46 -0700 From: "Paul E. McKenney" To: Josh Triplett Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, patches@linaro.org, "Paul E. McKenney" Subject: Re: [PATCH tip/core/rcu 10/86] rcu: eliminate unused boosting statistics Message-ID: <20110502161546.GA6524@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20110501132142.GA25494@linux.vnet.ibm.com> <1304256126-26015-10-git-send-email-paulmck@linux.vnet.ibm.com> <20110501155317.GG14829@feather> <20110502082555.GV2297@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110502082555.GV2297@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) On Mon, May 02, 2011 at 01:25:55AM -0700, Paul E. McKenney wrote: > On Sun, May 01, 2011 at 08:53:18AM -0700, Josh Triplett wrote: > > On Sun, May 01, 2011 at 06:20:50AM -0700, Paul E. McKenney wrote: > > > From: Paul E. McKenney > > > > > > The n_rcu_torture_boost_allocerror and n_rcu_torture_boost_afferror > > > statistics are not actually incremented anymore, so eliminate them. > > > > > > Signed-off-by: Paul E. McKenney > > > Signed-off-by: Paul E. McKenney > > > --- > > > kernel/rcutorture.c | 4 +--- > > > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > > > diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c > > > index 4d256db..62ec8ee6 100644 > > > --- a/kernel/rcutorture.c > > > +++ b/kernel/rcutorture.c > > > @@ -1067,7 +1067,7 @@ rcu_torture_printk(char *page) > > > cnt += sprintf(&page[cnt], "%s%s ", torture_type, TORTURE_FLAG); > > > cnt += sprintf(&page[cnt], > > > "rtc: %p ver: %ld tfle: %d rta: %d rtaf: %d rtf: %d " > > > - "rtmbe: %d rtbke: %ld rtbre: %ld rtbae: %ld rtbafe: %ld " > > > + "rtmbe: %d rtbke: %ld rtbre: %ld " > > > "rtbf: %ld rtb: %ld nt: %ld", > > > rcu_torture_current, > > > rcu_torture_current_version, > > > @@ -1078,8 +1078,6 @@ rcu_torture_printk(char *page) > > > atomic_read(&n_rcu_torture_mberror), > > > n_rcu_torture_boost_ktrerror, > > > n_rcu_torture_boost_rterror, > > > - n_rcu_torture_boost_allocerror, > > > - n_rcu_torture_boost_afferror, > > > n_rcu_torture_boost_failure, > > > n_rcu_torture_boosts, > > > n_rcu_torture_timers); > > > > Shouldn't you eliminate the variables entirely, if they no longer track > > anything? > > I most certainly should!!! Good catch!!! And here is the updated commit. Thanx, Paul ------------------------------------------------------------------------ rcu: eliminate unused boosting statistics The n_rcu_torture_boost_allocerror and n_rcu_torture_boost_afferror statistics are not actually incremented anymore, so eliminate them. Signed-off-by: Paul E. McKenney Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c index 4d256db..22b0e74 100644 --- a/kernel/rcutorture.c +++ b/kernel/rcutorture.c @@ -146,8 +146,6 @@ static atomic_t n_rcu_torture_mberror; static atomic_t n_rcu_torture_error; static long n_rcu_torture_boost_ktrerror; static long n_rcu_torture_boost_rterror; -static long n_rcu_torture_boost_allocerror; -static long n_rcu_torture_boost_afferror; static long n_rcu_torture_boost_failure; static long n_rcu_torture_boosts; static long n_rcu_torture_timers; @@ -1067,7 +1065,7 @@ rcu_torture_printk(char *page) cnt += sprintf(&page[cnt], "%s%s ", torture_type, TORTURE_FLAG); cnt += sprintf(&page[cnt], "rtc: %p ver: %ld tfle: %d rta: %d rtaf: %d rtf: %d " - "rtmbe: %d rtbke: %ld rtbre: %ld rtbae: %ld rtbafe: %ld " + "rtmbe: %d rtbke: %ld rtbre: %ld " "rtbf: %ld rtb: %ld nt: %ld", rcu_torture_current, rcu_torture_current_version, @@ -1078,16 +1076,12 @@ rcu_torture_printk(char *page) atomic_read(&n_rcu_torture_mberror), n_rcu_torture_boost_ktrerror, n_rcu_torture_boost_rterror, - n_rcu_torture_boost_allocerror, - n_rcu_torture_boost_afferror, n_rcu_torture_boost_failure, n_rcu_torture_boosts, n_rcu_torture_timers); if (atomic_read(&n_rcu_torture_mberror) != 0 || n_rcu_torture_boost_ktrerror != 0 || n_rcu_torture_boost_rterror != 0 || - n_rcu_torture_boost_allocerror != 0 || - n_rcu_torture_boost_afferror != 0 || n_rcu_torture_boost_failure != 0) cnt += sprintf(&page[cnt], " !!!"); cnt += sprintf(&page[cnt], "\n%s%s ", torture_type, TORTURE_FLAG); @@ -1486,8 +1480,6 @@ rcu_torture_init(void) atomic_set(&n_rcu_torture_error, 0); n_rcu_torture_boost_ktrerror = 0; n_rcu_torture_boost_rterror = 0; - n_rcu_torture_boost_allocerror = 0; - n_rcu_torture_boost_afferror = 0; n_rcu_torture_boost_failure = 0; n_rcu_torture_boosts = 0; for (i = 0; i < RCU_TORTURE_PIPE_LEN + 1; i++)