From patchwork Tue Sep 4 23:08:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Triplett X-Patchwork-Id: 11177 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 6053C23F26 for ; Tue, 4 Sep 2012 23:08:55 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 901FEA18314 for ; Tue, 4 Sep 2012 23:08:03 +0000 (UTC) Received: by mail-iy0-f180.google.com with SMTP id j25so9273929iaf.11 for ; Tue, 04 Sep 2012 16:08:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf :x-originating-ip:x-virus-scanned:x-originating-ip:date:from:to:cc :subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent:x-gm-message-state; bh=HrLFaNS1PZ/KDUu5bwmMEK2XvkbNKzr/KtaTDc3JrFw=; b=U8VB7/rKffJ32InylWkvC1uuOR+VcD5+cHhpj/ngkVgLdA475KHKen2TT+lK2S/jxf juwAIsKuZMUpDAQiXNPI3uA4Iyl9j6SqgR6Pl+uGqufKRoRwCBnI2Mb8o488mbqci8PW sqFIhUZPI6wtD4sLxRFWPZlz0ae5u2001COI8XvNPVb/Ry3C8Ykx6/yEXsVBdQbmLQCn HT6Fb2KcWPeKGCp3WvWMpmfNjT4KSFoIOhc734xZyQGHZFKnvcoVmswHxyIJBQ2nDogJ uksGMOKGXSFG/Ge/KFDxvSYOlo17G9xu9LbJ13UiIOlG0SujOIR4HmC1BrVJiZ2KXWGd 3ujA== Received: by 10.50.237.41 with SMTP id uz9mr15762193igc.43.1346800134758; Tue, 04 Sep 2012 16:08:54 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp219234igc; Tue, 4 Sep 2012 16:08:53 -0700 (PDT) Received: by 10.52.99.135 with SMTP id eq7mr12903105vdb.8.1346800133476; Tue, 04 Sep 2012 16:08:53 -0700 (PDT) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net. [217.70.183.196]) by mx.google.com with ESMTP id dy10si11368032vdb.116.2012.09.04.16.08.52; Tue, 04 Sep 2012 16:08:53 -0700 (PDT) Received-SPF: neutral (google.com: 217.70.183.196 is neither permitted nor denied by best guess record for domain of josh@joshtriplett.org) client-ip=217.70.183.196; Authentication-Results: mx.google.com; spf=neutral (google.com: 217.70.183.196 is neither permitted nor denied by best guess record for domain of josh@joshtriplett.org) smtp.mail=josh@joshtriplett.org X-Originating-IP: 217.70.178.134 Received: from mfilter4-d.gandi.net (mfilter4-d.gandi.net [217.70.178.134]) by relay4-d.mail.gandi.net (Postfix) with ESMTP id 852841720A6; Wed, 5 Sep 2012 01:08:42 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter4-d.gandi.net Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by mfilter4-d.gandi.net (mfilter4-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id yzGlvgZK8y7s; Wed, 5 Sep 2012 01:08:41 +0200 (CEST) X-Originating-IP: 173.246.103.110 Received: from jtriplet-mobl1 (joshtriplett.org [173.246.103.110]) (Authenticated sender: josh@joshtriplett.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id DBDFB172087; Wed, 5 Sep 2012 01:08:36 +0200 (CEST) Date: Tue, 4 Sep 2012 16:08:34 -0700 From: Josh Triplett To: Steven Rostedt Cc: paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, patches@linaro.org, "Paul E. McKenney" Subject: Re: [PATCH tip/core/rcu 04/15] rcu: Permit RCU_NONIDLE() to be used from interrupt context Message-ID: <20120904230834.GB11494@jtriplet-mobl1> References: <20120830185607.GA32148@linux.vnet.ibm.com> <1346352988-32444-1-git-send-email-paulmck@linux.vnet.ibm.com> <1346352988-32444-4-git-send-email-paulmck@linux.vnet.ibm.com> <20120831180052.GB4259@jtriplet-mobl1> <20120904223350.GQ2593@linux.vnet.ibm.com> <1346799082.27919.31.camel@gandalf.local.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1346799082.27919.31.camel@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQkWvVbwff63Z4ucFUgog6TjFyynvJ7TTj/KqPETLWD7fT6OBqWcTJ70hgev75QP0KHmoOW9 On Tue, Sep 04, 2012 at 06:51:22PM -0400, Steven Rostedt wrote: > On Tue, 2012-09-04 at 15:33 -0700, Paul E. McKenney wrote: > > On Fri, Aug 31, 2012 at 11:00:52AM -0700, Josh Triplett wrote: > > > On Thu, Aug 30, 2012 at 11:56:17AM -0700, Paul E. McKenney wrote: > > > > From: "Paul E. McKenney" > > > > > > > > There is a need to use RCU from interrupt context, but either before > > > > rcu_irq_enter() is called or after rcu_irq_exit() is called. If the > > > > interrupt occurs from idle, then lockdep-RCU will complain about such > > > > uses, as they appear to be illegal uses of RCU from the idle loop. > > > > In other environments, RCU_NONIDLE() could be used to properly protect > > > > the use of RCU, but RCU_NONIDLE() currently cannot be invoked except > > > > from process context. > > > > > > > > This commit therefore modifies RCU_NONIDLE() to permit its use more > > > > globally. > > > > > > > > Reported-by: Steven Rostedt > > > > Signed-off-by: Paul E. McKenney > > > > Signed-off-by: Paul E. McKenney > > > > > > Something seems wrong about this. The addition of EXPORT_SYMBOL_GPL > > > suggests that such interrupt handlers might live in modules. In what > > > situation might a module interrupt handler get called from the idle > > > loop, before rcu_irq_enter or after rcu_irq_exit, and need to know that > > > when using RCU? > > > > Drivers can be in modules, in which case their interrupt handlers will > > also be in the corresponding module. I do agree that in most cases, > > the irq_enter() and irq_exit() hooks would be invoked by non-module code, > > but I do believe that I had to add those exports due to build failures. > > > > Steven will let me know if I am confused on this point. > > > > You're not confused, the situation is confusing :-/ > > Because some trace events happen inside the idle loop after rcu has > "shutdown", we needed to create "trace_foo_rcuidle()" handlers that can > handle this condition. That is, for every trace_foo() static inline > (used at the tracepoint location), there exists a static inline > trace_foo_rcuidle(), that looks something like this: > > static inline void trace_##name##_rcuidle(proto) { > if (static_key_false(&__tracepoint_##name.key)) { > rcu_idle_exit(); > __DO_TRACE(); > rcu_idle_enter(); > } > } > > Although these calls are never used by module code, because they are > static inlines, they are still defined for all tracepoints, kernel > tracepoints as well as module tracepoints. And thus, need the export :-( Fair enough. What about having the tracepoint code generation detect when building as part of a module via defined(MODULE), and omit the unused _rcuidle versions in those cases? That would avoid the need to export those functions at all. Strawman patch (not tested): If that doesn't work out, please consider adding an explicit comment saying why you exported the functions. - Josh Triplett diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h index 802de56..41e1ef2 100644 --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -136,6 +136,22 @@ static inline void tracepoint_synchronize_unregister(void) postrcu; \ } while (0) +#ifdef MODULE +#define __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args) \ + static inline void trace_##name##_rcuidle(proto) \ + { \ + if (static_key_false(&__tracepoint_##name.key)) \ + __DO_TRACE(&__tracepoint_##name, \ + TP_PROTO(data_proto), \ + TP_ARGS(data_args), \ + TP_CONDITION(cond), \ + rcu_idle_exit(), \ + rcu_idle_enter()); \ + } +#else +#define __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args) +#endif + /* * Make sure the alignment of the structure in the __tracepoints section will * not add unwanted padding between the beginning of the section and the @@ -151,16 +167,7 @@ static inline void tracepoint_synchronize_unregister(void) TP_ARGS(data_args), \ TP_CONDITION(cond),,); \ } \ - static inline void trace_##name##_rcuidle(proto) \ - { \ - if (static_key_false(&__tracepoint_##name.key)) \ - __DO_TRACE(&__tracepoint_##name, \ - TP_PROTO(data_proto), \ - TP_ARGS(data_args), \ - TP_CONDITION(cond), \ - rcu_idle_exit(), \ - rcu_idle_enter()); \ - } \ + __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args) \ static inline int \ register_trace_##name(void (*probe)(data_proto), void *data) \ { \