From patchwork Tue Jul 29 08:33:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 34455 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f72.google.com (mail-pa0-f72.google.com [209.85.220.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 08BC7202E4 for ; Tue, 29 Jul 2014 08:33:38 +0000 (UTC) Received: by mail-pa0-f72.google.com with SMTP id eu11sf59967831pac.7 for ; Tue, 29 Jul 2014 01:33:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:in-reply-to:user-agent:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type:content-disposition; bh=pk3aAs/S9WMQ+bh30Y+R5+En6l3iN1DNyiDo1eBYVCo=; b=VOlmRl+Ev9qHiKJ99SypFzRRMTcj9TijGJ5mXkC2ZrNiYROTJ8FPcYGDSFlGMpnQ59 53VrVGbVjCcFWGCBMm6hkduAu0sKr/tC2egVNNEo/C5vHy2Bmil4UV+M/awAnnYRlCka 3KkBPha+2hXqn/HDLX/qmi4YP1my7okkTeqF7z49BpvgKc2Y1qXAdWPuErV4R6hC8Gpc ATapWKdJqCf4rvXBwkPZluaDLgd/7kpRj6QJd4nrzzH996oeLr5IqenYDpv7vzloVJw6 ucSRHMQAXSoETWHNMjhsNu6xPjq9q1P6zBmXX1A+rOKvkHAaf2hXEaxq+vN/TrAoPIhn M1Yw== X-Gm-Message-State: ALoCoQn3n/04oH3zVZE0XrW+9o7fhKs7Cw8hV2y3GHMOyZHqks/Ir0C8DVZbc+U0lL7HbYYefYRQ X-Received: by 10.66.163.41 with SMTP id yf9mr215207pab.36.1406622818320; Tue, 29 Jul 2014 01:33:38 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.84.239 with SMTP id l102ls32966qgd.81.gmail; Tue, 29 Jul 2014 01:33:38 -0700 (PDT) X-Received: by 10.220.114.140 with SMTP id e12mr297747vcq.37.1406622818196; Tue, 29 Jul 2014 01:33:38 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id li13si7349522vdb.94.2014.07.29.01.33.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 29 Jul 2014 01:33:38 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.174 as permitted sender) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id la4so13105386vcb.19 for ; Tue, 29 Jul 2014 01:33:38 -0700 (PDT) X-Received: by 10.221.42.135 with SMTP id ty7mr391495vcb.14.1406622818097; Tue, 29 Jul 2014 01:33:38 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp227651vcb; Tue, 29 Jul 2014 01:33:37 -0700 (PDT) X-Received: by 10.70.53.232 with SMTP id e8mr606273pdp.30.1406622817226; Tue, 29 Jul 2014 01:33:37 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id on4si20329538pbc.158.2014.07.29.01.33.36 for ; Tue, 29 Jul 2014 01:33:37 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752954AbaG2Ide (ORCPT + 26 others); Tue, 29 Jul 2014 04:33:34 -0400 Received: from mail-ie0-f170.google.com ([209.85.223.170]:56646 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbaG2Idb (ORCPT ); Tue, 29 Jul 2014 04:33:31 -0400 Received: by mail-ie0-f170.google.com with SMTP id rl12so8368509iec.1 for ; Tue, 29 Jul 2014 01:33:30 -0700 (PDT) X-Received: by 10.50.6.36 with SMTP id x4mr29097220igx.47.1406622810521; Tue, 29 Jul 2014 01:33:30 -0700 (PDT) Received: from lee--X1 (host109-148-232-149.range109-148.btcentralplus.com. [109.148.232.149]) by mx.google.com with ESMTPSA id qd8sm8385474igb.1.2014.07.29.01.33.28 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 29 Jul 2014 01:33:29 -0700 (PDT) Date: Tue, 29 Jul 2014 09:33:25 +0100 From: Lee Jones To: Michael Welling Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, rogerq@ti.com, gregkh@linuxfoundation.org, stern@rowland.harvard.edu, balbi@ti.com, stable@vger.kernel.org Subject: [PATCH] mfd: omap-usb-host: Fix improper mask use Message-ID: <20140729083325.GA9030@lee--X1> References: <1406588464-19104-1-git-send-email-mwelling@emacinc.com> MIME-Version: 1.0 In-Reply-To: <1406588464-19104-1-git-send-email-mwelling@emacinc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.174 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-Disposition: inline single-ulpi-bypass is a flag used for older OMAP3 silicon. The flag when set, can excite code that improperly uses the OMAP_UHH_HOSTCONFIG_UPLI_BYPASS define to clear the corresponding bit. Instead it clears all of the other bits disabling all of the ports in the process. Signed-off-by: Michael Welling --- --> Applied, thanks. <-- drivers/mfd/omap-usb-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index b48d80c..33a9234 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -445,7 +445,7 @@ static unsigned omap_usbhs_rev1_hostconfig(struct usbhs_hcd_omap *omap, for (i = 0; i < omap->nports; i++) { if (is_ehci_phy_mode(pdata->port_mode[i])) { - reg &= OMAP_UHH_HOSTCONFIG_ULPI_BYPASS; + reg &= ~OMAP_UHH_HOSTCONFIG_ULPI_BYPASS; break; } }