From patchwork Mon Sep 8 06:13:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Turquette X-Patchwork-Id: 36945 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f198.google.com (mail-ob0-f198.google.com [209.85.214.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id ED9592054D for ; Mon, 8 Sep 2014 08:30:58 +0000 (UTC) Received: by mail-ob0-f198.google.com with SMTP id wp18sf74600431obc.5 for ; Mon, 08 Sep 2014 01:30:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:mime-version:to:from :in-reply-to:references:message-id:user-agent:date:cc:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=OmG2PNRKQzFHwhMahQvDfFH9sAvgOm99LymUysNalYw=; b=Lc3HQf7VqFxxB6WrQodQSh7YTSenDwGmxuN6cJQifjs2qFeuoGj6BxaUqb4M2Y58MR f8LrnNRp8mKuQdwHCGQv016xPLPBKOZ1+vB95aKa4IFWcYpVEBLIMfZeQOuA1Yzq3C7u RXmhtogs9BoXLyyfPPHlNrRKzwM7D4vEsKP27ZttVj/m0TB5+tt3fHMnAbSJZ/knVwJb XgbboQuNtQeNrev2R98bz+IT8wwWuKo2EmGYKq+vlpuet3VNj3Die1UYOremzR91roa7 zdmw31ow9vZEw8VwVS7h69IYWyz6w0Ubso2gkJ+T2xG9h5irK970YraFIeAOiNCc8T2k PzJA== X-Gm-Message-State: ALoCoQmQF1zuTelgItMkEkVlkYhTG0uFs4eIWQujyfBsvqE7ioLRuPj8j3fJK9QACYN3ht42FWT/ X-Received: by 10.42.152.201 with SMTP id j9mr17277901icw.5.1410165058537; Mon, 08 Sep 2014 01:30:58 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.87.6 with SMTP id q6ls1760945qgd.82.gmail; Mon, 08 Sep 2014 01:30:58 -0700 (PDT) X-Received: by 10.220.113.148 with SMTP id a20mr9305118vcq.30.1410165058399; Mon, 08 Sep 2014 01:30:58 -0700 (PDT) Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176]) by mx.google.com with ESMTPS id sm14si4223767vdb.78.2014.09.08.01.30.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 08 Sep 2014 01:30:58 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.176 as permitted sender) client-ip=209.85.220.176; Received: by mail-vc0-f176.google.com with SMTP id ik5so14960683vcb.35 for ; Mon, 08 Sep 2014 01:30:58 -0700 (PDT) X-Received: by 10.221.6.201 with SMTP id ol9mr24175892vcb.2.1410165058327; Mon, 08 Sep 2014 01:30:58 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp99128vcb; Mon, 8 Sep 2014 01:30:57 -0700 (PDT) X-Received: by 10.112.172.74 with SMTP id ba10mr19707300lbc.69.1410165056459; Mon, 08 Sep 2014 01:30:56 -0700 (PDT) Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id oe10si7013423lbb.34.2014.09.08.01.30.55 for ; Mon, 08 Sep 2014 01:30:56 -0700 (PDT) Received-SPF: none (google.com: alsa-devel-bounces@alsa-project.org does not designate permitted sender hosts) client-ip=77.48.224.243; Received: by alsa0.perex.cz (Postfix, from userid 1000) id C6B11261ACA; Mon, 8 Sep 2014 10:30:54 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled version=3.2.4 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 5C1BA2619E3; Mon, 8 Sep 2014 10:30:22 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0946D261785; Mon, 8 Sep 2014 08:14:20 +0200 (CEST) Received: from mail-pd0-f173.google.com (mail-pd0-f173.google.com [209.85.192.173]) by alsa0.perex.cz (Postfix) with ESMTP id ADAD626168C for ; Mon, 8 Sep 2014 08:14:11 +0200 (CEST) Received: by mail-pd0-f173.google.com with SMTP id ft15so4017537pdb.4 for ; Sun, 07 Sep 2014 23:14:09 -0700 (PDT) X-Received: by 10.70.131.12 with SMTP id oi12mr44520083pdb.116.1410156849660; Sun, 07 Sep 2014 23:14:09 -0700 (PDT) Received: from localhost (pool-108-47-66-231.lsanca.fios.verizon.net. [108.47.66.231]) by mx.google.com with ESMTPSA id j13sm7837384pbq.42.2014.09.07.23.14.08 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 07 Sep 2014 23:14:08 -0700 (PDT) MIME-Version: 1.0 To: Tomeu Vizoso , From: Mike Turquette In-Reply-To: <1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com> References: <1409758148-20104-2-git-send-email-tomeu.vizoso@collabora.com> <1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com> Message-ID: <20140908061355.19023.47997@quantum> User-Agent: alot/0.3.5 Date: Sun, 07 Sep 2014 23:13:55 -0700 X-Mailman-Approved-At: Mon, 08 Sep 2014 10:30:21 +0200 Cc: Ulf Hansson , Prashant Gaikwad , "Stephen Warren , Thierry Reding , tomasz.figa@gmail.com, Peter De Schrijver , rabin@rab.in, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Russell King , Shawn Guo , Sascha Hauer , David Brown , Daniel Walker , Bryan Huntsman , Paul Walmsley , Tony Lindgren , =?utf-8?q?=22_Beno=C3=AEt_Cousson?= , Kevin Hilman" , Benjamin Herrenschmidt , alsa-devel@alsa-project.org, Paul Mackerras , Sylwester Nawrocki , linux-arch@vger.kernel.org, Boris Brezillon , Kukjin Kim , =?utf-8?b?IiBFbWlsaW8gTMOzcGV6?= , patches@opensource.wolfsonmicro.com, Michal Simek , Takashi Iwai , Santosh Shilimkar , Anatolij Gustschin , Dinh Nguyen , linux-media@vger.kernel.org, Arnd Bergmann , linux-arm-msm@vger.kernel.org, spear-devel@list.st.com, Mark Brown , linux-rpi-kernel@lists.infradead.org, Ben Dooks , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Barry Song , Tomeu Vizoso , Liam Girdwood , Kyungmin Park , Viresh Kumar , Maxime Ripard , linuxppc-dev@lists.ozlabs.org, Mauro Carvalho Chehab Subject: Re: [alsa-devel] [PATCH v9 2/6] clk: Move all drivers to use internal API X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mturquette@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.176 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Quoting Tomeu Vizoso (2014-09-03 08:31:57) > In preparation to change the public API to return a per-user clk structure, > remove any usage of this public API from the clock implementations. > > The reason for having this in a separate commit from the one that introduces > the implementation of the new functions is to separate the changes generated > with Coccinelle from the rest, and keep the patches' size reasonable. > > Signed-off-by: Tomeu Vizoso > Tested-by: Boris Brezillon > Tested-by: Heiko Stuebner > Acked-by: Boris Brezillon Hi Tomeu, Looks like the Coccinelle script had a false-positive. asm-generic/clkdev.h was converted from clk->clk_core and this blowed up clock drivers for architectures that don't provide an asm-specific clkdev.h implementation. This fixes x86's LPSS and a Microblaze driver. I've rolled the following fix into your 2/9 patch. No action is necessary. Regards, Mike diff --git a/include/asm-generic/clkdev.h b/include/asm-generic/clkdev.h index 4320225..90a32a6 100644 --- a/include/asm-generic/clkdev.h +++ b/include/asm-generic/clkdev.h @@ -15,10 +15,10 @@ #include -struct clk_core; +struct clk; -static inline int __clk_get(struct clk_core *clk) { return 1; } -static inline void __clk_put(struct clk_core *clk) { } +static inline int __clk_get(struct clk *clk) { return 1; } +static inline void __clk_put(struct clk *clk) { } static inline struct clk_lookup_alloc *__clkdev_alloc(size_t size) {