From patchwork Fri Jun 17 16:06:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102147 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp357866qgy; Fri, 17 Jun 2016 09:05:22 -0700 (PDT) X-Received: by 10.98.131.206 with SMTP id h197mr3106604pfe.124.1466179522815; Fri, 17 Jun 2016 09:05:22 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xu8si18361752pac.159.2016.06.17.09.05.22; Fri, 17 Jun 2016 09:05:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755740AbcFQQFM (ORCPT + 30 others); Fri, 17 Jun 2016 12:05:12 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:50743 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754191AbcFQQFK (ORCPT ); Fri, 17 Jun 2016 12:05:10 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue003) with ESMTPA (Nemesis) id 0LtRzc-1bLsGE4Aiq-010vw0; Fri, 17 Jun 2016 18:04:59 +0200 From: Arnd Bergmann To: Ian Abbott , H Hartley Sweeten , Greg Kroah-Hartman , Leslie Klein Cc: y2038@lists.linaro.org, Arnd Bergmann , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: comedi: avoid using timeval Date: Fri, 17 Jun 2016 18:06:24 +0200 Message-Id: <20160617160645.1166989-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:H9sN6+8G+ERqySugzuFh5vFNdkXb2AFRNHRtsDFenwAbmWP83ve fIHOZ8pbfb7qzTE+LTWV+KHKIGscqu8GeECXD/F0r6yExUIatoNQHs2z1BY1WCKjO7ZZiAc ZwsTEsdL8zYYPktNJNWSdS2/MFx9JN9CE7Rp6rn10SECbsiw934mLwCoZr2FhTGh+ZU1n6f ncbMOezKkRe6nGQnwZSNQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:HtRTSV3Lmxs=:uW15gZ4DoHx2HFvEi18kTU ImDKs8t7dyY7mo9Y6E6QoNuYBBSZTdIG6937YDghSq/08DKyUSYZ7hmyloajeChjZEG30DxnB /ypOhMbHZDfQvukiaIhWcXEBfO3/HC4h4122nxdAov2IQXj7yEMJvyubPBKuj1c8hWUErA91n lma8klcWImNduxGyNTNo2y9ExlTguf3Kcis7+zrEEcxy2O94tWenLAe4fCFsKXOdBjmzB1ert 4AWFxxSsVlT7Js7j7Tkqq6WgO+dywvpL5T96sRNycNTRE/iWSKQqfq2hmBpjWbKIlu5IdWUqe zv654MDrKnHa3CT44dCV31Xk+iNh+9r5zuO5wmvhV7TzSHFm1i8TteLg8SHQSqc+zrwEdXV1G IycBa1sKbU+qjAI3RwYbk40P6nDaGAKNBtpJkaQZ+GnKzRWB0XvBgvnIo9MohOWqHcLJyincP MKGMtwMM5TY1KnlfmYIF0MnC/D49PyPEujO/7khVf0M1cIpfMnjE8stFqGWm98F8xWVuWY0oJ jWv4az0NZGjWJ3tuNfVA/fkpvsuLxIxYHYfuwBaEVuILi2CLJZY9ybaRX0GIQZhNQYLGEErdn 6rWQiyc5Agy1F70JK3c4IHyurVaGrDFP73+cjiYFr0vrZD1sADdI6jXW7fExLTvfaHSvmajPQ kGA6smdjx90nRRqZOEMOLRQiV5zswd1GGm1RuS20I0KKe/ufUBijzv2GFdZgsPA8Scc8= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It depends on user space whether this is safe or not: if programs interpret the data as a signed time_t value, they will be broken in y2038, and we have to redesign the entire interface. Signed-off-by: Arnd Bergmann --- drivers/staging/comedi/comedi_fops.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.9.0 diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 629080f39db0..fe50d1f823c6 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -1256,16 +1256,17 @@ static int parse_insn(struct comedi_device *dev, struct comedi_insn *insn, switch (insn->insn) { case INSN_GTOD: { - struct timeval tv; + struct timespec64 tv; if (insn->n != 2) { ret = -EINVAL; break; } - do_gettimeofday(&tv); + ktime_get_real_ts64(&tv); data[0] = tv.tv_sec; - data[1] = tv.tv_usec; + /* unsigned data safe until 2106 */ + data[1] = tv.tv_nsec / NSEC_PER_USEC; ret = 2; break;