From patchwork Fri Jun 24 07:30:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102103 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp807878qgy; Fri, 24 Jun 2016 00:28:55 -0700 (PDT) X-Received: by 10.66.232.226 with SMTP id tr2mr5019091pac.44.1466753335338; Fri, 24 Jun 2016 00:28:55 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id to3si5223459pac.1.2016.06.24.00.28.55; Fri, 24 Jun 2016 00:28:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509AbcFXH2n (ORCPT + 30 others); Fri, 24 Jun 2016 03:28:43 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:63104 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbcFXH2m (ORCPT ); Fri, 24 Jun 2016 03:28:42 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue104) with ESMTPA (Nemesis) id 0LfSYr-1bj4aK2477-00p3vF; Fri, 24 Jun 2016 09:28:29 +0200 From: Arnd Bergmann To: Felipe Balbi Cc: Arnd Bergmann , John Youn , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] USB: dwc2-usb: add USB_GADGET dependency Date: Fri, 24 Jun 2016 09:30:26 +0200 Message-Id: <20160624073039.3343293-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:bW286WLADOx1opGXjMvIp2JPZakTajYNEY2rcbMg/2AUMFtOPNI aLDcbxjTDG5kuT7sW5gpzsKJzpFeQLn17fOIREaVswylUoQOZQS5pmrJVsSTG7bAOpCy+xz o1hzylUsfq8WTPF6cpjnsh3kSWLdria8KYqTmiXIf9rKr2JYzh9d4K3E5nacA7fM2Rp9k11 60Rew97NPpJ3ALleYssvQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:zqL6fLy/5SQ=:RG5vaZCap+ZtxdOl4FEZYK 6sZpZXtXz0Zw3PFusnvz2H03a2bTROXT7VdKT6fm8vkpuq+2mAkeIpX5LpGSWOf+QeedWVEtB BOeNALjCkoDXRSkM7JAFZbz9QZUgZ5GI2x6M0E4jbnjxsCzmO6NQudQ0WvqZJNYow1IT6LUtw IxDUD1YA3RsrQ10UYxr36M37iTpGyEBHukcfKhLXzdUTRQYqNo5OqbNVtG2hT9dmvV00UfIEm lK81ZdskeOa5MCddj+TmTNAz40FbKOHSm2Oe8WvCc28mJtZr8jJMCxqwn31sZN+E5tPqolK41 hjJePaj0FRhWACSgfSZBB9ABzozzjeTbdkE4OTSdwEFDbuMlw4GeuLafNszCKbIj0MPEWoRl0 O7QAvTYR7gLUZiFNNlv1eyQKRP5LNRgFTuTxfAI3o+f9KZo7jQ3TvJXhcFhVgFZzkA89UF34x +YKB/UryPK99KvMhrHkN91R03War752WNQa9Yq+Xs7SYEzfjOCtu7tWJtit4QWZzGr0MFFT+G ZcbTRnPAwooCzfTwT3pqqWv4Oa+9l3EHcduW7VvsjbsWM9wLt2zfavueXBvIHrDfnqQlJfi2o B3aEL4me0QABBmqiIZpN+TBqkkPWuNwjLPDnxnMxA260RdaSzlvMM+i40WXMvGY6WzGt7XB3H ifoSwvdRLuLAWJhgv8xpTVTS5Q5z7wNmx79Ewk9esYHAkqGCAkDJfYzxsKjc8pUxs30s= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver selects NOP_USB_XCEIV, which can only be built-in if USB_GADGET is either disabled or also built-in, so with USB_DWC2_PCI=y and USB_GADGET=m, NOP_USB_XCEIV is also built-in and we get this link error: drivers/usb/built-in.o: In function `nop_set_peripheral': (text+0x1927c): undefined reference to `usb_gadget_vbus_connect' drivers/usb/built-in.o: In function `nop_gpio_vbus_thread': (text+0x197a0): undefined reference to `usb_gadget_vbus_connect' (text+0x19830): undefined reference to `usb_gadget_vbus_disconnect' This adds the same dependency for the dwc2 driver to avoid that broken configuration. Signed-off-by: Arnd Bergmann --- drivers/usb/dwc2/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig index c1f29caa8990..e838701d6dd5 100644 --- a/drivers/usb/dwc2/Kconfig +++ b/drivers/usb/dwc2/Kconfig @@ -55,6 +55,7 @@ endchoice config USB_DWC2_PCI tristate "DWC2 PCI" depends on PCI + depends on USB_GADGET || !USB_GADGET default n select NOP_USB_XCEIV help