From patchwork Mon Jul 4 15:07:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102049 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp1595287qgy; Mon, 4 Jul 2016 08:05:14 -0700 (PDT) X-Received: by 10.98.3.3 with SMTP id 3mr23724047pfd.8.1467644714119; Mon, 04 Jul 2016 08:05:14 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u88si4690917pfa.1.2016.07.04.08.05.13; Mon, 04 Jul 2016 08:05:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754220AbcGDPFL (ORCPT + 30 others); Mon, 4 Jul 2016 11:05:11 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:54197 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750900AbcGDPFG (ORCPT ); Mon, 4 Jul 2016 11:05:06 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue104) with ESMTPA (Nemesis) id 0MVuWW-1amxaS1YCG-00X7fn; Mon, 04 Jul 2016 17:04:56 +0200 From: Arnd Bergmann To: Jaroslav Kysela , Takashi Iwai Cc: Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning Date: Mon, 4 Jul 2016 17:07:45 +0200 Message-Id: <20160704150759.2909708-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:WNKdiQ1GFLlU2oWc487MnzjCl+znJ7YuJSMf5nHrTN9Et0BISLX hBM+q3pmnS1CYvH45J3yFiNI3HHt8CV0LS296QRTbPZp7mQq/4wG77RpP2XEKgsa3hdIja+ yQpUrxYpQbxkc6uIwHEn2BSRXFIIHy7qasRmMp0I++0tn6ycx0Uwaywsg11Xu4tLsNQtVS7 rtePQ8ILDTNO+WWIYCutw== X-UI-Out-Filterresults: notjunk:1; V01:K0:oSMn1LzJiXs=:S24F+ILpNhFaYbK4gdqdB4 YeF53Pq/BX/mkpStSaEgf8XyVtTmzxd834zlYsCFjmFg9PCgP9AinOvYOWCJKjSSqI60miHc/ 0+HpjUul6gmuYYpgazHmJOF/xlNQIYu464jGXrJsjQ9KX8i1/mxY66ewWFTQ2cM6nDws6jOee 5vlRkbDP1qMAgewsA6rsZL/z+ECkBa5/uktZ1m/piSVt+2qzJyPFsg2plIIJaAAoANEgqk82U B/Y50NIRmtVAe79qi60fgIJqKDWy9gTg7LbvRquc5ZYCnXp4WxnwYDGcS2QrR2rQTfeR0ka91 UvzAGTymoZcWaBzDW89DqyhrnFuLpHvR+2tq1oAHlEP1S5i5KotftqLovZVy6UcuSbCkFThKQ +Ms+GW6v2ouWqK7FaDLy5nD8qv6zjRfMplDiMDwYviMY6T+Hb20X3xkRDUZ5yTpqvee8xWKBl PEfNx425+PXduPTO8nd2t5UXJ/ZOOb/EnQ/zQYS6FHoqni5Gw9pFfu9usbG5eKt4pVdNmarf9 qb6OQdnO74pNkN8eE2yDetLcIp7HxfjXf9+JLqG/h4K9AoSgut4nFeQuiT+pVC6zuLOklEtXk 3OiVY0SacI4Sx1evAgi+88G/S7FqBwFSZgwy8OoeWDLwWMxSmVC7wT/uNbrOgf22fd6+uZ6/Z tTHl3CnjgEP27xwmDVKuUwYXIRGkT9vkARcGy7QBRM8xwP9Fh7k2fgcmjgMeJ+AM7Ej8= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The awacs sound driver produces a false-positive warning in ppc64_defconfig: sound/ppc/awacs.c: In function 'snd_pmac_awacs_init': include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized] I haven't come up with a good way to rewrite the code to avoid the warning, so here is a bad one: I initialize the variable before the conditionall initialization so gcc no longer has to worry about it. Signed-off-by: Arnd Bergmann --- sound/ppc/awacs.c | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/sound/ppc/awacs.c b/sound/ppc/awacs.c index 09da7b52bc2e..1468e4b7bf93 100644 --- a/sound/ppc/awacs.c +++ b/sound/ppc/awacs.c @@ -991,6 +991,7 @@ snd_pmac_awacs_init(struct snd_pmac *chip) if (err < 0) return err; } + master_vol = NULL; if (pm7500) err = build_mixers(chip, ARRAY_SIZE(snd_pmac_awacs_mixers_pmac7500),