From patchwork Tue Aug 30 09:55:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 74961 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp2059178qga; Tue, 30 Aug 2016 02:56:13 -0700 (PDT) X-Received: by 10.66.220.194 with SMTP id py2mr4580412pac.77.1472550973209; Tue, 30 Aug 2016 02:56:13 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qp6si44423215pab.258.2016.08.30.02.56.12; Tue, 30 Aug 2016 02:56:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758048AbcH3J4J (ORCPT + 27 others); Tue, 30 Aug 2016 05:56:09 -0400 Received: from foss.arm.com ([217.140.101.70]:35294 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754707AbcH3J4I (ORCPT ); Tue, 30 Aug 2016 05:56:08 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 13AF2349; Tue, 30 Aug 2016 02:56:07 -0700 (PDT) Received: from leverpostej (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C27A73F32C; Tue, 30 Aug 2016 02:56:05 -0700 (PDT) Date: Tue, 30 Aug 2016 10:55:55 +0100 From: Mark Rutland To: Daniel Lezcano Cc: tglx@linutronix.de, mingo@kernel.org, Nicolas Ferre , Olivier Schonken , Alexandre Belloni , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] clocksource/drivers/timer-atmel-pit: Enable mck clock Message-ID: <20160830095555.GB1223@leverpostej> References: <57C05026.7010905@linaro.org> <1472221245-14265-1-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1472221245-14265-1-git-send-email-daniel.lezcano@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Aug 26, 2016 at 04:20:43PM +0200, Daniel Lezcano wrote: > From: Alexandre Belloni > > mck is needed to get the PIT working. Explicitly prepare_enable it instead > of assuming it is enabled. > > This solves an issue where the system is freezing when the ETM/ETB drivers > are enabled. > > Reported-by: Olivier Schonken > Reviewed-by: Boris Brezillon > Acked-by: Nicolas Ferre > Signed-off-by: Alexandre Belloni > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/timer-atmel-pit.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c > index 1ffac0c..3494bc5 100644 > --- a/drivers/clocksource/timer-atmel-pit.c > +++ b/drivers/clocksource/timer-atmel-pit.c > @@ -261,6 +261,12 @@ static int __init at91sam926x_pit_dt_init(struct device_node *node) > return PTR_ERR(data->mck); > } > > + ret = clk_prepare_enable(data->mck); > + if (ret) { > + pr_err("Unable to enable mck\n"); > + return ret; > + } > + Apologies if the below is a duplicate report. When building v4.8-rc4 multi_v7_defconfig, I get: [mark@leverpostej:~/src/linux]% uselinaro 15.08 make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- -j10 -s drivers/clocksource/timer-atmel-pit.c: In function 'at91sam926x_pit_dt_init': drivers/clocksource/timer-atmel-pit.c:264:2: error: 'ret' undeclared (first use in this function) ret = clk_prepare_enable(data->mck); ^ drivers/clocksource/timer-atmel-pit.c:264:2: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [drivers/clocksource/timer-atmel-pit.o] Error 1 make[1]: *** [drivers/clocksource] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 As far as I can see, there's no local 'ret' variable. Locally I've fixed this up with: ----8---- ---->8---- Thanks, Mark. diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c index 3494bc5..7f0f5b2 100644 --- a/drivers/clocksource/timer-atmel-pit.c +++ b/drivers/clocksource/timer-atmel-pit.c @@ -240,6 +240,7 @@ static int __init at91sam926x_pit_common_init(struct pit_data *data) static int __init at91sam926x_pit_dt_init(struct device_node *node) { struct pit_data *data; + int ret; data = kzalloc(sizeof(*data), GFP_KERNEL); if (!data)