From patchwork Tue Sep 6 12:54:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101865 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp532551qgf; Tue, 6 Sep 2016 05:54:58 -0700 (PDT) X-Received: by 10.98.21.131 with SMTP id 125mr71983199pfv.92.1473166498293; Tue, 06 Sep 2016 05:54:58 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a2si35343074pax.223.2016.09.06.05.54.58; Tue, 06 Sep 2016 05:54:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934616AbcIFMyz (ORCPT + 27 others); Tue, 6 Sep 2016 08:54:55 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:64999 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933878AbcIFMyx (ORCPT ); Tue, 6 Sep 2016 08:54:53 -0400 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue001) with ESMTPA (Nemesis) id 0MbXng-1bOcaG2KfM-00ImG7; Tue, 06 Sep 2016 14:54:44 +0200 From: Arnd Bergmann To: Kishon Vijay Abraham I Cc: Hans de Goede , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] usb: phy: add USB_SUPPORT dependency Date: Tue, 6 Sep 2016 14:54:46 +0200 Message-Id: <20160906125516.1551565-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:0PkAqHRHEaIrjz61QDMa9VTm1KXe2QkC85gr+Q/6Yl8eSlO2CCS NgbnbPPSPQ+9cY9oOabJYJpmw7EiaaKrOa4sq+55ZED969g8m+ZDg1WnlZpvOjd1YfW/BrN 1grO96ZCZ+GpjopiQiSsl0vHTVJqZrjOoRXcXh7lFb8PtKAPj73r76PJJVgb53cM3tSSwU4 Mpt+omIw1FEcM7gPa0unw== X-UI-Out-Filterresults: notjunk:1; V01:K0:r8eV/UQ1bmI=:fiu42iMDi6aPDZ4NWkZOuv equLZzNPbBmlW+LOH+tTV4erTex0tvsDW/y9/waxGMp6JtvtT+TAkpSpmQR4o+qVN1NlX8cXM YuwYXOdTCDnHUGTfymgMvqwQCgGahwA6YwY47xVIJwQ3F5li9bHc2JuD+TV3IDVYPrv43dYUH tFVOe8u/nKnO/sQMO83ALw2DbCWTWZNgpwzodlFF38kxN0QYVHouBGArlntTOYeFMP94vA+7T WlRGmOHO9paQxiF86A5qHZJ9HDizcPLb93hwmAcqQxAEgKxWuQ8lynrGRCE8fhgeGD6NpheG7 WOZec8Ai/9JMrFl15f+ilVZzJnp/3au/PV9t8pizjM9tYcznsyxFI7ncA9fRjlqoM7Qcw4NYp 5dLnlM11Q9IeXIf8Yw2+GVl6emW25yOalWf4Dq3Nk2TWFnOM4KmqLskvd++cRTxah3oEx0zx7 jfGNm2MslG7bz7i2kb7oBG2hdkK62mOIIlVcsEsCTHMYRFB3POnu+WI1rxY9wHLCovdz29jJK 33+sy9e7OF9epCp0kXyGiVzYPF2vxLqIX5i0rv5onU9GXK9dnlq9p5jaghpiJP9ss682WJaS1 NjtjLNUN5BQzCayzlYqAK7mgQRALE1jPPkgf58y2P8A3vkfrbiLiZ84v9v6EHNCif8DhNOtxX nn1vm/g5l4MIvCfl03o/eGxisuF/VqM6rGbIm2Tj5uiiC6KnMQKbgtArcVN/Jo5HeUi8= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver now calls of_usb_get_dr_mode_by_phy, which is part of the USB core layer, and it fails to build when that is not provided: drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe': phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to `of_usb_get_dr_mode_by_phy' We already have a couple of other PHY drivers with a dependency on USB_SUPPORT, so that seems to be the easiest fix here. An alternative would be to adjust the #ifdef in include/linux/usb/of.h to also check for CONFIG_USB_SUPPORT. Signed-off-by: Arnd Bergmann Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode") --- drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index c42ddf3c8ed8..985dff8558e5 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -260,6 +260,7 @@ config PHY_SUN4I_USB depends on RESET_CONTROLLER depends on EXTCON depends on POWER_SUPPLY + depends on USB_SUPPORT select GENERIC_PHY help Enable this to support the transceiver that is part of Allwinner