From patchwork Wed Nov 16 15:08:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101512 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp204867qge; Wed, 16 Nov 2016 07:09:24 -0800 (PST) X-Received: by 10.99.43.8 with SMTP id r8mr9274165pgr.83.1479308964250; Wed, 16 Nov 2016 07:09:24 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j190si22673386pgd.278.2016.11.16.07.09.23; Wed, 16 Nov 2016 07:09:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934040AbcKPPJT (ORCPT + 26 others); Wed, 16 Nov 2016 10:09:19 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:57684 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753639AbcKPPJR (ORCPT ); Wed, 16 Nov 2016 10:09:17 -0500 Received: from wuerfel.lan ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0MQBed-1cCEdE20PL-005EXv; Wed, 16 Nov 2016 16:08:59 +0100 From: Arnd Bergmann To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: Xiangliang Yu , Arnd Bergmann , Johannes Thumshirn , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mvsas: fix command_active typo Date: Wed, 16 Nov 2016 16:08:34 +0100 Message-Id: <20161116150855.3083872-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:AvdbvEktoIV5MKO6oh86c/mmyEitdhz7arbgR+4WVmuApLkn65r DPcf35o+LOVJ+m27UWLcHLa08/YWZNzO0O+fI7qY7+KY6rJZS8kExDNre9lr9OFUQJ8jSkv hJaeVN0zYiyA7zH2Hfv6xtQyRAtMN7Z+PIm/dOh67kM84melMxpDElm7XdJ4I0LxAsL2YVn NzxZx7ZeLqHqPmCa66pJQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:zVed16qCn7c=:ca5xIBm2WEZavr8HvHxvem z1BMT1ih73+7O6UwUxJH2No4TxFVCEZsvzA0PuZMC7sOIEF9bIbmhpToUp1aVFtTm6edZufAd DiOimeLz8IsrsaivAl+VDTfzwHrzYVkf6sYv0Nemu3NHqzruTAJQxzm2ID4aq4SG4ZYQAm1px HJuyIqW0sSiCDVa3lSUo8X6OA0CnZjbrIT2PeIt6EZ4sUU+HDWLeTw+JS9X/dmkdOCAhArrdH kdd+CIdZ7nd8uSSpnPuHs1UzNmKkR46aSnT1LF8dtrbuI3qFejbph4lreGR6btrXSfPmnilGM APRJEv5QTIj9prLSYfBb04EPHqW/qO+9cWv50wLegnBu2u0ldXmAhxZ8TChnKOZc3CQDLsxJf V1O3i+49TIXO7vG+hGnvODIhKNDyL/w+ikueYYOw8hKMv25E7pETHEMQ3eZCijLFHeSZepq9b /H9yBXD2VL5EfPOnzD6twzSah7sEz9zyMiMRyxg4X+QrEr1zOFs4ZDFYcGsePABpzBi3P5no5 5EweHneFgU0xGbSd+HA5c3HxzDER8R/lPkBH7BY9ZfE1xZoTBghL3jUyli7K3GNRYndImZdS9 PAI7DrKbXjc6Mqv5dHDPHHMtE8cJMcev+aVfFPdJj8mDOVDuFPXFQ/dBRdMGJLUpFOkcLFEGn wmy/E/uycD/ejsFXKxFxsqlbX2TCNcYzwr9jyHdmJXsWl9I34mkJYlXu5RurZi0zoePY= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-7 notices that the condition in mvs_94xx_command_active looks suspicious: drivers/scsi/mvsas/mv_94xx.c: In function 'mvs_94xx_command_active': drivers/scsi/mvsas/mv_94xx.c:671:15: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context] This was introduced when the mv_printk() statement got added, and leads to the condition being ignored. This is probably harmless. Changing '&&' to '&' makes the code look reasonable, as we check the command bit before setting and printing it. Fixes: a4632aae8b66 ("[SCSI] mvsas: Add new macros and functions") Signed-off-by: Arnd Bergmann --- drivers/scsi/mvsas/mv_94xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/scsi/mvsas/mv_94xx.c b/drivers/scsi/mvsas/mv_94xx.c index 4c57d9abce7b..7de5d8d75480 100644 --- a/drivers/scsi/mvsas/mv_94xx.c +++ b/drivers/scsi/mvsas/mv_94xx.c @@ -668,7 +668,7 @@ static void mvs_94xx_command_active(struct mvs_info *mvi, u32 slot_idx) { u32 tmp; tmp = mvs_cr32(mvi, MVS_COMMAND_ACTIVE+(slot_idx >> 3)); - if (tmp && 1 << (slot_idx % 32)) { + if (tmp & 1 << (slot_idx % 32)) { mv_printk("command active %08X, slot [%x].\n", tmp, slot_idx); mvs_cw32(mvi, MVS_COMMAND_ACTIVE + (slot_idx >> 3), 1 << (slot_idx % 32));