From patchwork Tue Nov 22 14:21:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101475 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp2120776qge; Tue, 22 Nov 2016 06:21:56 -0800 (PST) X-Received: by 10.84.209.173 with SMTP id y42mr124800plh.94.1479824516470; Tue, 22 Nov 2016 06:21:56 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d85si28627727pfb.163.2016.11.22.06.21.56; Tue, 22 Nov 2016 06:21:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756177AbcKVOVv (ORCPT + 26 others); Tue, 22 Nov 2016 09:21:51 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:55016 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756156AbcKVOVs (ORCPT ); Tue, 22 Nov 2016 09:21:48 -0500 Received: from wuerfel.lan ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0Ld9iz-1ca2RZ2Oor-00iTNE; Tue, 22 Nov 2016 15:21:40 +0100 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , Gregory CLEMENT , Florian Fainelli , Marcin Wojtas , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next] marvell: mark mvneta and mvpp2 32-bit only Date: Tue, 22 Nov 2016 15:21:22 +0100 Message-Id: <20161122142136.1690096-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:VznnlsjJs2cPjwdm8UCWz3ttYAQuaylX4bsSVeTT+UxF0FBuNIc c34LBVRl0ERGC7bKweuk5D7fk3jH+MCgQ5AM5U1/8AHcNjAA+PSBzCibAYMDtio2GUN1841 jEVoAN7pktKaWBbK1MfZnCq+EXN322SpKSFRNQstYRoPslMOC/ogMD3Rc2jffLJ6zXO4xZg zpB4sSwDkkOeD57RLpjSw== X-UI-Out-Filterresults: notjunk:1; V01:K0:9FuawzRl5hs=:Z42S4u85Z/ZO0bp927/7mE +d6TY1eJ2k7en+UZjT9wBcxM2gHXbNLVM2bO2gl7srrJFuVs6bCuFcG60k6st2qssPKeIDSs4 S9LhA1m0pXL1ks7zPFU9iZhHDtitZ/2IC75UibbArobqd2e0usrUWb8OOHqHLz1ysw7DbxQX9 b2US2VRN8hhQgWK/wScVNGHyaU4Q/fMz6Z3GX5Yz3opEH1e152S5Ex30QfMnEHXhU6QcNB0As 165CAaeDvv6mf4whpC0C4b62KK371Fy8yFz+c8BpkraHav/KmgJ/Fsay3QJ4amuoAlnskTk1e eYHRtwNk24GN/+6lKYeNHNooCZuBY682EveiOqQeuYKTO0e36dqjNpH7RZ5F21jpJwzhdYJs1 VsbLT64STgtoxOLq9WcWPOpCeYdcZuJTpYtQBW5QLyYP3i7AVdN+VGlpfpfgkYsTWXPUKGpxN dyr3DKQKp6zv1PNbwkZvfoVsHErvU+ru1vJpEcEF/ZIQyqx5DEoC7QbpM3QNqt49WcWGLQJdS VAo2RlwCbfsFXs46Utak5fhJd+x8ie9IXKhMuqZ9kbb2aWvOslDf27eKWDWeSKecjiGxpqtCC Tiy4FpFhhfmay0CEwV3kPXeelzni0hk5XPLDuwwzBG0NlA0ZosL54joCCFRiO4+zTfyPpUY2K bhDEJkLsCO6XikzRdaT5O+hLRAm/vP1z8WvYPcFxeajuEnEX3uYT2pGAlYJPfjej1fIM= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Both of these drivers won't work on 64-bit architectures unless they are redesigned, since they store a virtual address pointer in a 32-bit field of the descriptors: drivers/net/ethernet/marvell/mvneta_bm.c: In function 'mvneta_bm_construct': drivers/net/ethernet/marvell/mvneta_bm.c:103:16: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_vlan_init': drivers/net/ethernet/marvell/mvpp2.c:2563:32: error: large integer implicitly truncated to unsigned type [-Werror=overflow] This limits the COMPILE_TEST option for the two drivers again to only build them on 32-bit. This seems nicer than shutting up the warnings, in case we ever actually want to use them on 64-bit, as the warnings indicate which parts of the driver are currently broken there. Fixes: a0627f776a45 ("net: marvell: Allow drivers to be built with COMPILE_TEST") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/marvell/Kconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0 diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig index d74d4e6f0b34..66fd9dbb2ca7 100644 --- a/drivers/net/ethernet/marvell/Kconfig +++ b/drivers/net/ethernet/marvell/Kconfig @@ -58,6 +58,7 @@ config MVNETA tristate "Marvell Armada 370/38x/XP network interface support" depends on PLAT_ORION || COMPILE_TEST depends on HAS_DMA + depends on !64BIT select MVMDIO select FIXED_PHY ---help--- @@ -81,6 +82,7 @@ config MVPP2 tristate "Marvell Armada 375 network interface support" depends on MACH_ARMADA_375 || COMPILE_TEST depends on HAS_DMA + depends on !64BIT select MVMDIO ---help--- This driver supports the network interface units in the