From patchwork Mon Jan 16 22:54:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 91580 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp232869qgi; Mon, 16 Jan 2017 14:54:53 -0800 (PST) X-Received: by 10.98.1.213 with SMTP id 204mr24866419pfb.61.1484607292969; Mon, 16 Jan 2017 14:54:52 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1si22865356plj.237.2017.01.16.14.54.52; Mon, 16 Jan 2017 14:54:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751573AbdAPWyr (ORCPT + 25 others); Mon, 16 Jan 2017 17:54:47 -0500 Received: from mail-oi0-f68.google.com ([209.85.218.68]:36256 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbdAPWym (ORCPT ); Mon, 16 Jan 2017 17:54:42 -0500 Received: by mail-oi0-f68.google.com with SMTP id u143so13623885oif.3; Mon, 16 Jan 2017 14:54:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A69dWcflT18MXaM1bBb0eF909KbgkG67bciihITA4Ks=; b=IdUGidgNDlyHF2YrZe8etP8FviWBj+tIshWb7dQZGjAWwfA1SN8LCn+Q1Hjc9+sA9V QjTlEWVuIQnBmdJJ0S/saMK9bNdaMrwF7YetERKPUyCGjzOuBBpgbkdC0zrguM+GOVQR H9phjD1g7J26386SSue3M0lGCIYxVkXTCq2Iu7kV2zIZhE+cJBAFc2Q+O7F8ehhZiYsI rrAoKHvoB0c6YlqdXBOaqbcyUanVdO1DIxeI+xhpgDsenpJi0QV2VKwVpiqvmldI/ofe CQMpNSX+Z8t9TjjShVGIseAM4N49IXMJhutREpQujCJDw1bX46Gm0IHl5z6SJaZJTt9L YpcQ== X-Gm-Message-State: AIkVDXInAuoU1hWZp9TIQkkjbYG7wKfIcnzpnd7uWbGwXNRYbSo9+YzWC9A57LTCmTi0eA== X-Received: by 10.202.55.70 with SMTP id e67mr18181312oia.51.1484607281576; Mon, 16 Jan 2017 14:54:41 -0800 (PST) Received: from rob-hp-laptop.herring.priv (72-48-98-129.dyn.grandenetworks.net. [72.48.98.129]) by smtp.googlemail.com with ESMTPSA id s125sm11601254oia.0.2017.01.16.14.54.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Jan 2017 14:54:41 -0800 (PST) From: Rob Herring To: Greg Kroah-Hartman , Marcel Holtmann , Jiri Slaby , Sebastian Reichel , Arnd Bergmann , "Dr . H . Nikolaus Schaller" , Peter Hurley , Andy Shevchenko , Alan Cox Cc: Loic Poulain , Pavel Machek , NeilBrown , Linus Walleij , linux-bluetooth@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Cox Subject: [PATCH v2 2/9] tty_port: allow a port to be opened with a tty that has no file handle Date: Mon, 16 Jan 2017 16:54:29 -0600 Message-Id: <20170116225436.17505-3-robh@kernel.org> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20170116225436.17505-1-robh@kernel.org> References: <20170116225436.17505-1-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alan Cox Let us create tty objects entirely in kernel space. Untested proposal to show why all the ideas around rewriting half the uart stack are not needed. With this a kernel created non file backed tty object could be used to handle data, and set terminal modes. Not all ldiscs can cope with this as N_TTY in particular has to work back to the fs/tty layer. The tty_port code is however otherwise clean of file handles as far as I can tell as is the low level tty port write path used by the ldisc, the configuration low level interfaces and most of the ldiscs. Currently you don't have any exposure to see tty hangups because those are built around the file layer. However a) it's a fixed port so you probably don't care about that b) if you do we can add a callback and c) you almost certainly don't want the userspace tear down/rebuild behaviour anyway. This should however be sufficient if we wanted for example to enumerate all the bluetooth bound fixed ports via ACPI and make them directly available. It doesn't deal with the case of a user opening a port that's also kernel opened and that would need some locking out (so it returned EBUSY if bound to a kernel device of some kind). That needs resolving along with how you "up" or "down" your new bluetooth device, or enumerate it while providing the existing tty API to avoid regressions (and to debug). Alan Reviewed-by: Andy Shevchenko Reviewed-By: Sebastian Reichel --- Alan, Need your SoB here. v2: - no change drivers/tty/tty_io.c | 2 +- drivers/tty/tty_port.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.10.1 Signed-off-by: Alan Cox diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 4790c0fb5a45..a1fd3f7d487a 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -855,7 +855,7 @@ static void tty_vhangup_session(struct tty_struct *tty) int tty_hung_up_p(struct file *filp) { - return (filp->f_op == &hung_up_tty_fops); + return (filp && filp->f_op == &hung_up_tty_fops); } EXPORT_SYMBOL(tty_hung_up_p); diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c index c3f9d93ba227..606d9e5bf28f 100644 --- a/drivers/tty/tty_port.c +++ b/drivers/tty/tty_port.c @@ -335,7 +335,7 @@ EXPORT_SYMBOL(tty_port_lower_dtr_rts); * tty_port_block_til_ready - Waiting logic for tty open * @port: the tty port being opened * @tty: the tty device being bound - * @filp: the file pointer of the opener + * @filp: the file pointer of the opener or NULL * * Implement the core POSIX/SuS tty behaviour when opening a tty device. * Handles: @@ -369,7 +369,7 @@ int tty_port_block_til_ready(struct tty_port *port, tty_port_set_active(port, 1); return 0; } - if (filp->f_flags & O_NONBLOCK) { + if (filp == NULL || (filp->f_flags & O_NONBLOCK)) { /* Indicate we are open */ if (C_BAUD(tty)) tty_port_raise_dtr_rts(port);