From patchwork Wed Jul 26 07:55:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 108736 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp505294qge; Wed, 26 Jul 2017 00:56:02 -0700 (PDT) X-Received: by 10.101.77.6 with SMTP id i6mr72376pgt.181.1501055762752; Wed, 26 Jul 2017 00:56:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501055762; cv=none; d=google.com; s=arc-20160816; b=ufsn8hFdQtOe262wdiDvV1wejRY0VFM7K0XtbpIBau06b7UU+HOqVR4PlrS40Mh854 WGAW3W+siX8PSt9d+I6+zqNGE2+Q+QZxmOnsvtOki5PElnr3Pc855MW402v5xaczLM7Y Op+kFMGx6levG4Q+IUfskNvR45W84FMueAvCbKOR9RrabJtRZuPuBJOVj3b+FkdXRKYG 7UzE7gFYQkDxe3O35e91OFjigTmYLLBowf+hwt9p4WKTYlqis9pbLq4EbmxisRrCNKG9 UaEOGhpQtvEjmzcJt7a0VcQgAFeKm+adHR7e0M1TbsM37+8GyqXmXIZS/vdyuWHeFXRt 5htQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=+Jlmxi5S8/IkJr4sR167QLQCvcw+OhvKmEZRybR78vA=; b=SeBnxyJDwbGE6dNskr4X9HCNEjQWo9ArEvYwaxQ0mhGlmLq/weBGYr9vp+hdK51Yrf qryjsifnjx2mr0jVkAdQAJIlQnHgi7K9b1e2crom6RJOTnCz5222z4DcneF9hNTP0h8n z7n97eHBYG3UjJ8ztaiZKDH+sJOhSUUAk7+flW9HsifcQvdC0fAXHmQQwhMrwP8mswDZ 7jjjRpsegCtw4/ZtDAq9OVdrkTgPEtCYQgD1iBUP/l3bDaCBpY3F1gL91PoqpT1RRpUX RsUhUiUx4+ivcyMtfZUaVps2UtfKDbttCrEvCi2x68nXsm3noyEXZHJ0CJHXcj/8fnwO n3RQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6si9384824pgk.38.2017.07.26.00.56.02; Wed, 26 Jul 2017 00:56:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751552AbdGZHz7 (ORCPT + 26 others); Wed, 26 Jul 2017 03:55:59 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:59445 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbdGZHz5 (ORCPT ); Wed, 26 Jul 2017 03:55:57 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0MTveb-1dA7Lo2ni5-00QiQy; Wed, 26 Jul 2017 09:55:49 +0200 From: Arnd Bergmann To: Joerg Reuter Cc: Arnd Bergmann , David Howells , linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hamradio: dmascc: avoid -Wformat-overflow warning Date: Wed, 26 Jul 2017 09:55:33 +0200 Message-Id: <20170726075548.2736340-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:WVEzmRHgZpPh244vYfqk/aJ7vx/AHEkNf1GRkDQHIW7pNonuriA OYMjFf5vdmUJycli/AmediIodaX9/9XeEXPtRRn1ZAvaryYgIn2oafAReyOnH0R3XPVLC4y kFGszGT0TaQW+wxZjEqVdBddYJK8OZ7c8TX4QvT90L7wVjKM2wke67zlIXJbma3gWzIrO7O 2a8q/Z5qGb84pmVJos1iQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:c68s8J7i9Dw=:3WpGxp/Ve4sAnnHJ44ZgUB Oxx/gBSKmeAdYfv1e3ex4w5C8fvs5sh2hqA6si69SCYTlZIU+XqDJQzjr+iLZ1MDtKdmzO9sD gvebnRbSHrtNEHY0F+VHj8xBYx/1K6c5ErJTJLx1u+xlHHV2Z5PZCv+2GKiWxuzEuafTMyDR+ J3R7kuJTsrbCdPRTNlelCKK30vZMldsgRBLqewFrHc9bYCpq7Ddz3LmyehjgVKXVx0CPz5cOR /gHrgaGdwYg8nU5PjfEiOGubRlsURJt9MXMkFzfqSLOZTmfzf8Eyk3vochcrAfcUN7NbdixHS GhWsBxVm8q4keGk7JV8xaWkKhnnUTHm8mCEL/4ywYDATXsfjDgEy+u0YHfaC/r9+PjzE9thdF Xn5nRn4hHbq6EMvh+yXGI6dCKHCn1/aZwoi/brKHIoadLW1mcMNeh7TtvNRrthHF+iXDVY7x0 eElHuSil+Q0KQSlqhnPWxGqkXvsMaZFB7/3uW4e6wS6JED84qGzKaFB//0cZ4JMEhZErFnqcI f4NM+45rttPjXc6MtyWac0yva4r94L2NScQj48lZw1Ft9nmzUpgxCqgtNZs8Ux/lqnycPIa6n l/05q3zUmdGhkzCgjhkVm6nocpXE1IuXvvMQAVWRDyXha3uvnW96FYYy8JX2JFeDuYvKMWw5Z it2ptMppWoTUjtf6nuaaMXpYVCC+H64pJLH83LFBw3xaVurp39ZV/2v7/HLgwj3mwmehIL5ht uBWl6lLOv3RqXqpAcX3GZ8VtDgeCYXRZaUXFUw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc warns that the device name might overflow: drivers/net/hamradio/dmascc.c: In function 'dmascc_init': drivers/net/hamradio/dmascc.c:584:22: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=] sprintf(dev->name, "dmascc%i", 2 * n + i); drivers/net/hamradio/dmascc.c:584:3: note: 'sprintf' output between 8 and 17 bytes into a destination of size 16 sprintf(dev->name, "dmascc%i", 2 * n + i); >From the static data in this file, I can tell that the index is strictly limited to 16, so it won't overflow. This simply changes the sprintf() to snprintf(), which is a good idea in general, and shuts up this warning. Signed-off-by: Arnd Bergmann --- I ran into this for the first time today on linux-next randconfig builds, but couldn't find an obvious commit that introduced it. I guess it's just a very rare randconfig warning, so this can go into net-next rather than net fixes. --- drivers/net/hamradio/dmascc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/net/hamradio/dmascc.c b/drivers/net/hamradio/dmascc.c index dec6b76bc0fb..cde41200f40a 100644 --- a/drivers/net/hamradio/dmascc.c +++ b/drivers/net/hamradio/dmascc.c @@ -581,7 +581,7 @@ static int __init setup_adapter(int card_base, int type, int n) priv->param.dma = -1; INIT_WORK(&priv->rx_work, rx_bh); dev->ml_priv = priv; - sprintf(dev->name, "dmascc%i", 2 * n + i); + snprintf(dev->name, sizeof(dev->name), "dmascc%i", 2 * n + i); dev->base_addr = card_base; dev->irq = irq; dev->netdev_ops = &scc_netdev_ops;