From patchwork Wed Jul 26 09:34:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 108746 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp582504qge; Wed, 26 Jul 2017 02:35:34 -0700 (PDT) X-Received: by 10.84.233.207 with SMTP id m15mr328017pln.334.1501061734004; Wed, 26 Jul 2017 02:35:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501061733; cv=none; d=google.com; s=arc-20160816; b=S1VsxegouzwlhdvkjULvKW4Zu1QspDzwkqXJ33oNgobeS7VQTvgaYBaQG8mxXZg4JA qzoSE9k4S4SJBqPc4Rvuw15lRXrhzASiSK5iKJPg8m7cm8S6hhFIVZjGKYexwoFDtrG6 xdlUzhILH/KjywnZyXlPxIFzHBm4ZlWs316U9+LhvwLVO7RX6JH2e+NyJ3YiFOBWIKB/ gaZeuAJ803hDm/2C/X9tr00rysB8wo3HEnlnn9VCahmkn6s3eWS75hQCsn6mL2Lxxv6q nwnzapb7HrUnKnV1HkXoijYhlIIKJN6iN461QGfJ4GeAY4/XgWWlEh09bxtHzFd8uHRC VdAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=1DDcwyQcBdZUAiHf+aDJwqMEs3H4zPDIg5nDBqew9co=; b=EHSRnFXsRHLBDDz1ZmjpKhPx9rGn0QnxUFl/JVr6C2ihpFlijLArHvAa2uGJp9CATB uoQTuKusO3WCB+7mdO6IMBSDA9mJRULppMJQxYc+G7Hs/FNEMZLlxh1ElDkrjHzfUUyz Nx/o6Z6kT7uw20QQO9sIQOrXdlx1I+pKdHx4s9rrSLcgLowxPrvWfZ7f6eDGlbe4/RNV CJyMzfdKdAa4BgPO8LYK9nAmEJUfHDeSwpxkWTmbajI8JpI2dzRiSs+ZRPkZNqi5xpX8 GjvyVwm/vqpAcjucs84h3hZXJxnaKG7IvjC1gRHQRFJT8FY0ORbB3N1c7d2ZCp/L8Lnh lbaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=dHkrxfpH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7si9815060plk.485.2017.07.26.02.35.33; Wed, 26 Jul 2017 02:35:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=dHkrxfpH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751655AbdGZJfc (ORCPT + 26 others); Wed, 26 Jul 2017 05:35:32 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:36813 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbdGZJfB (ORCPT ); Wed, 26 Jul 2017 05:35:01 -0400 Received: by mail-io0-f180.google.com with SMTP id g35so32984827ioi.3 for ; Wed, 26 Jul 2017 02:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1DDcwyQcBdZUAiHf+aDJwqMEs3H4zPDIg5nDBqew9co=; b=dHkrxfpHGjDPqtVm1wLvzdstruJ+mU8T5/jMS6gHdmHZpvD849aW3fthPTzH1PpFAo OqkgRLoKR1K8W8zfGRn0gcm3hCTxqnHxIhJimPtArsCDlnLcWfYlUSmqa0mSHYxsn/PD cWyTd32DAECQxov2GTjgMAblfhYevIZLoTii8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1DDcwyQcBdZUAiHf+aDJwqMEs3H4zPDIg5nDBqew9co=; b=Nnqz4LlRQWLG9Rukfwie8ZRsTPcAxYCOvUSIez0z4o3Uz43nVdjozxSZ71BR5X8Qv4 Yqqg8LRXX0ZL2Vm3IuF5GrWfXb9Gle2EaxfXMOakqaMms4pAMtVWm7JRHdzOURoJnAfG gRmhvU2PxGs7qMphYUlHNfzaGhHzdvv6WIQoeILUPcq29F9ojffnO9Db4bRftpIZTcev 07ghDztPev7W4PlIBWJbVO4kJ33qCn1kkHpPFrfGC9YWJpI4+uRIZHBDCoJeL7jZEqZl laClxS6ZxTNeDwugHcugAcxoNscnr74UQ8u6YT8rvbvaY7eUhZVNpi11pNZJrhHoiRGr GTBw== X-Gm-Message-State: AIVw1132mwFZ4Ba5u7abTFkIemzUTBP54bYbYQXROSb1zGXl7PXYmbA3 US8R7/ruQicP2eJ6SzZVfQ== X-Received: by 10.107.18.40 with SMTP id a40mr294161ioj.282.1501061700253; Wed, 26 Jul 2017 02:35:00 -0700 (PDT) Received: from localhost.localdomain (static.8.26.4.46.clients.your-server.de. [46.4.26.8]) by smtp.gmail.com with ESMTPSA id c195sm7837169ioe.42.2017.07.26.02.34.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 26 Jul 2017 02:34:59 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Dan Carpenter , Srinivas Kandagatla Subject: [PATCH 5/6] nvmem: core: remove unneeded NULL check Date: Wed, 26 Jul 2017 11:34:47 +0200 Message-Id: <20170726093448.2564-6-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170726093448.2564-1-srinivas.kandagatla@linaro.org> References: <20170726093448.2564-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter "p" is the list iterator so it can't be NULL. Static checkers complain about this unnecessary check because we dereference the list iterator to get the next item in the list so we'd be in trouble if it really was NULL. I have removed the check. Signed-off-by: Dan Carpenter Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.3 diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 72a60dc..de54c7f 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -290,7 +290,7 @@ static struct nvmem_cell *nvmem_find_cell(const char *cell_id) mutex_lock(&nvmem_cells_mutex); list_for_each_entry(p, &nvmem_cells, node) - if (p && !strcmp(p->name, cell_id)) { + if (!strcmp(p->name, cell_id)) { mutex_unlock(&nvmem_cells_mutex); return p; }