From patchwork Fri Aug 18 16:57:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salil Mehta X-Patchwork-Id: 110419 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp1168917qge; Fri, 18 Aug 2017 09:58:34 -0700 (PDT) X-Received: by 10.84.217.208 with SMTP id d16mr10399358plj.269.1503075514438; Fri, 18 Aug 2017 09:58:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503075514; cv=none; d=google.com; s=arc-20160816; b=PjPRD9UGfrT7wOoL/aq1jX8oTeltMtjErFIQdlgyq70QBgEmkgWGHpV/3oGvkZGE8x Am8ADLqWNiIxXxRBXQIeCBGhWXhW6wh8z8kaKH9demGGXmkmnuDMSdkyqDLYZS9uBick zIPNJRlNMjcWuS3chOxf8O+MjGRzf4Jgcw7dZNTODTbnfVdBaQImXg/xJfDTF4Lyml7Y NWnho1i4xQuYeQvb2G6gyOIBapLojY/iPWxgz75DlJxm/iEBFDtU0UqUbClsCjGu/1vQ oHzWbJeJ9YWEx6NMawmkUyeGyokzN4lSAo71RPDySMeUO4G84VYQ/xN6mOzr8oDXbiHz yfjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=g8S+Lq6ZWyVWkHUvMTxJrW4n/+/7u/a4RKJ0PTTs5CI=; b=DX90c3EqUTxofu6M92+1nEvOMD7Fhf97Vjyz+0AS6fuuzzf3NjobIwfsVkNLNOKeEr bjGyb6bZzr73M0LnCWZSqenTeEe+TthxoiEFcFEd7Ry9eLtKHHN4HWiRuyWyShAP6HdS 1vN4XPriU0ElXFjKPHn5aqtKXO1pQI08kb0Q3xrEvB6apoU+qc2ngetkLGVEliJ8Voox B5b8ybsMBXf4FSrxwwU04hJPu+6fDtAlXvZAnPXlHQ3mldVkLxFYCpRng78Fn+zoelbN 6G/DuDjr6GBaPSRxnFZ0ZNQFWhBxxRGRuSkU9LSF7wgXCyg6KweDeZfhPvUgu6RiB0qm ykTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 61si2405668plr.988.2017.08.18.09.58.34; Fri, 18 Aug 2017 09:58:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752597AbdHRQ6b (ORCPT + 26 others); Fri, 18 Aug 2017 12:58:31 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4509 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbdHRQ6a (ORCPT ); Fri, 18 Aug 2017 12:58:30 -0400 Received: from 172.30.72.58 (EHLO DGGEMS404-HUB.china.huawei.com) ([172.30.72.58]) by dggrg04-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id DFK93160; Sat, 19 Aug 2017 00:58:26 +0800 (CST) Received: from S00293818-DELL1.china.huawei.com (10.203.181.151) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.301.0; Sat, 19 Aug 2017 00:58:14 +0800 From: Salil Mehta To: CC: , , , , , , , Subject: [PATCH V2 net-next] net: hns3: Add support to change MTU in HNS3 hardware Date: Fri, 18 Aug 2017 17:57:59 +0100 Message-ID: <20170818165759.20152-1-salil.mehta@huawei.com> X-Mailer: git-send-email 2.8.3 MIME-Version: 1.0 X-Originating-IP: [10.203.181.151] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.59971CB2.00F5, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 96e8d35881f5b8f4bc4c1bb80fa92c51 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds the following support to the HNS3 driver: 1. Support to change the Maximum Transmission Unit of a of a port in the HNS NIC hardware . 2. Initializes the supported MTU range for the netdevice. Signed-off-by: lipeng Signed-off-by: Salil Mehta --- PATCH V2: Addresses comments given by Andrew Lunn 1. https://lkml.org/lkml/2017/8/18/282 PATCH V1: Initial Submit --- .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 38 ++++++++++++++++++++++ .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h | 1 + 2 files changed, 39 insertions(+) -- 2.7.4 diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c index e731f87..d905ea1 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c @@ -1278,11 +1278,46 @@ static int hns3_ndo_set_vf_vlan(struct net_device *netdev, int vf, u16 vlan, return ret; } +static int hns3_nic_change_mtu(struct net_device *netdev, int new_mtu) +{ + struct hns3_nic_priv *priv = netdev_priv(netdev); + struct hnae3_handle *h = priv->ae_handle; + bool if_running = netif_running(netdev); + int ret; + + if (!h->ae_algo->ops->set_mtu) + return -ENOTSUPP; + + /* if this was called with netdev up then bring netdevice down */ + if (if_running) { + (void)hns3_nic_net_stop(netdev); + msleep(100); + } + + ret = h->ae_algo->ops->set_mtu(h, new_mtu); + if (ret) { + netdev_err(netdev, "failed to change MTU in hardware %d\n", + ret); + return ret; + } + + /* if the netdev was running earlier, bring it up again */ + if (if_running) { + if (hns3_nic_net_open(netdev)) { + netdev_err(netdev, "MTU, couldnt up netdev again\n"); + ret = -EINVAL; + } + } + + return ret; +} + static const struct net_device_ops hns3_nic_netdev_ops = { .ndo_open = hns3_nic_net_open, .ndo_stop = hns3_nic_net_stop, .ndo_start_xmit = hns3_nic_net_xmit, .ndo_set_mac_address = hns3_nic_net_set_mac_address, + .ndo_change_mtu = hns3_nic_change_mtu, .ndo_set_features = hns3_nic_set_features, .ndo_get_stats64 = hns3_nic_get_stats64, .ndo_setup_tc = hns3_nic_setup_tc, @@ -2752,6 +2787,9 @@ static int hns3_client_init(struct hnae3_handle *handle) goto out_reg_netdev_fail; } + /* MTU range: (ETH_MIN_MTU(kernel default) - 9706) */ + netdev->max_mtu = HNS3_MAX_MTU - (ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN); + return ret; out_reg_netdev_fail: diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h index a6e8f15..7e87461 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h @@ -76,6 +76,7 @@ enum hns3_nic_state { #define HNS3_RING_NAME_LEN 16 #define HNS3_BUFFER_SIZE_2048 2048 #define HNS3_RING_MAX_PENDING 32768 +#define HNS3_MAX_MTU 9728 #define HNS3_BD_SIZE_512_TYPE 0 #define HNS3_BD_SIZE_1024_TYPE 1