From patchwork Thu Oct 5 03:32:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 114832 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp133137qgn; Wed, 4 Oct 2017 20:34:20 -0700 (PDT) X-Received: by 10.98.20.69 with SMTP id 66mr505535pfu.291.1507174460251; Wed, 04 Oct 2017 20:34:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507174460; cv=none; d=google.com; s=arc-20160816; b=HLVaoddTq/y9hzf87NbIz/K8SU6JxIzqdNRxduTAUVjMGGgpO7ob6wXxEEYhsWxbxq LlkXbAjFdcXFpvwurgB7iSXB53vku6KVNFE2LviAGlYT0i7+7E+5k2Qy12tZ3/iUXKAn tPXneDED0K1IdpTfQ0i5u3fmh3DBNpLX/2c6IjcwC9Xm1F6Dw4w0wqmaylxBuMjSMZoT FJ5Ne+V9aJckZJ5rEUViDGYpAhOh+5us0RV+LhkHJC5wRkAxE+gsh/Ytp+Y/HJDQxxan bEFKO+b0xFt3rusbYo/lT2rFkbTkcSdPcRYgimDaycs8HH2d70tCHeAvkyWixLAKihP/ KyjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=1dEd9rjG8SfOZjW67/oDHfzf+LcltUc1goZTNkEVsc4=; b=fPcZi1Fi4ugerXsd4F5HvjZaWSTlx6aI/t7N47Z9JO/1vbROsoF315MFcKkIUdHOQs sQE9Vkan79V9UDrHCbsqFF6+W0CWrm79hecYtLYNK21VfXk+fEjPrtPkpyGEsUkyp1ed 5D8bSZpQ7RpLbK7Z0JJwAD586OnW3c8BBxiJgEUQ4pZcYmTYZy7qMHqeUcJ51v9ZOi8Y IU0v3isiLUhBOiQm8sTL/XiXMD0rSQ6aZABpIpCVl2v6EnMRh4mPNsOzByuo+Ih4S453 C5JkTAQeH4yvphrR+3AUuf2XXpt3PvThvmKI9DfCpwLHWONw7Xh+MB4kHvH5wO330zeV 7mNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NVj3dzZj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u3si5611450plb.302.2017.10.04.20.34.19; Wed, 04 Oct 2017 20:34:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NVj3dzZj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751757AbdJEDeS (ORCPT + 26 others); Wed, 4 Oct 2017 23:34:18 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:54414 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbdJEDdE (ORCPT ); Wed, 4 Oct 2017 23:33:04 -0400 Received: by mail-pf0-f179.google.com with SMTP id m28so2366660pfi.11 for ; Wed, 04 Oct 2017 20:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1dEd9rjG8SfOZjW67/oDHfzf+LcltUc1goZTNkEVsc4=; b=NVj3dzZjDf2y70FVRihawaTpK23FC/SgQseB7VF2GdTisyF2tzfk4fvMl7EJ5ikWRh mSOrs4sOAAS7i3t1qv+dX7e5VRvkovMJvoPtsXwgbqsenQrarQmgOCalO1RJPdoaVUZY +Zxln2GdT/l6+kkvFruz2ESrrsI/fhtsmM9CU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1dEd9rjG8SfOZjW67/oDHfzf+LcltUc1goZTNkEVsc4=; b=HpxURNk+YYZ4YW0Eu5wwgaW1PChwS7ajFEGQl4pn/SIa5rNQWl/9BCoB+5sRYaI/YL tZT4yooX/SnZID9Cn0CjeV49xn0vkWsVsD6wtMKjWeEN3vd6vPkhWCoArJZKWUaNEb4r +cZwsAx4BhCw6zoZYD7QfGw0xS+X8pbWwXsTjgil+tS0qIEgQojOWoXospDTfAH+nGVx 7x6WBWWiySaKdW78RzlcH8CYrOb3DO04YrgiUzHhpgwhYmM6swaYxGqbQzWuhsHY9RHw 9/VDDKoSbPb1FaoIiQQJjXnv+W0o0naAxtZ+IjDzQf4xy3t7h9dml+EjrSb5om/+eMeM 6fHg== X-Gm-Message-State: AMCzsaXcJixY30gc4w8sVVGxlE8wOpHjvHWYUdDwVbhBpyhoBdnQ0XI4 2R+y3lqdakEc6lJD13k+khq8gw== X-Google-Smtp-Source: AOwi7QDESr1R5pVcS5Duaw5rLBI+qYHlK+66SpHdJakRuJAO5fb8FAHw6VQNe/9qyJ/gNS7nrBB62w== X-Received: by 10.84.178.101 with SMTP id y92mr11595432plb.137.1507174384248; Wed, 04 Oct 2017 20:33:04 -0700 (PDT) Received: from localhost.localdomain (ip68-111-217-79.sd.sd.cox.net. [68.111.217.79]) by smtp.gmail.com with ESMTPSA id h70sm28945700pfc.51.2017.10.04.20.33.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Oct 2017 20:33:03 -0700 (PDT) From: Bjorn Andersson To: Andy Gross , Anton Vorontsov , Colin Cross , Frank Rowand , Kees Cook , Rob Herring , Tony Luck Cc: David Brown , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org Subject: [PATCH v3 1/5] of/platform: Generalize /reserved-memory handling Date: Wed, 4 Oct 2017 20:32:54 -0700 Message-Id: <20171005033258.12825-2-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171005033258.12825-1-bjorn.andersson@linaro.org> References: <20171005033258.12825-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org By iterating over all /reserved-memory child nodes and match each one to a list of compatibles that we want to treat specially, we can easily extend the list of compatibles to handle - without having to resort to of_platform_populate() that would create unnecessary platform_devices. Signed-off-by: Bjorn Andersson --- Changes since v2: - Simplify logic per Rob's suggestion. Changes since v1: - New patch drivers/of/platform.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) -- 2.12.0 diff --git a/drivers/of/platform.c b/drivers/of/platform.c index b19524623498..ee89f096f0f3 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -497,6 +497,11 @@ int of_platform_default_populate(struct device_node *root, EXPORT_SYMBOL_GPL(of_platform_default_populate); #ifndef CONFIG_PPC +static const struct of_device_id reserved_mem_matches[] = { + { .compatible = "ramoops" }, + {} +}; + static int __init of_platform_default_populate_init(void) { struct device_node *node; @@ -505,15 +510,12 @@ static int __init of_platform_default_populate_init(void) return -ENODEV; /* - * Handle ramoops explicitly, since it is inside /reserved-memory, - * which lacks a "compatible" property. + * Handle certain compatibles explicitly, since we don't want to create + * platform_devices for every node in /reserved-memory with a + * "compatible", */ - node = of_find_node_by_path("/reserved-memory"); - if (node) { - node = of_find_compatible_node(node, NULL, "ramoops"); - if (node) - of_platform_device_create(node, NULL, NULL); - } + for_each_matching_node(node, reserved_mem_matches) + of_platform_device_create(node, NULL, NULL); /* Populate everything else. */ of_platform_default_populate(NULL, NULL, NULL);