From patchwork Wed Oct 25 10:14:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 117096 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp665548qgn; Wed, 25 Oct 2017 03:14:39 -0700 (PDT) X-Google-Smtp-Source: ABhQp+RK+B7K+jAXh9OEBLu35mjNpRt6qrgXQIHJ+z0Hf0/GmgBnjAeKnlIDZZ4UElLSyqs8iwTR X-Received: by 10.84.192.131 with SMTP id c3mr1373388pld.435.1508926479444; Wed, 25 Oct 2017 03:14:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508926479; cv=none; d=google.com; s=arc-20160816; b=PWRR7dPe2qYa167890xovL5QLS5RAkgqlXO054HcRk3bGLqr+5cRSLiikmW7V/sGz9 Po+uWrKSvX3WExufAd2r5bQYsnXqroR0FGnttOdreniv1WfIa1lIVIH/3dlkOzvq4FEV 2VSwnCX2g61TajPk6bMK3NI16OmkVJEJ9kU1SUiyknlQBSkWlVszlrHdw/8qZmXHopYx k64Oybu78PQ/m8HWeSJn5qhWPCs80Rtfxo1084wxjDYZUJG826TH/+DHO8Zp2u3Gl9wV 5lsP0EEG4fDm23gOx0cLM50PZ6q+xE3CSPn8yY3uZkc+F76nNq/n3LSNzWAVRRrrAW/F KXKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=Yb2DJRlFkGNiiQK3UIK0lt1hHSN4BEKDtEGhmV2d/YY=; b=hjGkIzxardTzzk9FtKHcvdGMF7fJBG4mwUl0mmgpT3AumNc0I5+nK2pNcnnzQRbNnO QFX1HefRdnbGUWu6DgE9Qr1DRCozb81t32xJ/3yrlIjqbs+jCZO9C/YnfakQ9teoZmzV eOBzMmd9XBgKoQFsQAhxhrNkT8KO90FwhsGt07YsdWIK4rrcrwlGjRYBfmYOAUd4dAvh WAC+Ez/HZu6IsWKq8dazjyR922UU6yugOFe/bmRc6qAFGvtaIuOSm7uZeBviKXjPWjtp 8svYXi04QfYCqAH9JBuYWYTgjQ7llnVoUp1l2xUOr7X9ZzXfBNX1DbjU2fwfuuLX3Tvt XGXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BlOldzK4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h13si848901pfd.545.2017.10.25.03.14.39; Wed, 25 Oct 2017 03:14:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BlOldzK4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932492AbdJYKOg (ORCPT + 27 others); Wed, 25 Oct 2017 06:14:36 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:51377 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932428AbdJYKOc (ORCPT ); Wed, 25 Oct 2017 06:14:32 -0400 Received: by mail-wr0-f195.google.com with SMTP id j15so11290888wre.8 for ; Wed, 25 Oct 2017 03:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Yb2DJRlFkGNiiQK3UIK0lt1hHSN4BEKDtEGhmV2d/YY=; b=BlOldzK4PGfkYB/QqFxGkwWXOoJPWfBCocl/5j8szbWZqcsigEKBrrU+MJUQ3lxAWY +sKlZ2NZXmQ6vTq61qXEyLE/JZeEvbOXAquUkQu2fJS5UtooDaZ/CPp975hQinIhuszO DUlULd96xisGnrk+3/X8naPb8Rhf25plavQaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Yb2DJRlFkGNiiQK3UIK0lt1hHSN4BEKDtEGhmV2d/YY=; b=rwB3pc5K6SRiWAt7yZxi0nz7lSemqSdw65IFvaab+zQRgImIwVrcw5v7UTfiyO2nCJ pp9ycfUsA2y9/gCfo7+bA+D27RCdSVGC1mFzRVnONyFvlbrlOcrrO3+TXhHD8gc/ANCZ vYd3DsAIDbiohkRTusX7lot2K0w+y+ktpWoHuE1ETUs+vlC9XX3VgAFXxalx3pkF6Sf+ 1diWTJ39crl1Oad0/yLqUBwzo/BZDMqTblPphUihMoWawf75paQ/NyA+SqtlfZeWGbnn b/M718ttnzDh1RgLWuYNz6T0n/frX5nhS832/xFE5IHWvMKEo4QShG6Uo2roolxRmQbN q95g== X-Gm-Message-State: AMCzsaVBusrA/mZZHbMDgiPVrwSZ9xrPyklpPJegnxAZf97rSGI3mJj0 HxNWayA16vhaGbQt+nVZf/blwg== X-Received: by 10.223.199.202 with SMTP id y10mr1719448wrg.181.1508926470942; Wed, 25 Oct 2017 03:14:30 -0700 (PDT) Received: from localhost.localdomain ([160.161.173.60]) by smtp.gmail.com with ESMTPSA id m26sm2272470wrb.81.2017.10.25.03.14.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Oct 2017 03:14:30 -0700 (PDT) From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: Arvind Yadav , Ard Biesheuvel , linux-kernel@vger.kernel.org, Jan Kiszka , Kweh Hock Leong , Matt Fleming Subject: [PATCH 1/2] efi/capsule-loader: pr_err() strings should end with newlines Date: Wed, 25 Oct 2017 11:14:18 +0100 Message-Id: <20171025101419.26369-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171025101419.26369-1-ard.biesheuvel@linaro.org> References: <20171025101419.26369-1-ard.biesheuvel@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arvind Yadav pr_err() messages should terminated with a new-line to avoid other messages being concatenated onto the end. Signed-off-by: Arvind Yadav Cc: Ard Biesheuvel Cc: Jan Kiszka Cc: Kweh Hock Leong Signed-off-by: Matt Fleming Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/capsule-loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c index ec8ac5c4dd84..51d2874942a2 100644 --- a/drivers/firmware/efi/capsule-loader.c +++ b/drivers/firmware/efi/capsule-loader.c @@ -49,7 +49,7 @@ int __efi_capsule_setup_info(struct capsule_info *cap_info) pages_needed = ALIGN(cap_info->total_size, PAGE_SIZE) / PAGE_SIZE; if (pages_needed == 0) { - pr_err("invalid capsule size"); + pr_err("invalid capsule size\n"); return -EINVAL; }