From patchwork Tue Nov 28 07:19:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 119798 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp1357808qgn; Mon, 27 Nov 2017 23:19:57 -0800 (PST) X-Google-Smtp-Source: AGs4zMapzLv35zeDJfdQLkIwIi0NyByp6SLhSA1TGTOX3Mr+kHrDEV4aj4tpSH7QWBPEr01Sjd5G X-Received: by 10.98.161.25 with SMTP id b25mr40127512pff.103.1511853597691; Mon, 27 Nov 2017 23:19:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511853597; cv=none; d=google.com; s=arc-20160816; b=fm+5GJg01tCDvrbJuPu4QtjvFtAdHoXAWWwj3Gg8OB7nTvxY4UT77T46JpFOcl6/K0 6ZMswO+pwyuvCYrMkvUH5CB2hFbgMAzm6IeQUDoJytswcciwRGW466yXmpgZDTj2IlB/ V36rcCjtT0wEBJK/innje5xHiqbRgS8aOHCzR3JfZjAsOKTgPp6IahopRqFlGrXq71Xj OEr4alSF8rTzNlzearquWd/YOVQ7mmx0I9uUgUSwFsUmZQz3KU+fJTFmEq3mf4ibIJrN nioLomkjcHjTH5bIzfYw3ER61tw6itfUOZ6rRtmsraAaHSxs6jV6w4DF32o8E7yB5+3u zUlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=xxVwBCV3Q+1UYkdjI7iuVrOWGDrKX7Gdy+/FpNTDiKM=; b=zAFMEhJS9AzhqXMBRweAxUBZoOJlf+UzDuiEWGR+OhdjQ2ArMn6FdOYbsFE+Xmie8n 6stEdc1C97c3Y2Dw5fbGjQlqNP2TbRu5bi3HbYsVWBQgs3g8BPJHo27NgQwYvvul/o73 wOKGgfPP3ob9cask7p0FT0Njl3orypPbw9OhRTqYL8WNPs0tGDGTLTk56heBJXBAf8n1 F2vIAFQWZhXUbQFvtN+TudGWGFiyTxwH8EM2xTc3BK2M6F+PAtgf5Ejx1WXM7QJuC23r 5xclsKbOjBt5yN7SAftvAuQoffbLDKSFdqSbYDZ+F9tVstButImwajEqc9rZb7laf/Ka Uwxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=IQ0O0Zus; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h69si24043864pge.382.2017.11.27.23.19.57; Mon, 27 Nov 2017 23:19:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=IQ0O0Zus; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751935AbdK1HT4 (ORCPT + 28 others); Tue, 28 Nov 2017 02:19:56 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:42973 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbdK1HTx (ORCPT ); Tue, 28 Nov 2017 02:19:53 -0500 Received: by mail-pf0-f195.google.com with SMTP id m88so18560134pfi.9; Mon, 27 Nov 2017 23:19:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=xxVwBCV3Q+1UYkdjI7iuVrOWGDrKX7Gdy+/FpNTDiKM=; b=IQ0O0ZusBdfDFktIOf2GkK80jbrl6lrG+Fq66v4/rr7yuCBvTnmNp5QkZiGVjzy9DW JCHB/l4UgeFXDKhTMOout4zaSPMWIWgsLI9A9qTv8uNW9WaWn3zT3BCC8HP8Q+2nS6HV f9OhSMggBBLBG0MolaZoujLdaVOZeaEAww4yFeitZLxeCndG9LhgQB7tf+DJNGr3tayF RXt2bSRHcK2M0YD0hHZI9ee/Y4LLJ0eIU+Ycg8lmuUkWBIa8eUkWeeOtY04xh0o3CfLL cO7e2dHHL1JiF15mQdVjU2PL8yDJPie3AZCd29T63PnvRfBO2rZTELUAtyhJWzFMpMuF zeYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=xxVwBCV3Q+1UYkdjI7iuVrOWGDrKX7Gdy+/FpNTDiKM=; b=dDCWetUKB6JVZ5YKbPqmu/CgmI/+rd3gYKZSrmZ2vc6lG1VNQOie8J+QuH4CUeGv4L lDYsFnx4PivzRqExXUyMSflRUUocr+GACx1v/UBjmKJiy4fRTP5R3kGrr7z9appwfcjw zu0rBCuZB+xvcDyyQUfw9vARfHbWQs9DQBIXhGSiQKv/tVVpwf37ZKl1+kzNpJDSOD5i FqL7+Nf/OW2o3A8wgxmmNX9VQUO5Xyo5x7UJRAEukswtWGs+cPjTI+/f9xEl48lmRlR9 f4WNT9TW9mu3S4jebdkL9rfJBTz/6cC/Ym+AeaYc4Fr5KHfMI8oVfP5lTBY1cA7PItiH 3hgg== X-Gm-Message-State: AJaThX7giIHxA4e2QVIhKjGTl+O5vQwrLeasyvKURIpI13/uZtf8bTnO bEOnuzJH0PqLsZuFOesK3bs= X-Received: by 10.98.60.27 with SMTP id j27mr39761890pfa.68.1511853592657; Mon, 27 Nov 2017 23:19:52 -0800 (PST) Received: from aurora.jms.id.au ([203.0.153.9]) by smtp.gmail.com with ESMTPSA id h6sm48692564pgn.63.2017.11.27.23.19.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Nov 2017 23:19:51 -0800 (PST) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Tue, 28 Nov 2017 17:49:43 +1030 From: Joel Stanley To: Lee Jones , Michael Turquette , Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Jeffery , Benjamin Herrenschmidt , Jeremy Kerr , Rick Altherr , Ryan Chen , Arnd Bergmann Subject: [PATCH v6 2/5] clk: aspeed: Register core clocks Date: Tue, 28 Nov 2017 17:49:05 +1030 Message-Id: <20171128071908.12279-3-joel@jms.id.au> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171128071908.12279-1-joel@jms.id.au> References: <20171128071908.12279-1-joel@jms.id.au> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This registers the core clocks; those which are required to calculate the rate of the timer peripheral so the system can load a clocksource driver. Reviewed-by: Andrew Jeffery Signed-off-by: Joel Stanley --- v5: - Add Andrew's Reviewed-by v4: - Add defines to document the BIT() macros v3: - Fix ast2400 ahb calculation - Remove incorrect 'this is wrong' comment - Separate out clkin calc to be per platform - Support 48MHz clkin on ast2400 --- drivers/clk/clk-aspeed.c | 177 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 177 insertions(+) -- 2.14.1 diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c index 381be5547178..9742f1d0977f 100644 --- a/drivers/clk/clk-aspeed.c +++ b/drivers/clk/clk-aspeed.c @@ -11,7 +11,23 @@ #include +#define ASPEED_RESET_CTRL 0x04 +#define ASPEED_CLK_SELECTION 0x08 +#define ASPEED_CLK_STOP_CTRL 0x0c +#define ASPEED_MPLL_PARAM 0x20 +#define ASPEED_HPLL_PARAM 0x24 +#define AST2500_HPLL_BYPASS_EN BIT(20) +#define AST2400_HPLL_STRAPPED BIT(18) +#define AST2400_HPLL_BYPASS_EN BIT(17) +#define ASPEED_MISC_CTRL 0x2c +#define UART_DIV13_EN BIT(12) #define ASPEED_STRAP 0x70 +#define CLKIN_25MHZ_EN BIT(23) +#define AST2400_CLK_SOURCE_SEL BIT(18) +#define ASPEED_CLK_SELECTION_2 0xd8 + +/* Globally visible clocks */ +static DEFINE_SPINLOCK(aspeed_clk_lock); /* Keeps track of all clocks */ static struct clk_hw_onecell_data *aspeed_clk_data; @@ -89,6 +105,160 @@ static const struct aspeed_gate_data aspeed_gates[] = { [ASPEED_CLK_GATE_LHCCLK] = { 28, -1, "lhclk-gate", "lhclk", 0 }, /* LPC master/LPC+ */ }; +static const struct clk_div_table ast2400_div_table[] = { + { 0x0, 2 }, + { 0x1, 4 }, + { 0x2, 6 }, + { 0x3, 8 }, + { 0x4, 10 }, + { 0x5, 12 }, + { 0x6, 14 }, + { 0x7, 16 }, + { 0 } +}; + +static const struct clk_div_table ast2500_div_table[] = { + { 0x0, 4 }, + { 0x1, 8 }, + { 0x2, 12 }, + { 0x3, 16 }, + { 0x4, 20 }, + { 0x5, 24 }, + { 0x6, 28 }, + { 0x7, 32 }, + { 0 } +}; + +static struct clk_hw *aspeed_ast2400_calc_pll(const char *name, u32 val) +{ + unsigned int mult, div; + + if (val & AST2400_HPLL_BYPASS_EN) { + /* Pass through mode */ + mult = div = 1; + } else { + /* F = 24Mhz * (2-OD) * [(N + 2) / (D + 1)] */ + u32 n = (val >> 5) & 0x3f; + u32 od = (val >> 4) & 0x1; + u32 d = val & 0xf; + + mult = (2 - od) * (n + 2); + div = d + 1; + } + return clk_hw_register_fixed_factor(NULL, name, "clkin", 0, + mult, div); +}; + +static struct clk_hw *aspeed_ast2500_calc_pll(const char *name, u32 val) +{ + unsigned int mult, div; + + if (val & AST2500_HPLL_BYPASS_EN) { + /* Pass through mode */ + mult = div = 1; + } else { + /* F = clkin * [(M+1) / (N+1)] / (P + 1) */ + u32 p = (val >> 13) & 0x3f; + u32 m = (val >> 5) & 0xff; + u32 n = val & 0x1f; + + mult = (m + 1) / (n + 1); + div = p + 1; + } + + return clk_hw_register_fixed_factor(NULL, name, "clkin", 0, + mult, div); +} + +static void __init aspeed_ast2400_cc(struct regmap *map) +{ + struct clk_hw *hw; + u32 val, freq, div; + + /* + * CLKIN is the crystal oscillator, 24, 48 or 25MHz selected by + * strapping + */ + regmap_read(map, ASPEED_STRAP, &val); + if (val & CLKIN_25MHZ_EN) + freq = 25000000; + else if (val & AST2400_CLK_SOURCE_SEL) + freq = 48000000; + else + freq = 24000000; + hw = clk_hw_register_fixed_rate(NULL, "clkin", NULL, 0, freq); + pr_debug("clkin @%u MHz\n", freq / 1000000); + + /* + * High-speed PLL clock derived from the crystal. This the CPU clock, + * and we assume that it is enabled + */ + regmap_read(map, ASPEED_HPLL_PARAM, &val); + WARN(val & AST2400_HPLL_STRAPPED, "hpll is strapped not configured"); + aspeed_clk_data->hws[ASPEED_CLK_HPLL] = aspeed_ast2400_calc_pll("hpll", val); + + /* + * Strap bits 11:10 define the CPU/AHB clock frequency ratio (aka HCLK) + * 00: Select CPU:AHB = 1:1 + * 01: Select CPU:AHB = 2:1 + * 10: Select CPU:AHB = 4:1 + * 11: Select CPU:AHB = 3:1 + */ + regmap_read(map, ASPEED_STRAP, &val); + val = (val >> 10) & 0x3; + div = val + 1; + if (div == 3) + div = 4; + else if (div == 4) + div = 3; + hw = clk_hw_register_fixed_factor(NULL, "ahb", "hpll", 0, 1, div); + aspeed_clk_data->hws[ASPEED_CLK_AHB] = hw; + + /* APB clock clock selection register SCU08 (aka PCLK) */ + hw = clk_hw_register_divider_table(NULL, "apb", "hpll", 0, + scu_base + ASPEED_CLK_SELECTION, 23, 3, 0, + ast2400_div_table, + &aspeed_clk_lock); + aspeed_clk_data->hws[ASPEED_CLK_APB] = hw; +} + +static void __init aspeed_ast2500_cc(struct regmap *map) +{ + struct clk_hw *hw; + u32 val, freq, div; + + /* CLKIN is the crystal oscillator, 24 or 25MHz selected by strapping */ + regmap_read(map, ASPEED_STRAP, &val); + if (val & CLKIN_25MHZ_EN) + freq = 25000000; + else + freq = 24000000; + hw = clk_hw_register_fixed_rate(NULL, "clkin", NULL, 0, freq); + pr_debug("clkin @%u MHz\n", freq / 1000000); + + /* + * High-speed PLL clock derived from the crystal. This the CPU clock, + * and we assume that it is enabled + */ + regmap_read(map, ASPEED_HPLL_PARAM, &val); + aspeed_clk_data->hws[ASPEED_CLK_HPLL] = aspeed_ast2500_calc_pll("hpll", val); + + /* Strap bits 11:9 define the AXI/AHB clock frequency ratio (aka HCLK)*/ + regmap_read(map, ASPEED_STRAP, &val); + val = (val >> 9) & 0x7; + WARN(val == 0, "strapping is zero: cannot determine ahb clock"); + div = 2 * (val + 1); + hw = clk_hw_register_fixed_factor(NULL, "ahb", "hpll", 0, 1, div); + aspeed_clk_data->hws[ASPEED_CLK_AHB] = hw; + + /* APB clock clock selection register SCU08 (aka PCLK) */ + regmap_read(map, ASPEED_CLK_SELECTION, &val); + val = (val >> 23) & 0x7; + div = 4 * (val + 1); + hw = clk_hw_register_fixed_factor(NULL, "apb", "hpll", 0, 1, div); + aspeed_clk_data->hws[ASPEED_CLK_APB] = hw; +}; + static void __init aspeed_cc_init(struct device_node *np) { struct regmap *map; @@ -130,6 +300,13 @@ static void __init aspeed_cc_init(struct device_node *np) return; } + if (of_device_is_compatible(np, "aspeed,ast2400-scu")) + aspeed_ast2400_cc(map); + else if (of_device_is_compatible(np, "aspeed,ast2500-scu")) + aspeed_ast2500_cc(map); + else + pr_err("unknown platform, failed to add clocks\n"); + aspeed_clk_data->num = ASPEED_NUM_CLKS; ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, aspeed_clk_data); if (ret)