From patchwork Fri Dec 1 21:51:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 120399 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp1680063qgn; Fri, 1 Dec 2017 13:54:39 -0800 (PST) X-Google-Smtp-Source: AGs4zMYWmVPpQap48ANmQ3oKnFGkcmm5EzfMLPNSiuB+XMa2nf70SAke+QyfsNgIe9X84LXD3gpc X-Received: by 10.84.195.36 with SMTP id i33mr7620103pld.189.1512165279696; Fri, 01 Dec 2017 13:54:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512165279; cv=none; d=google.com; s=arc-20160816; b=uf2nOVuU/yqw6q8RwhQBFwEcJ73oklM4fzJOfrmFO9y3r1d6LhrjxK3bbf7xszoEFY 9VyOw+86RrSvHHQyYPS8kG2sgRi0E9UtxspsaIdx+6EzTweg+qJv/K3XowEbDdQd8Y9j CWguE2r0OEo9UY+X7z6D3Test8dYiVl4HBwGT92Y737/bBhhBcRWTHVL+Zx+phDnW89f Q5vahr5OQkJdcZeETVsohiIEJF3P15ChF6nqEUK5K6b2LusdyxnUA7l1Z++pwcxSoVco l9iILRo4XfxFUcOzSizKuWPX+HyzS4yYUlBspjRvP/W/PDNTV+B1/zN3J2Hm3pNDzaCf duVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=Lb3LUfd89pdtkjUVI6Uzl7AslXJpms42nE/cgnwC1uc=; b=OQhkm7huyLZHI8eMDnFj4hCZ9fqa4ytfVE4ADTysUkklnEB+9pgLq27z6mgZFRn8v9 a6+Qi/ypDFJMTl3RC5FWW9/uYk4dLY7Hz5aNLO4piVjjZ0r2vbvmiF8f5b2H1ZQDDbIv qz+n9yHCSsV13KsmWefh+qZzgIAEEbfZFkCN42cWMAtQof14H6EPvolzjnnxVY7aviRx /wUavXi4fcRTBn0qZBbCupoF9rIfI1yG1DMiTyuQbaioT8s3An0WnBTJITM4EMKUfyQt M1udKMHbd53ohKDy/ziScDKYd7XeLoy16jNAPXhDbiWnz3Y09R/0LNsrAjjEnkYjv/c0 DvyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=I02Oconm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si5540022plk.773.2017.12.01.13.54.39; Fri, 01 Dec 2017 13:54:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=I02Oconm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbdLAVyh (ORCPT + 28 others); Fri, 1 Dec 2017 16:54:37 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:44344 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbdLAVwJ (ORCPT ); Fri, 1 Dec 2017 16:52:09 -0500 Received: by mail-wr0-f193.google.com with SMTP id l22so11504481wrc.11 for ; Fri, 01 Dec 2017 13:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Lb3LUfd89pdtkjUVI6Uzl7AslXJpms42nE/cgnwC1uc=; b=I02OconmEgPOMzUfeAiULRNhr1dT3v/+ScQPxcViZRvY2dp6pS95vaTvyd7An7/Pyi Ws4ZswBl9FH8OwQzjeTZi+1fscNqcRknB7g9nt1Pk3i3DYSSwCxm440xBmMS6Q2qItry 4V4Yr4+B2doMU1BRWZyphr1iC+RUlNCoSsiK0iRMcvMcrmW3q/FR4ph5IfBuObKj1SbA UDvMZskt88mj7SwhZaVYu6XggoPyZDA8wU1YzrIZM02fmEUmHro0TAt+bzDX5l6H+ALd nMS/RzF2GB0tdqUZ3+zaMnbQ2gRpeFX+dFSeouhhALRfvQGGAEPP7QptNU3SE2c4xy0v UZXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Lb3LUfd89pdtkjUVI6Uzl7AslXJpms42nE/cgnwC1uc=; b=meWOpBGYODIcZl6HIFziCSwEJgQzLFZfvySkRf5S0u9sLDRT3MLOo525f9Q2jkapM6 ZFm4qf+eFDNlGFGguWlkLEtShBBXBGQJd4qo38H+egcCfieYF8ihwW/xdxzVwSez7qbc 33oOYQP7hQnRb0C0MwFUgyJUjtIX3zsGO1O8TQUrmepE6JQyoKuaqzL5DZLh4R2yeWIf 9lsfADg43+zOAma0iE6KSMzLnEkvIX9hAuFT8cln5PdpDp6FTr6uVSfV9XqKTYeoiUcC Dwb/BeNroE8hfLV6CQLtybuyX+2BOKTNPzw2eq7v9163PnztQ55le8EMd4FY+KfUfyqE SxRw== X-Gm-Message-State: AJaThX4yvS7Mg1LDgiPKI7V4y+SUBq8Lweu1r5iEcSWR03DQGHSuQtOG pUPH4GJXXM7/3uqE9GfmESNDxA== X-Received: by 10.223.196.189 with SMTP id m58mr3954748wrf.7.1512165128117; Fri, 01 Dec 2017 13:52:08 -0800 (PST) Received: from localhost.localdomain (cag06-3-82-243-161-21.fbx.proxad.net. [82.243.161.21]) by smtp.googlemail.com with ESMTPSA id m134sm2078804wmg.6.2017.12.01.13.52.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2017 13:52:07 -0800 (PST) From: Jerome Brunet To: Stephen Boyd , Michael Turquette Cc: Jerome Brunet , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , Linus Walleij , Quentin Schulz , Kevin Hilman , Maxime Ripard Subject: [PATCH v5 01/10] clk: fix incorrect usage of ENOSYS Date: Fri, 1 Dec 2017 22:51:51 +0100 Message-Id: <20171201215200.23523-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171201215200.23523-1-jbrunet@baylibre.com> References: <20171201215200.23523-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ENOSYS is special and should only be used for incorrect syscall number. It does not seem to be the case here. Reported by checkpatch.pl while working on clock protection. Acked-by: Linus Walleij Tested-by: Quentin Schulz Tested-by: Maxime Ripard Acked-by: Michael Turquette Signed-off-by: Jerome Brunet --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.3 diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 647d056df88c..5fe9e63b15c6 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1888,7 +1888,7 @@ static int clk_core_set_parent(struct clk_core *core, struct clk_core *parent) /* verify ops for for multi-parent clks */ if ((core->num_parents > 1) && (!core->ops->set_parent)) { - ret = -ENOSYS; + ret = -EPERM; goto out; }