From patchwork Fri Jan 12 16:45:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shameerali Kolothum Thodi X-Patchwork-Id: 124373 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2270625qgn; Fri, 12 Jan 2018 08:48:47 -0800 (PST) X-Google-Smtp-Source: ACJfBos9YkPSuBa6edzD5d/kE1ym3Wsj69NcuDCS3B45qatOk9hd4tegI2dw7zZT8hiCT982pmYg X-Received: by 10.99.186.87 with SMTP id l23mr11597871pgu.83.1515775727027; Fri, 12 Jan 2018 08:48:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515775727; cv=none; d=google.com; s=arc-20160816; b=ELmiNLOOjUzsuQLYDKPBNzllNnaZ8OI1eD64Jioe3Kt2/fA1L/ElJqpr7ZDBteEtHx P+2pU74/03Lo/ADCaBwCnSzPr4hw33LFinPCRozfilPPQVwCb9N8nnLAQaOFPLEWiqk2 cLas72k6AlC5rg+v2vBoLDE/5MjLp1xISkKgIgBZ0JNufMQPLLmmg+WLJbPyOngTdc4V +M7JFvKa4BMlgcBUOVLmznCfXqpuZ94owgXuq6QA85qzWDmt0GoD/UMt/Km5ueTTSLWW SjR5xd87xvLP80GmfaJumvh8lI9oU/erzW4+KniWrdEPEue15cqakFQuCdpA+DgHw3jS EXVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=w1uvBAsxO/IrZWpeXJxATHBWibyeHOMEAWWLndSHzCg=; b=vAtw0UTb/o4zrk8UjxjrKVbllXKg9c08qmKVJkbyqjKG4xrZ9thtce8qbvRQYrndRD Fs4zJxHbyH2vInmo3zZ+/duzEjh5Ylcp9/q3LKE6Do7sHegvLMV1N3AeHC5g+rDqA2rg geon5c2/ozp6MDfafN18vIyETiE6VcnOXeofYpWzurDoo92wyiX05P5YdN7BkSz3NHnQ ocrv7j38Ln3LiWIlPnGM0V0Yhnwq/XwPQxFKoUwLJPezT2aCE1VRjWxySy5cfD8RI3WN Y159Hh/ZkwnFmNwCwu7BVfNarEu0g0NTKTg/vDiFw0pMpCuiycswKr/YuK5aIKtVnBUL NXzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 91si3501865ply.410.2018.01.12.08.48.46; Fri, 12 Jan 2018 08:48:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965004AbeALQsp (ORCPT + 28 others); Fri, 12 Jan 2018 11:48:45 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:48539 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S964828AbeALQsn (ORCPT ); Fri, 12 Jan 2018 11:48:43 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 43C95CBA57363; Sat, 13 Jan 2018 00:48:24 +0800 (CST) Received: from S00345302A-PC.china.huawei.com (10.202.227.237) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.361.1; Sat, 13 Jan 2018 00:48:17 +0800 From: Shameer Kolothum To: , , CC: , , , , , Shameer Kolothum Subject: [RFC v2 4/5] vfio/type1: Add IOVA range capability support Date: Fri, 12 Jan 2018 16:45:30 +0000 Message-ID: <20180112164531.93712-5-shameerali.kolothum.thodi@huawei.com> X-Mailer: git-send-email 2.12.0.windows.1 In-Reply-To: <20180112164531.93712-1-shameerali.kolothum.thodi@huawei.com> References: <20180112164531.93712-1-shameerali.kolothum.thodi@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.202.227.237] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This allows the user-space to retrieve the supported IOVA range(s), excluding any reserved regions. The implementation is based on capability chains, added to VFIO_IOMMU_GET_INFO ioctl. Signed-off-by: Shameer Kolothum --- drivers/vfio/vfio_iommu_type1.c | 91 +++++++++++++++++++++++++++++++++++++++++ include/uapi/linux/vfio.h | 23 +++++++++++ 2 files changed, 114 insertions(+) -- 1.9.1 diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index 47ea490..dc6ed85 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -1893,6 +1893,67 @@ static int vfio_domains_have_iommu_cache(struct vfio_iommu *iommu) return ret; } +static int vfio_add_iova_cap(struct vfio_info_cap *caps, void *cap_type, + size_t size) +{ + struct vfio_info_cap_header *header; + struct vfio_iommu_type1_info_cap_iova *iova_cap, *iova = cap_type; + + header = vfio_info_cap_add(caps, size, + VFIO_IOMMU_TYPE1_INFO_CAP_IOVA, 1); + if (IS_ERR(header)) + return PTR_ERR(header); + + iova_cap = container_of(header, + struct vfio_iommu_type1_info_cap_iova, header); + iova_cap->nr_iovas = iova->nr_iovas; + memcpy(iova_cap->iova_ranges, iova->iova_ranges, + iova->nr_iovas * sizeof(*iova->iova_ranges)); + return 0; +} + +static int vfio_build_iommu_iova_caps(struct vfio_iommu *iommu, + struct vfio_info_cap *caps) +{ + struct vfio_iommu_type1_info_cap_iova *iova_cap; + struct vfio_iova *iova; + size_t size; + int iovas = 0, i = 0, ret; + + mutex_lock(&iommu->lock); + + list_for_each_entry(iova, &iommu->iova_list, list) + iovas++; + + if (!iovas) { + ret = EINVAL; + goto out_unlock; + } + + size = sizeof(*iova_cap) + (iovas * sizeof(*iova_cap->iova_ranges)); + + iova_cap = kzalloc(size, GFP_KERNEL); + if (!iova_cap) { + ret = -ENOMEM; + goto out_unlock; + } + + iova_cap->nr_iovas = iovas; + + list_for_each_entry(iova, &iommu->iova_list, list) { + iova_cap->iova_ranges[i].start = iova->start; + iova_cap->iova_ranges[i].end = iova->end; + i++; + } + + ret = vfio_add_iova_cap(caps, iova_cap, size); + + kfree(iova_cap); +out_unlock: + mutex_unlock(&iommu->lock); + return ret; +} + static long vfio_iommu_type1_ioctl(void *iommu_data, unsigned int cmd, unsigned long arg) { @@ -1914,6 +1975,8 @@ static long vfio_iommu_type1_ioctl(void *iommu_data, } } else if (cmd == VFIO_IOMMU_GET_INFO) { struct vfio_iommu_type1_info info; + struct vfio_info_cap caps = { .buf = NULL, .size = 0 }; + int ret; minsz = offsetofend(struct vfio_iommu_type1_info, iova_pgsizes); @@ -1927,6 +1990,34 @@ static long vfio_iommu_type1_ioctl(void *iommu_data, info.iova_pgsizes = vfio_pgsize_bitmap(iommu); + if (info.argsz == minsz) + goto done; + + ret = vfio_build_iommu_iova_caps(iommu, &caps); + if (ret) + return ret; + + if (caps.size) { + info.flags |= VFIO_IOMMU_INFO_CAPS; + minsz = offsetofend(struct vfio_iommu_type1_info, + cap_offset); + if (info.argsz < sizeof(info) + caps.size) { + info.argsz = sizeof(info) + caps.size; + info.cap_offset = 0; + } else { + vfio_info_cap_shift(&caps, sizeof(info)); + if (copy_to_user((void __user *)arg + + sizeof(info), caps.buf, + caps.size)) { + kfree(caps.buf); + return -EFAULT; + } + info.cap_offset = sizeof(info); + } + + kfree(caps.buf); + } +done: return copy_to_user((void __user *)arg, &info, minsz) ? -EFAULT : 0; diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h index e3301db..8671448 100644 --- a/include/uapi/linux/vfio.h +++ b/include/uapi/linux/vfio.h @@ -517,7 +517,30 @@ struct vfio_iommu_type1_info { __u32 argsz; __u32 flags; #define VFIO_IOMMU_INFO_PGSIZES (1 << 0) /* supported page sizes info */ +#define VFIO_IOMMU_INFO_CAPS (1 << 1) /* Info supports caps */ __u64 iova_pgsizes; /* Bitmap of supported page sizes */ + __u32 cap_offset; /* Offset within info struct of first cap */ +}; + +/* + * The IOVA capability allows to report the valid IOVA range(s) + * excluding any reserved regions associated with dev group. Any dma + * map attempt outside the valid iova range will return error. + * + * The structures below define version 1 of this capability. + */ +#define VFIO_IOMMU_TYPE1_INFO_CAP_IOVA 1 + +struct vfio_iova_range { + __u64 start; + __u64 end; +}; + +struct vfio_iommu_type1_info_cap_iova { + struct vfio_info_cap_header header; + __u32 nr_iovas; + __u32 reserved; + struct vfio_iova_range iova_ranges[]; }; #define VFIO_IOMMU_GET_INFO _IO(VFIO_TYPE, VFIO_BASE + 12)