From patchwork Wed Jan 31 18:09:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 126403 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp972615ljc; Wed, 31 Jan 2018 10:15:23 -0800 (PST) X-Google-Smtp-Source: AH8x226Q+86/I7Y/7jxsJpOIlZTsLYutuuvW0fCEEQzZSlDfgyGTDWcRa/OoPUIiByJH2XkuIY1t X-Received: by 10.99.109.77 with SMTP id i74mr252624pgc.380.1517422523135; Wed, 31 Jan 2018 10:15:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517422523; cv=none; d=google.com; s=arc-20160816; b=VRGDd7uZSJLfHiPS6Ce7MUjfK4xQeiwAUsdBRFZ1flqHqghfsJS5z5ktOHjMzLXzsr nKAagFpiCU7zDu3gn1choC9PRwJ/rnjyO056vbD7Mz1vP/nFl6CWiCnYDt8n3fnQ0vLd LaWARBd4r0vHFzKvrxrD14aBTQBjSPkRc9xm9COKONlw8TJ+x/73VvJRNW9YXLoT1kkE ScZUXAvImKCm4XyuvLH5oK0dxc6veejQYyCMjkMQx0Y7E8F0i1UhN2yqHYUNVU0L6ik2 /9XUBMv9dc6i8mM8NWG0CyubA5P+jSlvSgPbC3fdl6ixlxFHR0DI1e56K9Kc5NOKM3ma p7GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=01ty/OQ+wCVmfw367gGl5UXJI0td1BrQUYLs9s91Cds=; b=cdi6tedAjdlsSeJMoeK3JUpxMc1Uywev0h7gxB5b8IBhbruJ0iZej8B2AzmlhIgx9p CNVF85cZa7m9NScAlxfN6qByluy+SYy7QPVryeDjuxf66GMoH3UWqMaHqG4578ZhX9qN h0iw3yz7+6VtyxEAk3SghGjZkEQZPfIgo5q56hdrO6hQG4iHmyulfm4J6+6Eq49AK7TD mYmI4htmwWY0p1y5+tyjF6lZL/b2AJ0FqYLOVKRvhr3RBpyhquEDAj8T+h+LKvKDC/JB 750yOPXRWhHja3L/BUAfTh98cIJgN/1zksOG/IOheY8LWG/D8RKl/cgn+fvKtiz7qsjd 0OtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=RgJ/mnp9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d13si5156777pgu.579.2018.01.31.10.15.22; Wed, 31 Jan 2018 10:15:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=RgJ/mnp9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753973AbeAaSPT (ORCPT + 27 others); Wed, 31 Jan 2018 13:15:19 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:38530 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753563AbeAaSJx (ORCPT ); Wed, 31 Jan 2018 13:09:53 -0500 Received: by mail-wr0-f196.google.com with SMTP id t94so4498410wrc.5 for ; Wed, 31 Jan 2018 10:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=01ty/OQ+wCVmfw367gGl5UXJI0td1BrQUYLs9s91Cds=; b=RgJ/mnp9GZbPG+VGI2cw3u3O/m6Y6i2xzu7+zrOJnMb7B0CfPAnoc7nbCFbskEA86l liYfGD/48XII2p5qI6+FaL+pKCCeagMi+Cj7phjned/Dd8k0ByI798h3+byJl1iGS/CL IkUrAlNbly6DOt6P70nBAyjYEaw8WxCJKmzkHXuXJTQIb4J27kukFaTxM7M1Sj94VAWJ GtpnBVWYNTFH4PVBIU+MX1q2bgi/AjCWpDNY3wfBWWIRd/lYmWZ/Y0nsQcXScEwi+ZG/ UZaIdrfEdf2/qzqnB64uc0pPoMAruwnulD1o8xjx3qPyKXsEEmckFX+y/bgZEEaXeF42 cSMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=01ty/OQ+wCVmfw367gGl5UXJI0td1BrQUYLs9s91Cds=; b=X+kmhTi5O2j+OzKCNZ4Nu1fwL546KKIyeIB7r5UfNuInOoFjFAWW+ykjvYFst7sTR8 r+JUAT5Tge4TPyLWBbePsc10q4jvBK1ZpylgC8Ul4j6fsEUeirXr4AoZQo3r1JnmEmXh hY7AA9dlOc60L00YktPErLtUdKq2JdPHtozaMwC6xBWQ7kC+8kwJdrL/bHgl5b1zTxDB 85gyVk/ZBpsHgpFVTqztruQhsR2akclZ86DFdHinV6WDoaNWKrFFcB1DFubFeyUd+uFQ mJzB9+dhNusrR1fIhFsbCtmaupccxN2+Vdk48rSb2/MDEgEk1leh5hlgB4wxhb7RiGEn tN+w== X-Gm-Message-State: AKwxytfmwznf0Aama2bq73LIrhVvlomF9Nx+ldx72WXb1rdyUr58peSI G6lgG8kYU9S3sEcplwC8R2vdsw== X-Received: by 10.223.175.196 with SMTP id y4mr22237114wrd.195.1517422192547; Wed, 31 Jan 2018 10:09:52 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id f8sm341977wmc.3.2018.01.31.10.09.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Jan 2018 10:09:52 -0800 (PST) From: Jerome Brunet To: Neil Armstrong , Kevin Hilman Cc: Jerome Brunet , Stephen Boyd , Michael Turquette , Carlo Caione , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/19] clk: meson: only one loop index is necessary in probe Date: Wed, 31 Jan 2018 19:09:29 +0100 Message-Id: <20180131180945.18025-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180131180945.18025-1-jbrunet@baylibre.com> References: <20180131180945.18025-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't need several loop index variables in the probe function This is far from being critical but since we are doing a vast rework of meson clock controllers, now is the time to lower the entropy a bit Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 8 ++++---- drivers/clk/meson/gxbb.c | 13 ++++++------- drivers/clk/meson/meson8b.c | 8 ++++---- 3 files changed, 14 insertions(+), 15 deletions(-) -- 2.14.3 diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 2f2b3845c01d..81565b025b70 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -802,7 +802,7 @@ static int axg_clkc_probe(struct platform_device *pdev) const struct clkc_data *clkc_data; struct resource *res; void __iomem *clk_base; - int ret, clkid, i; + int ret, i; clkc_data = of_device_get_match_data(dev); if (!clkc_data) @@ -841,13 +841,13 @@ static int axg_clkc_probe(struct platform_device *pdev) clkc_data->clk_dividers[i]->reg = clk_base + (u64)clkc_data->clk_dividers[i]->reg; - for (clkid = 0; clkid < clkc_data->hw_onecell_data->num; clkid++) { + for (i = 0; i < clkc_data->hw_onecell_data->num; i++) { /* array might be sparse */ - if (!clkc_data->hw_onecell_data->hws[clkid]) + if (!clkc_data->hw_onecell_data->hws[i]) continue; ret = devm_clk_hw_register(dev, - clkc_data->hw_onecell_data->hws[clkid]); + clkc_data->hw_onecell_data->hws[i]); if (ret) { dev_err(dev, "Clock registration failed\n"); return ret; diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index 17f44ac751b3..e6adab49c0ba 100644 --- a/drivers/clk/meson/gxbb.c +++ b/drivers/clk/meson/gxbb.c @@ -1947,7 +1947,7 @@ static int gxbb_clkc_probe(struct platform_device *pdev) { const struct clkc_data *clkc_data; void __iomem *clk_base; - int ret, clkid, i; + int ret, i; struct device *dev = &pdev->dev; clkc_data = of_device_get_match_data(dev); @@ -1988,16 +1988,15 @@ static int gxbb_clkc_probe(struct platform_device *pdev) for (i = 0; i < clkc_data->clk_audio_dividers_count; i++) clkc_data->clk_audio_dividers[i]->base = clk_base; - /* - * register all clks - */ - for (clkid = 0; clkid < clkc_data->hw_onecell_data->num; clkid++) { + + /* Register all clks */ + for (i = 0; i < clkc_data->hw_onecell_data->num; i++) { /* array might be sparse */ - if (!clkc_data->hw_onecell_data->hws[clkid]) + if (!clkc_data->hw_onecell_data->hws[i]) continue; ret = devm_clk_hw_register(dev, - clkc_data->hw_onecell_data->hws[clkid]); + clkc_data->hw_onecell_data->hws[i]); if (ret) goto iounmap; } diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c index abac079ff77f..ffadad27375e 100644 --- a/drivers/clk/meson/meson8b.c +++ b/drivers/clk/meson/meson8b.c @@ -806,7 +806,7 @@ static const struct reset_control_ops meson8b_clk_reset_ops = { static int meson8b_clkc_probe(struct platform_device *pdev) { - int ret, clkid, i; + int ret, i; struct clk_hw *parent_hw; struct clk *parent_clk; struct device *dev = &pdev->dev; @@ -844,13 +844,13 @@ static int meson8b_clkc_probe(struct platform_device *pdev) * register all clks * CLKID_UNUSED = 0, so skip it and start with CLKID_XTAL = 1 */ - for (clkid = CLKID_XTAL; clkid < CLK_NR_CLKS; clkid++) { + for (i = CLKID_XTAL; i < CLK_NR_CLKS; i++) { /* array might be sparse */ - if (!meson8b_hw_onecell_data.hws[clkid]) + if (!meson8b_hw_onecell_data.hws[i]) continue; /* FIXME convert to devm_clk_register */ - ret = devm_clk_hw_register(dev, meson8b_hw_onecell_data.hws[clkid]); + ret = devm_clk_hw_register(dev, meson8b_hw_onecell_data.hws[i]); if (ret) return ret; }