From patchwork Fri Feb 9 13:24:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 127810 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp610138ljc; Fri, 9 Feb 2018 05:26:00 -0800 (PST) X-Google-Smtp-Source: AH8x227CMYpnjS9SeyrZ+LDshDq3wKXt+fRBoP0bJIz41kDQ+FBiqmG9Fsb2KEWxxHPqJPmo/zTQ X-Received: by 2002:a17:902:7d8b:: with SMTP id a11-v6mr2557888plm.216.1518182760751; Fri, 09 Feb 2018 05:26:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518182760; cv=none; d=google.com; s=arc-20160816; b=zB/GNRmxdlBWIZ+ywALubV8ojIT0pU204df1b2ZUxb3l99uSP38t6RU/5pdFxtLqEl kh5sDcuE91tH1LCrX3qodFsx/oRW/aav5QhWyZ1ZOO8QQc3lsVM3+AF4+vaktUr/fD7a ZisyvZNdlkrPAR1jIWy7jjwrBhyVsO65nE1+lyM1EJxje6ZDRXKmsvGuYilaFh9egFOE oFEftta51LHkM9k2LxKXhK6gurWwgntWXhCoaNYASKC+QRdWGtW8ABe84fIcKsOmn+XP TEold7n+jBUxYVyZiO2cfKj0fr9TvFs2Y7rFXAqz3ASovjJPDaHhHq+x/+nwfA9fZ9nk /fGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=BJDde5nLFgJE6PL9N0HQvYbH89FSw0DikspiJE+VPJc=; b=MtIACFoIh65ZAP8Jfzl+mwFoNjF788MMsyb/66YxusnkdlwYWSvfI3toH9CrgdY8B8 AxPymJv5CZYvI2QEC0w3g8Jc75d9RgHYm3S+af2+eKIio38kRlYD9xgKZJO3TbtPH25k XXvO7Vtw6AylISCFfUwhjxv0/eQkfcX6mm4uZVAJZX2HBHtfB7QSoHgP+k/t50WngS9I xRt1PVGBzN6XPzk22bPv/nywTmYB+/J2aERJpkz2kxcJ2KhCTnoDTr5dOjopD3zhF/do xSI04O3soWXw0eETdwqEQDiWhwZYB9H4CkrpQA4tt9CpIOw+Y5C7IzXqO/Fl/MN5fecR 9o1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k6-v6si1552055pla.496.2018.02.09.05.26.00; Fri, 09 Feb 2018 05:26:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751756AbeBINZ4 (ORCPT + 13 others); Fri, 9 Feb 2018 08:25:56 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:39233 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbeBINZw (ORCPT ); Fri, 9 Feb 2018 08:25:52 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0Lhkwb-1f5hvV0wiX-00mvn6; Fri, 09 Feb 2018 14:25:36 +0100 From: Arnd Bergmann To: Ping-Ke Shih Cc: Arnd Bergmann , Kalle Valo , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] rtlwifi: rtl8192cu: remove pointless memcpy Date: Fri, 9 Feb 2018 14:24:41 +0100 Message-Id: <20180209132531.2755482-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:RWBl3G8cH5p9u51X2ua0AkG1ltzUmI6b0tqV4YZ8t7HUck+ryPp CqPiaYJLbOXErZhien9xzrPJs1rKimHDChtW6Pptj5uaqs6UbenlR2Vw6XZT5WUagGgFd0z S5hJAzYajRe7LqTlSZ958RbtkjBlAR/OkUTVtQx8iJQBb+ruzwSEleELy67VcUma1NvCMBg K5A1w77cJnW4ezvFn3IWw== X-UI-Out-Filterresults: notjunk:1; V01:K0:iOmuxAw0i2A=:whEsezpDFz/1pd+SnDJgG2 /D8pKk59JIdzRqpOwYXvDbQjTG27nH7Wn8FXRrh5RJqGoXBdPLRAQEa98AhSQtlfRQRWv800C tdLIygKFuIy5uyO9SoWe3p3tFG1PtnFUAXG4XGeW8YMAmZhZz5932dOvH1Wk8iZRYOptyOhQW o1dvXic4JVL9pv9kiI1qObfmT9pd96/2svqTVOoCYCTHqE9Dgz7Fpd6w5vKWNnFJ1uSdSorIY xcMhYXRnUmB5m0+xqDHlSpT53ib8sv82kbMpqW9vmqTndNB+D9bj2X6BktaoNd7tnG8WRPUav 3bW/pCcf3XCiydzzfEWEmhVlS/lV5DmKkGRxFljC44YZ51pHKb9dpMMTstiVskrLYX0s/5WXQ /cj2UKSCvSg/ouUWHTPz78YK1G4ZKUUce4zIau76K60wy9b349nfZErZfnkCabjnCcxRt/fLy URN8/bb9iCOe8ptCbHXJDL9eHZUWHHiKKkiSM7JEuO46dbylhIWI5gonQOc+U2auReKUGOdd0 F0tDxv0TfnEXYb2kMRXSzG+HtEHedBsDojfU0hd5klfxODU2vOjqcsiNHEGqwOwTZ4wiSP0rN MujyqujgtOXZOiZefcs4oOLo+ueOz9fOQviy822w4xjYOX7xxBwmcJu875VUuUDauuz7JFVlv Lx8wpLsDT4XYQZgLp9G++rN1aiOD2PkVHbvWrijEnkitmUaifjH6/3kWmXAvWCdGHDVPxUbDp RHEu9AKKZmLoSkO2+QW5Mxx/TCee1CqeHnrlwQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-8 points out that source and destination of the memcpy() are always the same pointer, so the effect of memcpy() is undefined here (its arguments must not overlap): drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In function '_rtl_rx_process': drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:430:2: error: 'memcpy' source argument is the same as destination [-Werror=restrict] Most likely this is harmless, but it's easy to just remove the line and get rid of the warning. Signed-off-by: Arnd Bergmann --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 1 - 1 file changed, 1 deletion(-) -- 2.9.0 Acked-by: Larry Finger diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c index ac4a82de40c7..9ab56827124e 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c @@ -427,7 +427,6 @@ static void _rtl_rx_process(struct ieee80211_hw *hw, struct sk_buff *skb) (u32)hdr->addr1[0], (u32)hdr->addr1[1], (u32)hdr->addr1[2], (u32)hdr->addr1[3], (u32)hdr->addr1[4], (u32)hdr->addr1[5]); - memcpy(IEEE80211_SKB_RXCB(skb), rx_status, sizeof(*rx_status)); ieee80211_rx(hw, skb); }