From patchwork Fri Jun 1 16:52:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salil Mehta X-Patchwork-Id: 137560 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1178251lji; Fri, 1 Jun 2018 09:54:15 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLw1ablqV62oH1UW+6oEu0BSCsHqpiYvNRCIbDRY9DtWVfM7kGwHJVn25ksUlb5ICCg2ExE X-Received: by 2002:a63:b109:: with SMTP id r9-v6mr9129589pgf.102.1527872055626; Fri, 01 Jun 2018 09:54:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527872055; cv=none; d=google.com; s=arc-20160816; b=RaZLw2nqn2wSgvDRNuDFzpN0moi4yhwY2PVLDwI+1cPrOWz5e8v+YPIP75DUdudrmX PsXSX7c5PhcFQipUCDc3aXWldDcy/ayFYTVPK3DJB404fEsSrDZa9eduYTCHpGpZVOvW I7MBKeEY2lX3HR9JwAMfMa65N+Ntg9iQvLuWDFF/juQbwE7nnz/U/HWIwcyqvrkL8pXc sIXLk1liOxnOaD+ZGmsp2McgK9n43WuzlFLV1zFsUZf1ZuOaTZeATVg2Xf1L96VQ4t7w Lgi1faKgVXk/T09YXJEQ86LFrQLMTOB6wLP9SDzGaxfjyC+Ld1+YXffHLIDppDdN52FU bB7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=kXxMlxEmtoQJcqQI54hA2GaRg9/vi6fJcYWAkrVKAN0=; b=DEv50957+U63ilrcmFu12UfxhY3C/67D1322N3iOt/6Ot+JL0flySUbgrAsR8iH0BV 8lVOwMwhwVXGVShYwUU/v9Z97Ozvgi4lN0STtE6WPFWTA6Nx8SJiewSaegQWTIlw6+8s UfLma1UfGm9CgKxYu9X4b9iCtZSC2oa+vT7OmBnu1KsBLGaId/Etd+h3/JHtpcBJ4Y5G gR1y/KC2N87FpieES6XcC61Z6cHpOd6IIR7RPCE/imJFvzU6CWbTgs+UHdh2/yyg3ng5 k9LDevGHuvvrXJauvEFz1QA48+l5s8EuS27/Ehs514bv+7NWK4fL7qnFy34v5Jwdmb9c 7+Ng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s13-v6si38877616plq.464.2018.06.01.09.54.15; Fri, 01 Jun 2018 09:54:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753395AbeFAQyO (ORCPT + 30 others); Fri, 1 Jun 2018 12:54:14 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8682 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753307AbeFAQyL (ORCPT ); Fri, 1 Jun 2018 12:54:11 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 75C0B104C2503; Sat, 2 Jun 2018 00:53:56 +0800 (CST) Received: from S00293818-DELL1.china.huawei.com (10.202.227.234) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.382.0; Sat, 2 Jun 2018 00:53:49 +0800 From: Salil Mehta To: CC: , , , , , , , Yunsheng Lin Subject: [PATCH net-next 08/11] net: hns3: Add missing break in misc_irq_handle Date: Fri, 1 Jun 2018 17:52:08 +0100 Message-ID: <20180601165211.46372-9-salil.mehta@huawei.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20180601165211.46372-1-salil.mehta@huawei.com> References: <20180601165211.46372-1-salil.mehta@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.202.227.234] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yunsheng Lin There is a break missing in the switch/case handling in hclge_misc_irq_handle, which causes the log to output uncorrectly. This patch adds the missing break, and change the dev_dbg to dev_warn in order to better catch the error. Fixes: c1a81619d73a ("net: hns3: Add mailbox interrupt handling to PF driver") Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index 58fef5e..19e5689 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -2580,10 +2580,10 @@ static irqreturn_t hclge_misc_irq_handle(int irq, void *data) * mbx messages reported by this interrupt. */ hclge_mbx_task_schedule(hdev); - + break; default: - dev_dbg(&hdev->pdev->dev, - "received unknown or unhandled event of vector0\n"); + dev_warn(&hdev->pdev->dev, + "received unknown or unhandled event of vector0\n"); break; }