From patchwork Fri Jul 6 12:57:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 141309 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp3083165ljj; Fri, 6 Jul 2018 05:58:14 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcqVqf+cp8zKXZfJcEgU1GAiQoDMx3N1DGVBmTxFPZibM30u6QIDwsJT9dGz9rUi6q8VWLu X-Received: by 2002:a17:902:7798:: with SMTP id o24-v6mr10465839pll.165.1530881894279; Fri, 06 Jul 2018 05:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530881894; cv=none; d=google.com; s=arc-20160816; b=JKmIvFP39P3lVfjBRm7WB8Ea2p5C4hqPtzhLkvwvIZ4TRJro65iKk5yevWaoQsTCSB Wwj9GDYA8GdPC7UM9DO/FXFmwFAIe9JGjGZCdAUO1OOLWuCW6yegY5hWJNZDVGMNP3TJ H3/hu6A0W+ca/JP8pmeeHoAZtPvbennSVuG8avtG6OCI1hm2lOeU+tyu8IDnakWWHhnJ lWExxvfUs9Ua9AXBldP6dtU0hSGIgx4Qw9/TedCzzf8QSp5bwjHGfi9R6nLR5NHhM8Zr gCdonG3ZEsxPupJ+lk7IuvazOAg9e5U2V6vm6ePXV4e/sQBR5kxpaO15dRf+64/W9qty rERw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=JnpoHUXux9VlzVrXdff74qHyMUb0FpT/Su0NPWVzXHM=; b=vp56ZbAfT9605gTDmoB8lQd7IkHPyi2llPzWZX/ynp5QUVbtky8U2sLYrpnkavwViv S6zMYO1GnBNyaV5Zm6vATgaUgvW/lUZEQZ5NWowXaYS85ITTiQOSrMXHsoIocSq0eD7G UsetHyqmKPCYAt1SeeEF2c8QfHPnzHEGQ5YPhcctfBxTeMjtMStYw81nPfuPqZI4aDUk 5DbLWOVGUzfS0Y5TQtGoCyFZh0IJJgbAvpptEsc8ZfSSRCjY0QyyL5yQRd99KgtBWf+N QPPyJO0zMiA/o08sCRO/mj7+EC0D5ds//8r/9k15Y5OGGtXtEIwMFlNnTUs+QDsVUHkX /wnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12-v6si8472381pll.384.2018.07.06.05.58.14; Fri, 06 Jul 2018 05:58:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933208AbeGFM6M (ORCPT + 31 others); Fri, 6 Jul 2018 08:58:12 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:47263 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932569AbeGFM6K (ORCPT ); Fri, 6 Jul 2018 08:58:10 -0400 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0M57wk-1gK3hj47G2-00zHrR; Fri, 06 Jul 2018 14:58:06 +0200 From: Arnd Bergmann To: Ohad Ben-Cohen , Bjorn Andersson Cc: Arnd Bergmann , Rohit kumar , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] remoteproc: qcom q6v5: fix modular build Date: Fri, 6 Jul 2018 14:57:53 +0200 Message-Id: <20180706125804.3572356-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:fYjIpTCZeiuDLYyttD5TMJmFddXwIZ3tagL/l5VM0K82PkzJijH dBd/nr0KCIRwTzOgDXDvhayOVMBB9hHKp3GinnVVMhGdhnSU75/MRlLuTlH6wYjr0ftquUL NnApXOMdnQuhXBJOQKyz54bvDCFnNVAlYIfAf1zbet+/RLaC6KeTZkksqkxwL7NXdCBDPiq JWc0D0K4D9CaYcQ7kR/XQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:eR00jwDB2zI=:7mb4k/OailC9ldFTnj1rAP BwZicdybztTFpLVIQffT+k9umjzBIpzzSFdrs1EuOOznaYXfxZ4r4jwUBaTUJmfYRFIBwcrph U3vZp4WAtEC/4q7IAz+DjZmYaVlkE5716sPCoUU18KoOfHIay2UEyGqv4ELkleBfnlYGYHVtZ MmQKnBGS5BxUSFOrdSS0t1RX4c6eTFmPcBlcJaErDhd4XWjNz6KmoBB1IfC3nwU17UyZlB/ad AtxormRwa4rYzn5MFZRFVc01+MWb4EKswLf5hxUjZDbxZSxe5of+j+iZh2kBu/pvTkwH1H+6K iPXig2+NjFow0O4T/Oje9fWtB6LgeIVxpKDk+pXpCDdFmqrs56vtrB/424KNcTAkEz/CsdKdW ntYZUIY8j72A//LjuRGgUvnq9iwtxk1NDHpuKvFcyKsZT0pDw8DHVBwOmm+gfMs6q7xnntMFG VbkB2ysfH51TJmj7Hc4IVPkSO6Am2SURuOScoEzJ9eZsf7sKSOBpftZEyGJNfK9z47FOpd3Rf /W5na+mzuEgHmh2eZBKOHS6HMLYbSNqy5NVahxIfI6Trne04P3lc2+p88rZbxsncRyTAnxK+1 SgtSJXAqgWL5owiUQfZCjmA2lNhvxIllgoy31/jXN5S4OjQfqZXubjcHGDK3BC6rglx8sc95T mNpU1XBQApbfAqbqoM6cUko8iicCfVuzjslZnzeBPnrpXM0fHhqFXYISDL3vbbOSgHRY= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The new driver only works as built-in code at the moment but fails with a link error when configured as a loadable module: WARNING: modpost: missing MODULE_LICENSE() in drivers/remoteproc/qcom_q6v5.o see include/linux/module.h for more information ERROR: "qcom_q6v5_init" [drivers/remoteproc/qcom_q6v5_pil.ko] undefined! ERROR: "qcom_q6v5_wait_for_start" [drivers/remoteproc/qcom_q6v5_pil.ko] undefined! ERROR: "qcom_q6v5_prepare" [drivers/remoteproc/qcom_q6v5_pil.ko] undefined! ERROR: "qcom_q6v5_unprepare" [drivers/remoteproc/qcom_q6v5_pil.ko] undefined! ERROR: "qcom_q6v5_request_stop" [drivers/remoteproc/qcom_q6v5_pil.ko] undefined! ERROR: "qcom_q6v5_init" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! ERROR: "qcom_q6v5_wait_for_start" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! ERROR: "qcom_q6v5_prepare" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! ERROR: "qcom_q6v5_unprepare" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! ERROR: "qcom_q6v5_request_stop" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! This exports the internal symbols as needed and adds the MODULE_LICENSE() and MODULE_DESCRIPTION() tags. I could not figure out the author, so I did not add a MODULE_AUTHOR() tag for now. Fixes: 3b415c8fb263 ("remoteproc: q6v5: Extract common resource handling") Signed-off-by: Arnd Bergmann --- drivers/remoteproc/qcom_q6v5.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.9.0 diff --git a/drivers/remoteproc/qcom_q6v5.c b/drivers/remoteproc/qcom_q6v5.c index 400cdf936f6b..61a760ee4aac 100644 --- a/drivers/remoteproc/qcom_q6v5.c +++ b/drivers/remoteproc/qcom_q6v5.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -32,6 +33,7 @@ int qcom_q6v5_prepare(struct qcom_q6v5 *q6v5) return 0; } +EXPORT_SYMBOL_GPL(qcom_q6v5_prepare); /** * qcom_q6v5_unprepare() - unprepare the qcom_q6v5 context after stop @@ -45,6 +47,7 @@ int qcom_q6v5_unprepare(struct qcom_q6v5 *q6v5) return !q6v5->handover_issued; } +EXPORT_SYMBOL_GPL(qcom_q6v5_unprepare); static irqreturn_t q6v5_wdog_interrupt(int irq, void *data) { @@ -114,6 +117,7 @@ int qcom_q6v5_wait_for_start(struct qcom_q6v5 *q6v5, int timeout) return !ret ? -ETIMEDOUT : 0; } +EXPORT_SYMBOL_GPL(qcom_q6v5_wait_for_start); static irqreturn_t q6v5_handover_interrupt(int irq, void *data) { @@ -157,6 +161,7 @@ int qcom_q6v5_request_stop(struct qcom_q6v5 *q6v5) return ret == 0 ? -ETIMEDOUT : 0; } +EXPORT_SYMBOL_GPL(qcom_q6v5_request_stop); /** * qcom_q6v5_init() - initializer of the q6v5 common struct @@ -241,3 +246,7 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct platform_device *pdev, return 0; } +EXPORT_SYMBOL_GPL(qcom_q6v5_init); + +MODULE_LICENSE("GPL v2"); +MODULE_DESCRIPTION("Qualcomm Peripheral Image Loader for Q6V5");