From patchwork Mon Jul 9 15:42:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 141445 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2815353ljj; Mon, 9 Jul 2018 08:44:07 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeGIssuxgIb581mJcI7TJyntO7quyignYLj3QaJPnBiIhyfiPIrk6G0RjyHGF4epcP+wrQ9 X-Received: by 2002:a63:4f1a:: with SMTP id d26-v6mr13585107pgb.121.1531151047078; Mon, 09 Jul 2018 08:44:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531151047; cv=none; d=google.com; s=arc-20160816; b=0M/de5VtEl5FRsJTcdP45sPhVa/Pz91RlUIPPGyPr+djf8O2yrzUlp9JKnON4Tmkf8 oRqsFImwJQYtKvUV/fXgox6L3Skkwd5iivEn5UnolsFrN7kAJNh2jbmFRO7ztyMzKVpi 5Ay4UyjrHtjKvfwJeDvqGo2cgfDUr7532+TkYw2fWepirZJkwT4RlfrXXMLPyddCmEcA Y8wMCIPgficxNr2PeXvsALTD5ojZdnKu+15SbCChrdX1p5kSPuLDAArRkO/boYX8VbdN K9pjmTQ7aPXVs+oP+ycRq7po+MpnKcSIXoBHqm8YtHk96ag747oSU+9ORpLU9ZRLn4Cc oWKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=hCMmwdl+AAw8gGIPdaexx4nT0hgG5wI4WtILHcNxv/I=; b=1Ct57gaRj87Bjwo26hgB2toWQXt3dX3cqeFyKiBxsQlXqMQiwe+VyMcEjEtEGgSHUM 7VZEcd9Q9CwbTqrlBYNWH3GXGgVWWTVdb1layiJuu7Upat+dF9DhzoWYN5kWn5bCW4lD KQKhs6xq5pXQLAWa3+TgHvW9fxyyx8yplxCnhC1NPfU6p/no4AYotTxAKx/ZKmOWT8/e 0JNafHvbgY3gQNQCVQcPXAyST2keqCsfZJhAsFeEAWBZCHJLbwCJ8yPfvm2ObbXNOGWS OYLq6QLIQqa8t1P2E5x6UkkmJ4VEr3sbM+iL6tUV8uSXCipOFmQ7ZlMgZTeZZfLJzI4H KdiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w185-v6si14124888pgd.133.2018.07.09.08.44.06; Mon, 09 Jul 2018 08:44:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933758AbeGIPoF (ORCPT + 30 others); Mon, 9 Jul 2018 11:44:05 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:56285 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932789AbeGIPoD (ORCPT ); Mon, 9 Jul 2018 11:44:03 -0400 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0MhUV0-1fOt5P1DwQ-00MfON; Mon, 09 Jul 2018 17:43:05 +0200 From: Arnd Bergmann To: Jean Delvare , Guenter Roeck Cc: Stefan Wahren , Eric Anholt , Arnd Bergmann , Vadim Pasternak , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: rpi: fix link error against rpi_firmware module Date: Mon, 9 Jul 2018 17:42:44 +0200 Message-Id: <20180709154301.1781663-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:OYy7pX97fzG4UBSw2+aByheZikuJ3InD60HQ1xbFGn0SdNMyLy1 m4OhAWss6CkeKbMcOvOJgo3SUVnVqPkxqxAzkAXheHExZcEJHInGzHmqNv2TXvCtBq8L4Eo sUszQRmv23Awrjy5G05+nrR3H6shXLunDWwefaURELGNgrKGbnLwfMB4hqsQzsMql4N7uIh d1WyqFJul9Dd2bzNkZW7g== X-UI-Out-Filterresults: notjunk:1; V01:K0:HtDR2jYM5v8=:4o6sIHfJaJny1JNgew6ZGb lZPyM4Arrrm/Zt/6BY43Q7TFxCA51l8qQCosrQttm8rByO35foyJx3dehBWXGdTc9trDj0HQO kVSIh+qrcHURxmIWqbpdTiAkWSTPNzRcaOX7BaGVK5Dw0BJSGNaJPyv9weTSdgodItGipKfxt DZrsbAYnvzd9jtz5BKYZAkI1cMhTyCb0hqyG4EaM7KZtzk9rI8dNaNAFq5Bk37nJKW7cIa4Lp JE5CWVsHm86B/tL9rlATST+XGsug+5V9zyIVsoULhO8ijp0dlHeODkpkIV8fA6vzF70OS2Sh2 iXt2rJlfzE8fQDiuuik5ZaAzaH3Y14waZZUgmqymvFZxF9e2uxc1q5HFedfEpBGa7zQ+cAiX4 J/fsaR6IRPh3mFkKwBGd8EbyrJ0dXI79O9ub19MYTSoIoUTs9BDZZdr60ffKcWfDVuyjzLet7 YAwt1EobVKjz8V2N9qpmso7NV5Rdd6usAZNchFcTwThfJrthMvvuwXDSqvz43YzVB1UhnVX99 MKsID/sKWZUVzZgzFxprHQN54Ix22oCuncnebsFqZwBpGy6jZt/ReCGmpfLMAe5mEv/FkTq0h 7a8BC1iPLuO9KW1NCsHr4wuEQ4d9vF0CMfin81o8PAaUgGmwgtlSaFskROCMDLOPP+Go1ATF0 OXqBL2cujmBEGFKONhNu3nbo6DqJlcPBCd9YJb4KTpujiS5qsIPGs2Cect8YXof6Fx6s= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Compile-testing without CONFIG_RASPBERRYPI_FIRMWARE is possible, but we cannot build the rpi hwmon driver into the kernel if the firmware code is a loadable module: drivers/hwmon/raspberrypi-hwmon.o: In function `rpi_hwmon_probe': raspberrypi-hwmon.c:(.text+0x140): undefined reference to `rpi_firmware_property' drivers/hwmon/raspberrypi-hwmon.o: In function `get_values_poll': raspberrypi-hwmon.c:(.text+0x350): undefined reference to `rpi_firmware_property' This adapts the dependency to disallow that combination. Fixes: 3c493c885cf8 ("hwmon: Add support for RPi voltage sensor") Signed-off-by: Arnd Bergmann --- drivers/hwmon/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 Acked-by: Guenter Roeck diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index a4e5d3c9fc71..81da17a42dc9 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -1322,7 +1322,7 @@ config SENSORS_PWM_FAN config SENSORS_RASPBERRYPI_HWMON tristate "Raspberry Pi voltage monitor" - depends on RASPBERRYPI_FIRMWARE || COMPILE_TEST + depends on RASPBERRYPI_FIRMWARE || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE) help If you say yes here you get support for voltage sensor on the Raspberry Pi.